mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: ZhuXiangyu <1194781887@qq.com>, Stephen Boyd <sboyd@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: rockchip: add clk-out
Date: Sat, 21 Nov 2026 14:27:08 +0100	[thread overview]
Message-ID: <dggrSgDiRmusIaCk6T6L4Q@sntech.de> (raw)
In-Reply-To: <f98c3f68-82d7-41e3-bb58-d3737b73c7b5@kernel.org>

Am Samstag, 21. November 2026, 12:02:37 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
> On 21/11/2026 11:58, ZhuXiangyu wrote:
> > Document the Rockchip clock output/input switch, a single GRF-
> > controlled gate used for signals such as the SAI MCLK output.
> > 
> > Signed-off-by: ZhuXiangyu <1194781887@qq.com>
> > ---
> >  .../bindings/clock/rockchip,clk-out.yaml      | 81 +++++++++++++++++++
> 
> Please follow carefully submitting patches document, including how to
> sign your work and how to send it correctly threaded. There are numerous
> guides already, so just follow them.
> 
> 
> >  1 file changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/clock/rockchip,clk-out.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/rockchip,clk-out.yaml b/Documentation/devicetree/bindings/clock/rockchip,clk-out.yaml
> > new file mode 100644
> > index 00000000..bf2a9b8a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/rockchip,clk-out.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/rockchip,clk-out.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip Clock Output/Input Switch
> > +
> > +maintainers:
> > +  - Heiko Stuebner <heiko@sntech.de>
> > +
> > +description: |
> > +  Some Rockchip SoCs route a clock between an internal clock and a pin
> > +  through a GRF bit, for example the SAI MCLK input/output switch. This
> > +  driver exposes that single bit as a gate clock.
> > +
> > +properties:
> > +  compatible:
> > +    const: rockchip,clk-out
> 
> Generic compatibles are not allowed. Do NOT send us downstream code,
> it's not acceptable.
> 
> Not doing detailed review as it does not follow basic rules. Please go
> through for example DTS101 slides.

this whole implementation is bogous, but it seems the submitter found
the correct way to do this in [0] .

But of course the submitter still fails to follow basic styles there.
Broken threading and especially not stating that the new one superseded
this one.

And of course yet another patch bomb in the span of minutes accross so
many different subsystems - which I guess is not a human doing it.

@ZhuXiangyu: even if you're an LLM and new to the process, don't flood
the lists - especially not before you get the process right.


[0] https://lore.kernel.org/linux-rockchip/tencent_9138CD6157C88BC2D52FE6394AF83E560208@qq.com



      reply	other threads:[~2026-11-21 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 10:58 ZhuXiangyu
2026-11-21 11:02 ` Krzysztof Kozlowski
2026-11-21 13:27   ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dggrSgDiRmusIaCk6T6L4Q@sntech.de \
    --to=heiko@sntech.de \
    --cc=1194781887@qq.com \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®