From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38796134A5 for ; Thu, 28 Mar 2024 02:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711593223; cv=none; b=cTtwnT/v6cB71MIC9eJkfvt2r26veSvHtQoAU18eajtuYrnZFUjEqI5rDfd6CoSiUExxTU3/Z1YOChw6vjRjjxX4nhJkb17JGIMAhtvConOiNCdNPVJh7EfdfcD1f1KJ/IHjZWlBG5801w6+YZpVrnGTPeYcBRlSnWcb/GHwyDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711593223; c=relaxed/simple; bh=OFojCwZ6v5ziBtsIk9oLLAj/dEaiopLScBLdXXXv8Ts=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=iCx0y0VjF4ulJx1rTgXW9IQ+hX3F3qnGi3SmV0W0FZIcwfxJZIazIjTjYhx7Nc9GKsuxjBaL1RRaxgmIOJN+355fZaVjP4ReHGG3q5lE5s3VMXB4oUoQK9GUQ9FsSPinX3ZjImnxzipr2nA/jz/lJHr7qZVtaXey3cNt0/bGsdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gY3gcPor; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gY3gcPor" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60ccc3cfa39so8164217b3.2 for ; Wed, 27 Mar 2024 19:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711593220; x=1712198020; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UkoXrrgQLG0OC6iY0Ar2KtEiFjbb+Lcngub56vU+bHo=; b=gY3gcPorLVuKWGDg68knAYdwewnr/9H5T2BsL7/oYTEltCOISa/59dCnH9aMDkrR0S mPn7C67z0xsN6OPfFDKr0Wx6Q8GoPSmhyoZmZiJwSL88WXXeuNudMI472YnZ+uHvXdcA UONUCFkmVFyoyQAdsQEgD/W+rUEitzVXDm/D32RCZnrsarvbuJIxuFGKuuLK058IFOwg JE89JeO9N2ZSqEQL4whBNSPE2N2Pws75glf1Y1COzArgBSk9q3n+107dDJ2pN4AJTnWV InU67EUSPAMi9wUtsJgBtqEMo9bma6mbXp6dNtx1FDj5LE1DvKovcvpy5HMynYjrTsqF O+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711593220; x=1712198020; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UkoXrrgQLG0OC6iY0Ar2KtEiFjbb+Lcngub56vU+bHo=; b=kDuohlFNXBksU2lqTNFZdsYqlzUQLw0IgYYh7QOTT4t21hdX8QtUBn56wLNVsdDDIL NtbOSskR/PKdtjQ9RxrlFty5kGN2d++k+f2XDYmRrnDUCo8QJ4WEXRZTzPiIDOlURiB8 YPa8kvuiKhInfpRlhdU56cNikZutBkaoXdZP7pGe/uaXpY1EaA+V5tJG3IpnYu/wi0dH zfn760pGabhWLeOdjIJcqGnHJ5RJNva5k3YvQ4PyijQH2qLa9c7QSKqRzvga9BE+2l/7 EvJBlcPtvXHBiZ7xI3wm369Z2tj4S86w2jRW66Le10XhBiDSgD7bAWJuiEolIDq6/oyr l7cA== X-Forwarded-Encrypted: i=1; AJvYcCWTkTIBQSZK4sdve08f7jdBNkSxfyVlabXlIo9/fH/a65tPh8QJ4j9kPCfcqfi1uloyHMbvvTET4U4SXeCjuLnXyk29hwvGoV0TYE+g X-Gm-Message-State: AOJu0YyOZJavGrzy1PHJ5hK6/DXEFTn15auBxdbAnRZcFcd/L+FYfeB2 /Zd5C9Zan4MIcU5qglPWfQJrY4V9f6qZrwil1lHhuBJFLGEcwQMAyB6KKLyQrrFAeHISmuob3ry r2IyGnRPusYv4Ts5rLSGhmg== X-Google-Smtp-Source: AGHT+IHG+Q0Rs/vnujOAAu0Ep0Ci2zjwBo/RrccQVLVpOf2JlGdWJkUk21aGZnHKjC8iP2W+VnN97KkaXY/g7E7Z7w== X-Received: from ctop-sg.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:1223]) (user=ackerleytng job=sendgmr) by 2002:a05:690c:d8f:b0:611:9268:b63a with SMTP id da15-20020a05690c0d8f00b006119268b63amr350712ywb.9.1711593220342; Wed, 27 Mar 2024 19:33:40 -0700 (PDT) Date: Thu, 28 Mar 2024 02:33:36 +0000 In-Reply-To: <20240314232637.2538648-13-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240314232637.2538648-1-seanjc@google.com> <20240314232637.2538648-13-seanjc@google.com> Message-ID: Subject: Re: [PATCH 12/18] KVM: selftests: Allocate x86's GDT during VM creation From: Ackerley Tng To: Sean Christopherson , Marc Zyngier , Oliver Upton , Paolo Bonzini , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sean Christopherson writes: > Allocate the GDT during creation of non-barebones VMs instead of waiting > until the first vCPU is created, as the whole point of non-barebones VMs > is to be able to run vCPUs, i.e. the GDT is going to get allocated no > matter what. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/lib/x86_64/processor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c > index f4046029f168..8547833ffa26 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c > @@ -518,9 +518,6 @@ vm_paddr_t addr_arch_gva2gpa(struct kvm_vm *vm, vm_vaddr_t gva) > > static void kvm_setup_gdt(struct kvm_vm *vm, struct kvm_dtable *dt) > { > - if (!vm->arch.gdt) > - vm->arch.gdt = __vm_vaddr_alloc_page(vm, MEM_REGION_DATA); > - > dt->base = vm->arch.gdt; > dt->limit = getpagesize() - 1; > } > @@ -644,6 +641,7 @@ static void vm_init_descriptor_tables(struct kvm_vm *vm) > extern void *idt_handlers; > int i; > > + vm->arch.gdt = __vm_vaddr_alloc_page(vm, MEM_REGION_DATA); > vm->arch.idt = __vm_vaddr_alloc_page(vm, MEM_REGION_DATA); > vm->handlers = __vm_vaddr_alloc_page(vm, MEM_REGION_DATA); > /* Handlers have the same address in both address spaces.*/ > -- > 2.44.0.291.gc1ea87d7ee-goog Reviewed-by: Ackerley Tng