From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2B6230BD9 for ; Mon, 6 Jul 2026 17:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360038; cv=none; b=l9JDjCOT0vB8sXwtxIQAiK/ip4VnpP5tcsvdJjuu0+clrUDR4wJ0VDppc4qtnvLHJOsghcB7lHYp9lj/37IDgDEKHqkAWcJv1W3Biemm7GwCw+cvdo3HY/wVJfh1sUGxHk1PRQ3ur3caGLyNmGiK3HC2idG0+c9A+heYtFhWrhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360038; c=relaxed/simple; bh=5bOmYD47KumyTOb+Y1qYhZXDQ6MEozeWdEp60mgsnpE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hUmJlDzKx73ZGvtZs9rMpZqUWXfPpSIwcKb5GF78S5A9Nuc+976+OzZd9Hg7mhIf9P+wLuRAxqvmrAaxpGanHabq1ggeGB08aiN/TaZk2+hA3ZT76f+InlmvZ9FecL5Vp6dTg1ETsv9rfc3X/z1CfHdKnUR97rbRMLQrXWn+vLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PhfPQC3/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NyMjbkY0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PhfPQC3/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NyMjbkY0" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666FF37k981458 for ; Mon, 6 Jul 2026 17:47:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=apmFEM59O0B61gJ5WxH6Ae7z ChxrAAcQn15+cvRZUhw=; b=PhfPQC3/q9NiNTgCQvS1BiHAdQ8HBNaOXp5VPl1Z J82gW6T2BnNDO2cMfYvSJci955vGMEiY4Tt3NbL4hgjlIc5kPcQioYOl/tz0Hsh+ pvqvsxTv0pOCaEDc+vwhEGcHvt0U8lJ1LG7dMM0V2PvUy8woIG+EpNrMDCZZydcd WuuHNvvUNI1KvaWm7zQj6ztz2DIbXPjaF1PZHMOa3dintSRMwMoUJFJHUEsrFNJx y3ARG47UrJ2rghFb+DOydUsWspQzZlwSbfFnhx34+qIY0deFjjiE6Wu9bx7i0lqM jCz17NaUvpezMIKQA20EoHD0cweURIhUDNoyXqgmReBvGA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgtb57-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 17:47:16 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-915d3261c5cso290957085a.3 for ; Mon, 06 Jul 2026 10:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783360036; x=1783964836; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=apmFEM59O0B61gJ5WxH6Ae7zChxrAAcQn15+cvRZUhw=; b=NyMjbkY0FapE+sQkOAkx6As1D7z4KerhqY7GM9Qy63Ytpoip9EIKz9yF+rHCPIeP9T HUCXqw21tf7qmz5okYfV+11z69umw70WAXDpBTR7/j9QV8OBW6WPfAhWLxNpmoQcIHu6 pnrhHgg+l4SSt3AhaXchuJGVC4zh6EUBBNB+mlGsc+TeWFzfl6IN7MNcuZ2IRoP8jwAZ oy6ujKJxLl2XnV2ZkGMDy4jsYkZLSuLEc+CjSBaTek1RHrfa2hqrzYuBcSq4qz66asre C5AsBCPmuU6T4sCUmlppq3ErFxbNhkMm0r8XGyoC2t7E6baMzYk5qSzrQTW8AdIf2AFw 9Few== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783360036; x=1783964836; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=apmFEM59O0B61gJ5WxH6Ae7zChxrAAcQn15+cvRZUhw=; b=eF4ufyoOvpvpjp2S1k1GuRS/VQLTspqu+8QhcHRfweHfOhan3gYy1MKvizSSSZq7SU 0B1KWE3H0k4VYIBiXpE16yVYMs6KNi/aJpREr7dDur9H/r0XECjkDwgobb205xGRgLSU 1N2XvlujyS0e9zQ3D64LoDIcSALXiPMVS2eWBQsC3NNKvC06YL9zEIed8B46aSBF7VcX izWeUFafxnZEwlHJfFLRqwFeWmlrCqlyOQ1RwjOl5NJnwNVG3q/xLWC2uj6wBe1gCSL/ HoIAMLO9AK9S2XsWR+Lqn734nTYFw/gvms3o5lxH0USgeqT+tmIUFYWMRPKZ1v1RvWX1 ErBg== X-Forwarded-Encrypted: i=1; AHgh+RpTIEphA2/uUzSadl40SYGwvQI6gqnvHH8ic+QJozFlrfalc49j9Z7jvYxmuMw6WUdsHHQNVnknaxcDsto=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/0udyw9tyycPyddwtmzo8hhfaKYANcqMiNf+6htXgybKdx3c6 HdaK7ZOX9pP4mdIOtxcbMr1G6O1SekPXVr69qD4oy4FpU6o5R5TFYGGqx+HiE7PFacVpJYM705j lHetrD1eqLA3A+8Ci2QtIiVqCyPRYHz+ZfpnXaDGxZwkyuf7TCjRrjhZtdzNazPwzE9U= X-Gm-Gg: AfdE7cmF1oQxkK8FlDQCLnzdLY3ADaVk07xIKi2mDrv658tQu2KgL3bWa4QvVlvnz0I dgBpnU92JBHmdN6sYOFoYjQeiYbjjUzXrd4QsVLG/Jt18wfwm4lsIYac+UplQj4pxsLrqUPm+I8 3uAA0HlMeU2iZG29XTLacx+nMp3b7swb/RnDjs3c9gmXNa2hbzH+lctRfPHHotSMGbwKQIa1zFC IwYetJvihoSsI7kfGPnniq+BE51XZgaLB0+unhOMwgi1LqcSpnbZ9Dq+5XjZLxvCXTbhbuVL9OJ ogQNI+KBKJZtqygoOETLaN/Fc7RP6q7rk47clTBSnwW7hfB/SK2GTCdIprZNX+rlGuKwG7WjA9l GiXj/Ic75DXMFg8oXnHeE/cJZI/SF5WUUMGJaShFZtQ2LmhhNqrX/Z9ly7o/0AtlUQ+8jNUPsm6 8XbcxMfR5NvSMHW6p+jKraIc6b X-Received: by 2002:a05:620a:4412:b0:915:b852:4361 with SMTP id af79cd13be357-92ebb4d57d6mr203279785a.20.1783360035670; Mon, 06 Jul 2026 10:47:15 -0700 (PDT) X-Received: by 2002:a05:620a:4412:b0:915:b852:4361 with SMTP id af79cd13be357-92ebb4d57d6mr203274985a.20.1783360035123; Mon, 06 Jul 2026 10:47:15 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b4ae5c8ecsm19731901fa.35.2026.07.06.10.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 10:47:13 -0700 (PDT) Date: Mon, 6 Jul 2026 20:47:10 +0300 From: Dmitry Baryshkov To: Daniel Lezcano Cc: Gaurav Kohli , Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants Message-ID: References: <20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com> <20260703-qmi-tmd-v4-1-3882189c1f83@oss.qualcomm.com> <977711ef-c1fb-4735-b82a-4ca2f4797f51@oss.qualcomm.com> <8ad14017-bce7-485e-9677-9cbf8ecb2742@oss.qualcomm.com> <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> X-Proofpoint-GUID: 5hso54T8ZcoVmI56mMDLoPNsupsCwvCa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE3OSBTYWx0ZWRfX8H4UPcLL972T nHVWIb67cbucHmqv+a0f8URgJPy3HTVixnW6agnoOXM09tRcR0+GqtU7pDHt4QTBC7t+mG5lkdS cGY7kmb9HUuO/X7C/zbEkQIJeJ4H6JVQdBJgYz2gEWTuXod5AVOeQEoGGaZPdO9AMD0NKoLfI9v WgkJTDd6UggLpuHTW0LR29yqztg8Q0BaxbUejr4XHp/zimszkl3uyIP9B/uqJY9k7YFez4szx8/ MMsRtzNXzi42k5SnVdComdVs5i+vCNYieNQ2Up03R75n5IKZ//0t4izE5XAt3nWZpy2GFMPBDq0 rBYf60LhmseyoFJjE5saKWkUIq+jVFTtB1PR4i0UHsR1ytgGYhVqf9+2BGKZZ6WtsQtQIkub2E1 5SPTMsBOdaU4z5kCsZSZynMUaszGHK8lpRiU/LBDDcyTbsaaTBauqNAkfW+toQXsRqfs/a7GCIt lgD+rMMDDYJpnOjzNjw== X-Proofpoint-ORIG-GUID: 5hso54T8ZcoVmI56mMDLoPNsupsCwvCa X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE3OSBTYWx0ZWRfX3smLgsQ/R4Bk L3woNvzIX8kd0paIUoJ7F0DzNf0j5M6y3Vln8sQ68noUKWGAInI68dzxtE/4tqVKTXBFoMa3cAC ykw83VUvX8esEUSQO+bKX5sNAcCZKQY= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bea24 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=2pRoOLr91VfmbNnP4VsA:9 a=CjuIK1q_8ugA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060179 On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: > On 7/3/26 17:42, Dmitry Baryshkov wrote: > > On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: > > > > > > > > > On 7/3/2026 1:23 PM, Konrad Dybcio wrote: > > > > On 7/3/26 7:03 AM, Gaurav Kohli wrote: > > > > > Add Device Tree binding constants for Qualcomm Thermal Mitigation > > > > > Device (TMD) types used by remoteproc-backed thermal cooling devices. > > > > > > > > > > Qualcomm remote processors expose thermal mitigation endpoints > > > > > through QMI. These endpoints can be registered with the thermal > > > > > framework via the `#cooling-cells` property on the remoteproc node. > > > > > > > > > > The QMI TMD protocol identifies devices using string names (for example, > > > > > "pa", "modem", and "cdsp_sw"), while the DT cooling-device binding with > > > > > `#cooling-cells = <3>` requires numeric device id in the form: > > > > > > > > > > <&phandle device_id min_state max_state> > > > > > > > > > > Define common TMD device index constants shared across currently > > > > > supported platforms. If a future target requires a different mapping, > > > > > additional target-specific constants can be introduced while preserving > > > > > existing DT ABI. > > > > > > > > > > Signed-off-by: Gaurav Kohli > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > include/dt-bindings/firmware/qcom,qmi-tmd.h | 20 ++++++++++++++++++++ > > > > > 2 files changed, 21 insertions(+) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 57656ec0e9d5..ffd85fd1dd80 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -3410,6 +3410,7 @@ F: drivers/firmware/qcom/ > > > > > F: drivers/soc/qcom/ > > > > > F: drivers/watchdog/gunyah_wdt.c > > > > > F: include/dt-bindings/arm/qcom,ids.h > > > > > +F: include/dt-bindings/firmware/qcom,qmi-tmd.h > > > > > F: include/dt-bindings/firmware/qcom,scm.h > > > > > F: include/dt-bindings/soc/qcom* > > > > > F: include/linux/firmware/qcom > > > > > diff --git a/include/dt-bindings/firmware/qcom,qmi-tmd.h b/include/dt-bindings/firmware/qcom,qmi-tmd.h > > > > > new file mode 100644 > > > > > index 000000000000..73efecef0f3c > > > > > --- /dev/null > > > > > +++ b/include/dt-bindings/firmware/qcom,qmi-tmd.h > > > > > @@ -0,0 +1,20 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > > > > > +/* > > > > > + * Qualcomm QMI TMD (Thermal Mitigation Device) cooling device indices > > > > > + * > > > > > + * These indices are used in device tree cooling-maps to reference > > > > > + * specific TMD devices provided by remote processors via QMI. > > > > > + * > > > > > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > > > > > + */ > > > > > +#ifndef _DT_BINDINGS_FIRMWARE_QCOM_QMI_TMD_H > > > > > +#define _DT_BINDINGS_FIRMWARE_QCOM_QMI_TMD_H > > > > > + > > > > > +/* CDSP thermal mitigation device id */ > > > > > +#define QCOM_CDSP_TMD_CDSP_SW 0 > > > > > + > > > > > +/* Modem thermal mitigation device id */ > > > > > +#define QCOM_MODEM_TMD_PA 0 > > > > > +#define QCOM_MODEM_TMD_MODEM 1 > > > > > > > > What about the dozens other ones that Dmitry's laptop reports?Ri > > > > > > > > > > Thanks for the review, Konrad. > > > > > > We are only defining constants for the TMD devices that are actually used > > > for thermal mitigation on the platforms supported by this series. > > > > Why are you using only those TMD devices? > > > > > More constants can be added as needed. > > > > Kodiak is one of the supported platforms. > > What would be the benefit of having more than thirteen cooling devices > declared in the thermal framework and having only a couple of them mapped in > a thermal zone ? > > I agree there are more TMDs but if they are unused for the moment, why do we > need to add them ? Can we do that incrementally ? That's what I am trying to understand: why the implementation uses only the selected two devices, if the modem on Kodiak supports others. How can we find out, which TMDs to use on other devices. -- With best wishes Dmitry