From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEC5C432C1 for ; Tue, 24 Sep 2019 22:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A015214DA for ; Tue, 24 Sep 2019 22:24:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bC4zjM/q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442027AbfIXWYI (ORCPT ); Tue, 24 Sep 2019 18:24:08 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55694 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410649AbfIXWYH (ORCPT ); Tue, 24 Sep 2019 18:24:07 -0400 Received: by mail-wm1-f65.google.com with SMTP id a6so2110786wma.5 for ; Tue, 24 Sep 2019 15:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xfRFVkwkZkzLU7wLRDGsHMd8P8PHN/2mWFJxcO4s7yQ=; b=bC4zjM/qQley88yoN1EN4Khq52YC1EVZnPVnorS8QVonyQije6SNxXsss+W1BCmGm9 QW8mDw4yWhAVxFZkbCH+fGd1m2Sv8k5TBQC277KT/58VgiPO3scryeuWGQ7YPbkQ4lFk 1PlP+6vLAbi2aDsCK51nH+idhJcdxrYGYdjIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xfRFVkwkZkzLU7wLRDGsHMd8P8PHN/2mWFJxcO4s7yQ=; b=A5MO6wrUZZJ1wjp1jnua3ylGlGNEYevpd2pEpeNC2Ctynr34O/VfN+lXDwnTJOZG4w DXR2yN2+cCHFAtVVuFkuCUbZpE/aNnLbyxhodTZL2ajP6gXGvSQacuetPUQ872/Agn3i /v9kJtQPF/WzjBpoGxAjH5+43rs7cqhmD3up9YKhGtxj+ogCRyov6sd70tKf6lksRG9+ 1rwjuXDQSANJyqabcj//lMvfm0M+LxyW7c8LEXj5IoJkdr79VAaFKbN0gqcatjVxTWAa SN8ZvcuTdFNSh8i5ZP11P8OvyzJZFO2AZff+I9cQhDWouTh+8oAMeR/FigflvsiW3EgV 2InQ== X-Gm-Message-State: APjAAAVHsVF6cu7X/SuczCADJAOSrBw0jRuegNGOY18cStDTq0bLymn0 TwgnEtCkX/hvhSESbyPicsuwuQ== X-Google-Smtp-Source: APXvYqygBR89fKBdCAQmPjpAqiV1ouU4IH0prxfGmTO/KT1bW4/bbP1SDFUrQEK1nfCjt9ckb/vW8g== X-Received: by 2002:a1c:7509:: with SMTP id o9mr2944752wmc.21.1569363843889; Tue, 24 Sep 2019 15:24:03 -0700 (PDT) Received: from rj-aorus.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id 94sm1749646wrk.92.2019.09.24.15.23.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 15:24:02 -0700 (PDT) Subject: Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability To: Wolfram Sang Cc: Rayagonda Kokatanur , Rob Herring , Mark Rutland , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Lori Hikichi , Icarus Chau , Shivaraj Shetty References: <1565150941-27297-1-git-send-email-rayagonda.kokatanur@broadcom.com> <20190830125626.GC2870@ninjato> <3e70fa7e-de13-4edd-2e17-b7c56e91d220@broadcom.com> <20190831094940.GA1138@kunai> <540c4e2d-0dd5-5260-30b2-e1589b279d71@broadcom.com> <20190904213745.GG23608@ninjato> <5ab79d0e-eb54-8fe1-1ca3-e763a17c6426@broadcom.com> <20190924185757.GA1538@kunai> From: Ray Jui Message-ID: Date: Tue, 24 Sep 2019 15:23:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924185757.GA1538@kunai> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/24/19 11:57 AM, Wolfram Sang wrote: > >> In my opinion, it's probably better to continue to support master_xfer in >> our driver (with obvious limitations), in order to allow i2ctransfer (or any >> apps that use I2C RDWR) to continue to work. >> >> What do you think? > > Yes, don't break it for users. We should have paid more attention to it > in the beginning. But, while not ideal, it is not such a big deal to > keep it like this. > > Thanks for your investigations! > Thanks, Wolfram. Let's please continue with the review process on the current patch then? Note the patch was already internally reviewed by me. Please help to review it and let us know if there's any change that needs to be made? Regards, Ray