From: Lars-Peter Clausen <lars@metafoo.de>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
peter.ujfalusi@ti.com, broonie@kernel.org, linux-imx@nxp.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Cc: Xiubo.Lee@gmail.com, linux-kernel@vger.kernel.org,
shengjiu.wang@nxp.com, tiwai@suse.com,
ranjani.sridharan@linux.intel.com,
liam.r.girdwood@linux.intel.com,
Daniel Baluta <daniel.baluta@nxp.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v2 2/2] ASoC: fsl: Add generic CPU DAI driver
Date: Mon, 16 Mar 2020 16:10:47 +0100 [thread overview]
Message-ID: <e00e3fe1-7e87-e9c5-7c53-50ac6fa991e7@metafoo.de> (raw)
In-Reply-To: <20200306111353.12906-3-daniel.baluta@oss.nxp.com>
On 3/6/20 12:13 PM, Daniel Baluta wrote:
> +static int fsl_dai_probe(struct platform_device *pdev)
> +{
> [...]
> + ret = of_property_read_u32(np, "fsl,dai-index", &dai_index);
> + if (ret) {
> + dev_err(&pdev->dev, "dai-index missing or invalid\n");
> + return ret;
> + }
Maybe this can follow a more standard approach using DT aliases. Just
like we assign IDs to things like SPI or I2C masters.
> +
> + fsl_dai.name = dai_name;
This breaks as soon as there is more than one DAI in the system since
you are sharing a global struct between them.
[...]
prev parent reply other threads:[~2020-03-16 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 11:13 [PATCH v2 0/2] Add generic FSL " Daniel Baluta
2020-03-06 11:13 ` [PATCH v2 1/2] dt-bindings: sound: Add FSL CPU DAI bindings Daniel Baluta
2020-03-12 20:23 ` Rob Herring
2020-03-16 13:01 ` Daniel Baluta
2020-03-18 23:50 ` Rob Herring
2020-03-06 11:13 ` [PATCH v2 2/2] ASoC: fsl: Add generic CPU DAI driver Daniel Baluta
2020-03-16 15:10 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e00e3fe1-7e87-e9c5-7c53-50ac6fa991e7@metafoo.de \
--to=lars@metafoo.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=daniel.baluta@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®