From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DFDC46CC6 for ; Sat, 9 Dec 2023 01:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574923AbjLIBkN (ORCPT ); Fri, 8 Dec 2023 20:40:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbjLIBkM (ORCPT ); Fri, 8 Dec 2023 20:40:12 -0500 X-Greylist: delayed 555 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 08 Dec 2023 17:40:16 PST Received: from mail-m6039.netease.com (mail-m6039.netease.com [210.79.60.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0A4810FA; Fri, 8 Dec 2023 17:40:16 -0800 (PST) DKIM-Signature: a=rsa-sha256; b=U1A4+o27k8BpDm6vFDm5SLrPKgl34qoVXMOQvOQXRouyshE2USxFMrKUjLBvZqvahaN1PDUCU9HgM8uXSy5TDh1x+LvZ8qX0ywxXkpfTKNVHxQ+uRjDBsoVLKkvr0UTUWJ/zfKU6kxJF2fJr5Yq6Q7h8DxbwtRVqxybgTYz2VTM=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=3ZfnCGij/I8m1TiIlexdEuiMXvToZHxbD5kG64olyL0=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m12779.qiye.163.com (Hmail) with ESMTPA id E461F78018D; Sat, 9 Dec 2023 09:30:30 +0800 (CST) Message-ID: Date: Sat, 9 Dec 2023 09:30:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/17] dt-bindings: display: vop2: Add rk3588 support Content-Language: en-US To: Krzysztof Kozlowski , Andy Yan , heiko@sntech.de Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com References: <20231207075906.651771-1-andyshrk@163.com> <20231207080133.652417-1-andyshrk@163.com> <0915b94c-596e-4a19-925c-1a5b1d0a3531@linaro.org> From: Andy Yan In-Reply-To: <0915b94c-596e-4a19-925c-1a5b1d0a3531@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkhPHlYZHh9JQhoZTElMHk9VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk1PSU5JVUpLS1VKQl kG X-HM-Tid: 0a8c4c328fdbb24fkuuue461f78018d X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Kz46USo5Hjw1Gk46LB4pSwoO DkJPCx1VSlVKTEtJS0NOT0hKQ0lIVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBSE1DSDcG Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Krzysztof: On 12/9/23 01:46, Krzysztof Kozlowski wrote: > On 07/12/2023 09:01, Andy Yan wrote: >> From: Andy Yan >> >> The vop2 on rk3588 is similar to which on rk356x >> but with 4 video ports and need to reference >> more grf modules. >> >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v4: >> - drop redundant description. >> - use full stop at all the description's end. >> - address Krzysztof's review in v3 > > What changed? Please list specific changes, not just generic "address > review". > Sorry, I will keep this in mind in the future. >> >> Changes in v3: >> - constrain properties in allOf:if:then >> - some description updates >> > > Reviewed-by: Krzysztof Kozlowski > > --- > > This is an automated instruction, just in case, because many review tags > are being ignored. If you know the process, you can skip it (please do > not feel offended by me posting it here - no bad intentions intended). > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > Best regards, > Krzysztof > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip