From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832D8C74A5B for ; Wed, 29 Mar 2023 07:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbjC2HSt (ORCPT ); Wed, 29 Mar 2023 03:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjC2HSq (ORCPT ); Wed, 29 Mar 2023 03:18:46 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C1B130D5 for ; Wed, 29 Mar 2023 00:18:31 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id d17so14570065wrb.11 for ; Wed, 29 Mar 2023 00:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680074310; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eajfSt8w9ufgtddPRPPD3ycsjjI6dYwIY70vn8OhuP8=; b=JSFX3SUpSO5Pnvj3Bqsee5QeVRvC2/QwIyuCX8YXzGW5i6X0bCAvZLf1SupVEtz9UN gWwlHf96GuuINcA1o7sN3ygP5HYuSo3uU0xg3t2cl3SYta1zrA83TbWB0hvtj5rRA9Sc HV0juj5v3ecuAP/ce0rn4BjDpEVsBrLy1rMJqs8Cfy9vz8lAouIOy71e1tvEvb5a4ffr tTrJzYV969vDjgvXcW8u0u8g863K1CSaP8NmoqUbU3UZi21B+uTtoOR8MMVjlMEkaLGV tjpGeEu8vDUCA8qPVH1YKFk3tYIcTKnUbvoCO34usOfWxaFUV8fnmnDk3hvC+7EoS6xe 6Obw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680074310; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eajfSt8w9ufgtddPRPPD3ycsjjI6dYwIY70vn8OhuP8=; b=nmzD6mK3UpClQSQHLpsuJ7Q2t+2+zv4cErOPAxu7vWGhucH12NwXOFJG1pfK7Rjb7s PqVpqEN52JQxhzjh3lvPcX5HnWguMzQrz8+dMtLZai1x1nvztFDEn9z/PPXxxKz9shrO awS8LhLm6GTWwYk7CRI0QMJrMNgUF8xJ/kKVtrU4RKtkIQMeZMVcHH6tlxrRzHaLDI5Z jfytyZPQTpZsLSgObtzVxTQlU+QQ26S8/H6t2yIMfG+mJiEb6bZ08ItopL/7M7CUUC2o bUmRMJzAzSKiQ5WgodAFTTrsyl/T8Wr9lk4m7xnpQyAOFcOD7RcyoHvV85w4jL1Q89iF OzuA== X-Gm-Message-State: AAQBX9c9rBVKIGoi4TqQM5b06XZSC0eBkvT1OYkuL+pjNUK5FDYBTV8x U1l7Zj7IBTf0W4h7USqXQLwzxQ== X-Google-Smtp-Source: AKy350bo70toYQ1jB282XzP5A8Q0DmRgF0RkhKapiG7TXsz1y7SEzDi3UbCgIf7qeNPJVgxKvgJFNg== X-Received: by 2002:adf:ce01:0:b0:2e2:730a:c7de with SMTP id p1-20020adfce01000000b002e2730ac7demr3550893wrn.24.1680074310088; Wed, 29 Mar 2023 00:18:30 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.91]) by smtp.gmail.com with ESMTPSA id n12-20020a5d484c000000b002c59f18674asm29503250wrs.22.2023.03.29.00.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 00:18:29 -0700 (PDT) Message-ID: Date: Wed, 29 Mar 2023 08:18:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH -next] spi: rockchip-sfc: Use devm_platform_get_and_ioremap_resource() Content-Language: en-US To: "Yang.Lee" , broonie Cc: heiko , linux-spi , linux-arm-kernel , linux-rockchip , linux-kernel References: <20230328062118.86336-1-yang.lee@linux.alibaba.com> <48f1ee32-a030-8188-3a9d-612888b9678f@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/23 07:06, Yang.Lee wrote: > > From:Tudor Ambarus > Send Time:2023年3月28日(星期二) 23:16 >> If I were you I would make a single patch addressing all the drivers >> from SPI as this is a single logical change. You get extra points as you >> avoid polluting the log. > > First of all, thank you for pointing out this. > Because the maintainer list of each SPI driver file is not identical, I am worried about causing trouble for too many people, so I split it into multiple patches based on this. The change is trivial enough to don't bother at all. Here's an example: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4b23603a251d24022f2fa48ee67610eb245a4115 > >> No, you better use devm_platform_ioremap_resource() as res is not used >> afterwards. You'll get rid of the local variable too. > > It's my bad, I will send a new version. > > Regards, > Yang Li >