From: Bart Van Assche <bvanassche@acm.org>
To: Satya Tangirala <satyat@google.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 0/8] ensure bios aren't split in middle of crypto data unit
Date: Thu, 25 Mar 2021 14:51:31 -0700 [thread overview]
Message-ID: <e0248d93-e880-6a6d-92d6-dfcfb6f9d661@acm.org> (raw)
In-Reply-To: <20210325212609.492188-1-satyat@google.com>
On 3/25/21 2:26 PM, Satya Tangirala wrote:
> When a bio has an encryption context, its size must be aligned to its
> crypto data unit size. A bio must not be split in the middle of a data
> unit. Currently, bios are split at logical block boundaries [...]
Hi Satya,
Are you sure that the block layer core splits bios at logical block
boundaries? Commit 9cc5169cd478 ("block: Improve physical block
alignment of split bios") should have changed the behavior from
splitting at logical block boundaries into splitting at physical block
boundaries. Without having looked at this patch series, can the same
effect be achieved by reporting the crypto data unit size as the
physical block size?
Thanks,
Bart.
next prev parent reply other threads:[~2021-03-25 21:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 21:26 Satya Tangirala
2021-03-25 21:26 ` [PATCH v2 1/8] block: introduce blk_ksm_is_empty() Satya Tangirala
2021-03-30 18:04 ` Christoph Hellwig
2021-04-15 19:21 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 2/8] dm,mmc,ufshcd: handle error from blk_ksm_register() Satya Tangirala
2021-04-15 19:27 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 3/8] block: blk-crypto: introduce blk_crypto_bio_sectors_alignment() Satya Tangirala
2021-04-15 19:33 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 4/8] block: introduce bio_required_sector_alignment() Satya Tangirala
2021-03-30 18:06 ` Christoph Hellwig
2021-04-15 19:37 ` Eric Biggers
2021-04-15 19:44 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 5/8] block: respect bio_required_sector_alignment() in blk-crypto-fallback Satya Tangirala
2021-04-15 19:45 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 6/8] block: keyslot-manager: introduce blk_ksm_restrict_dus_to_queue_limits() Satya Tangirala
2021-03-26 3:50 ` kernel test robot
2021-03-26 6:28 ` kernel test robot
2021-04-15 19:55 ` Eric Biggers
2021-03-25 21:26 ` [PATCH v2 7/8] blk-merge: Ensure bios aren't split in middle of a crypto data unit Satya Tangirala
2021-03-25 21:26 ` [PATCH v2 8/8] block: add WARN() in bio_split() for sector alignment Satya Tangirala
2021-03-26 3:47 ` Bart Van Assche
2021-04-15 20:00 ` Eric Biggers
2021-03-25 21:51 ` Bart Van Assche [this message]
2021-03-26 1:39 ` [PATCH v2 0/8] ensure bios aren't split in middle of crypto data unit Satya Tangirala
2021-03-26 3:46 ` Bart Van Assche
2021-03-26 7:56 ` Satya Tangirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0248d93-e880-6a6d-92d6-dfcfb6f9d661@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=ebiggers@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®