From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012027.outbound.protection.outlook.com [52.101.66.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74EDF3E8C5A; Tue, 31 Mar 2026 15:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.27 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969831; cv=fail; b=gD8k00pnMIjjrW7/wyfSiao+0DyF5h9Airnp0cisD/lmsF3txLTyYIY2WTaM2cHYWjdaOTzwLWUsET519kNOcSZEU/iWsSJI3MJQLdVf8oB4FirX3Q1B+tnOlaXU/o4WLNvGo69P2buklYDY1984wjm60tRA7SiI3s/ephrcyeA= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969831; c=relaxed/simple; bh=hBd1CZDEvX5peadk9L2nypeqZGv/cEqC03r18doO4vU=; h=Message-ID:Date:Cc:Subject:To:References:From:In-Reply-To: Content-Type:MIME-Version; b=KKQ2XM66HMKggZVyVnhmNEoH2P+7x6xHlNiROLcU9fkthjeTxs2TBAbTxWxUWrZx9eM7Dr+sqYv9hyr95GB5IPygn6A+AcuY00pypJMOrHmq/FDrFeCZLCzQ76BaPwTmOJmg2Fb8C6pLSVkY83wEXhVWC0/1q/J+9p3c2U+w6ec= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=VOeNwbe4; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=VOeNwbe4; arc=fail smtp.client-ip=52.101.66.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="VOeNwbe4"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="VOeNwbe4" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ubry0BpyLqIJKDc/oGLxaSBYK9IxdqTnH8coppNVF731TkfzHs3mcYdAjOur54t6vyhDzZNl+FkfkBczEEKSf3uRbpJw78TjFti1wb1S4ehlrB4W/wwNH15hg4Wy4REQ3npRBxKedclQhQfvEQrDN+O2cCKdP5vdlh6DarTfwNebaNasHv32dmrMntKkupPppuqxFVgOxeAxk52fELYMKr5SUkCKhGJ/Y5xohqGeK8tKJ0i+hNFRj0gypRC0ZjCI8nTOs7cIItzXwKg/a4KCgirW2vwv6X8S3f8EeWqEv7FGE9NqBsE6oyuZog+p4JH28eBUr/bxbTk4YiGuhqX0Xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0SerzFjBC9DhwxwhWrJeyY/JNvdW9RS+zY438Xc1Af8=; b=C12oVUZPaHiDpT/6sMTJvbry1v9johXRKNDZ93ynmpbPdW1UCkST+G24lboc2SBvPg1n2rvw0dT+x5Ca7wN9Cbk85YHs9lNdRulF3+Stbqhth4OOandl4TnChxkntEjhovz65Svj0loXPLUOILw+wj+R3fSe/YI65e6LwiFf3muKsPYy4LdKbdS6iVvfJ1hS1YEN/bh/qDxREIckClJN+fXXiHFKiwpA00W8xDzj3H461uA+0df1rTz5blA3xA34o7JoR6jAj+841ycWk78rGWFtX+jpDi6n7iSBOxutFWjdXmArcltV8fmFbWkxgLJznpcEOqTpeuqtvPtAap9IsQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SerzFjBC9DhwxwhWrJeyY/JNvdW9RS+zY438Xc1Af8=; b=VOeNwbe4iABiANf+jxMCMmbZdu40PrzC2G7dDibQTzVY1QiTPOW1ontOQqGb4lnQHgtaE9iyAPw/f61NVha9J9fIgmk1FU65BazTZk8hrnJvXuJhpEJkzXAm+qJ49dI/tsBxtKfGLcbPgwsSkAKOxlG1Qb2s8Lb1fjKVGdaRYkc= Received: from CWLP123CA0041.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:58::29) by DU2PR08MB9964.eurprd08.prod.outlook.com (2603:10a6:10:499::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.15; Tue, 31 Mar 2026 15:10:24 +0000 Received: from AM2PEPF0001C717.eurprd05.prod.outlook.com (2603:10a6:401:58:cafe::7) by CWLP123CA0041.outlook.office365.com (2603:10a6:401:58::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.28 via Frontend Transport; Tue, 31 Mar 2026 15:10:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM2PEPF0001C717.mail.protection.outlook.com (10.167.16.187) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Tue, 31 Mar 2026 15:10:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xOH/20mezBgbnbUWnhoKjPMFYwl+XbP1wyf4qobAtCrylkZgxcL3z3SsMlfkdcNK787WPy4idN3XZFPIBpQip7M8RJAYkaV1LC1jFTHvORhgPe+tuIoWi3h6DYqcc/Vc6MWkABeif024fIWtWCYGjRoZOt7qdzUeuCTzjVxUUby2fwg8hdXKGwZxDrCDIcQw+h7OSREGHU4s+D8tgrKFrYKaaff2T2QK4Bf0B32w3nun3eFYbVsR1SwY9Yyfj/3kU7rE84KR6jQvOFJuIDZYkjInssNyEmXJxtBJ0lJZtjoSWL4bCWJTqV73LDUEP8Tc/4MbKYGyhY9HLsYKDizSrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0SerzFjBC9DhwxwhWrJeyY/JNvdW9RS+zY438Xc1Af8=; b=bXfhVbQ1Z9wT7riyNJAjKkVc5fklWBSQcipIy00qWNWUqEvciQy3jWE0sWaXa2C9oGigXuAgwgrPKjnUd7Q6iNzRGrgIn7LZOcDsr/K7aEbWRl7ZRDbUTffLJIOlPLeNe8n97tNhi7qRaVl+ll+VQyf7GR09MChyUXYnAo3O3YG+yMYjWeKnQhQ0Mvz/w9IDRiIG9CLoECVfaAi0VrktE0RfXMvpwfpLTuKi0Hdpw1FmV8IhsJOW7wQmkm7qLvsYaOc/1Hh1mns0Ooa5FVH2WUGD510kKwHvCKSUvah4BgSMKKYMB+W5uF8qis78FltMek5GEvf+UMSl3pphBqHKMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SerzFjBC9DhwxwhWrJeyY/JNvdW9RS+zY438Xc1Af8=; b=VOeNwbe4iABiANf+jxMCMmbZdu40PrzC2G7dDibQTzVY1QiTPOW1ontOQqGb4lnQHgtaE9iyAPw/f61NVha9J9fIgmk1FU65BazTZk8hrnJvXuJhpEJkzXAm+qJ49dI/tsBxtKfGLcbPgwsSkAKOxlG1Qb2s8Lb1fjKVGdaRYkc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by GV1PR08MB10402.eurprd08.prod.outlook.com (2603:10a6:150:15d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Tue, 31 Mar 2026 15:09:20 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%4]) with mapi id 15.20.9745.019; Tue, 31 Mar 2026 15:09:20 +0000 Message-ID: Date: Tue, 31 Mar 2026 16:09:18 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com Subject: Re: [PATCH v4 2/3] vmalloc: Optimize vfree To: "Vlastimil Babka (SUSE)" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Uladzislau Rezki , Nick Terrell , David Sterba , Vishal Moola , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Ryan.Roberts@arm.com, david.hildenbrand@arm.com References: <20260327125720.2270651-1-usama.anjum@arm.com> <20260327125720.2270651-3-usama.anjum@arm.com> <0039fdb2-b23d-4ada-8d83-595e7816521a@kernel.org> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <0039fdb2-b23d-4ada-8d83-595e7816521a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0217.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:374::18) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|GV1PR08MB10402:EE_|AM2PEPF0001C717:EE_|DU2PR08MB9964:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e20b60c-460a-4fff-2f7f-08de8f37a292 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info-Original: 8H/8C/ddCICoEgId6xozFUh0Vj3L4JkEvXSI1SdQjkX5aRJB3QjF0bLLbjKHCDUb8fIuXdcl6NlxkwxbygayvoXn6ZHMiiNB+SytNqsfTrIxzvNYaY5pO/BBX9+DsWJxdmEOd0fCghTQXFen+veXOevAXSkYJOl1FHPEfUmfnkoEN0LUq3FaansLVWLi1vBTX4DEm8beeRJODFYLT29Yi1VMCrmTX3RJbaD30mNvVpeU5IQO1w407k7KWCJiwEaxqg5giCJMHoWDgFnMbHHHuuzkh/3qm1iWS+6wrmxxSlH/otRJE0OJwFaNK84rDZi3TLUv1MsudGY2HgJHXsFYkH+dUcEf4ymlyzzLy1N7ZqVNMPrraZ0OjskG/sWimjwtwyKm9zEyTtvF6Dd1nGa1cqMEgRU37NCuTpMnaQqYqIzSiTHalnXvsJi/O+QJrZ9nemg8Cm+/pq7c341shXLk0xFhUZW5ux06qY+JlXbyZWhiJy69v/Z4PYhS9UcCxwps4BhhLAhp3FfHbbL+fbuODXjP62j8y3ZTHqiVrx2FASnk2w/1jibl2lFIfVh4vHH7G/BXRTYuUJ6JRRAFNgZrZacwoSoghrqZtRZqOwJRiXuThhnz3lj5C1diCsmGW5+pyiE8iLPHRXquwNVCXbA74pZ6yIFk38+bkyAbQmFthGKUV4sgR3dP1A3oy+pcwWLQjFX/aqvkjG2ER2KQRsNcS8T9StjRCj3HDuDImhJe3QI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: QLMrZgrjBPvACwLil6wXXNCbvx65cFYHFRisWsr4Cugl7c3FkKpcMFO0u/JSYQsgsExaWdMrlqwaljCNtvYEvArKgiX4FO6oSCgoRKvdk9yf95PPojaQ1bHkNu2Vjj4wLFwijmVwNyxlv0dbmUdhEVuV/phHquJvy15gSoU+RYhfwLom+N77kMBPXv4w3I3BXvUY9+DMFgSlJB7z1DTW7rtVoya51q328WnosQkp+SyMWzig8U6qlgla0C8uzs1GQPEc008wcQ6lubi00eBcfWxqK0vr9ALeOUXZn42YmkMB5ViEWBjFXVTelLob1Vg/z/OnFbxFCnRDvX0WjpB6zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10402 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C717.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 28d14534-c752-4dd6-6981-08de8f377be9 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|14060799003|7416014|35042699022|82310400026|1800799024|18002099003|56012099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: PpEMhwwE0kD2Owpm5Ee9whrml9czJFDSA5uc+z8jFnPda0fkGBdvKfwannm9qMXISIuSp+YwROTjKLmc/LfCj2MoMJGnt76PVI9dq5aBIvp42tGO0ViHbevqrmPxX/Gt5BN6UMcrLWuF535czuRBCSFdX0tDa5Gj/hGMhG+F14FbWBlsP1XwaDHkS8cOwoEznZ9bjmCiOcxRPF6s97dNskJ3M/HXKCyCr8+TpWx5a2sAnnKBp7fKxf/lYfpz2riW7i4uYRhPszYPfN5cVKKn9Q4B5eC12dkUwhgjG4rEfw12SilL+2eplsHlJv1eNKZdN9PRgcnm+HbHCuakwrreSl6/SPt/PGmMHiw6ZsG3i4d/p/lKB4ieZtRev7gLSm09aqRQqihnQ7MphdLm3LvuNa17c1CZwLIN+hwChDUf6yyEk3qO8vrJik+FDCcOrvV283Q4YYJFnH4bjMuCocwHIHVaZSQByQvro+By52EfVSs9EpV+Pf4RFGHEnChmrZj3GP9NCfWgtjLd5Ucuir4bWV7xPXyoocPy3CklRkno8pYpDR9psb4+JfcLgpgR5wrQdlaQEPliRJft6NAf2P78LVze56AAgXN92caZSswlZHqgBXHWQREWZA7Cmzlt6KXtab15wRWRaQtEKKkhXDLTJShjt/XSy1BmsMZmbn/wCfKnkWG1CtUzVoyaqeMOGmqBeH5a0b84XJHQ1Hr5I4DLsaxe+61Iwq/4UBRFbITjyT2C2y+XzRP8QE6ar9Iw0yoTOfCgb5VuEm3o8WciXAA3lg== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(14060799003)(7416014)(35042699022)(82310400026)(1800799024)(18002099003)(56012099003)(22082099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BWk9L5cXqQL5zNwxvfNhvGH1dq+ApIlICeEtV/tuk4qcU1DeUs0hei87aoHTUY3wIKlAqR+jmMRx7z1fRNOPv5xrQ8h0aMaDYvC6+KQFozltQxwetj1FYyxny4wI0X6II+7nhE7pX4EQhUyayFHPqD3r+bf2CiptmT3UXDGaioZPFqDBQLJhUQprzTzbw7Px/dhRekUpkPk5aAFyxnLRbdgcJGs/jHsVRd12GDyt0r3KtjGedy6X16mC/PMM5YKqePlAsn9JSPaIj7Ubi1RI7ciVK72odIOOi9Q46ErIrU+brZdbcNz8ZL4e01kOWJRP2iYZXFOgYHU5MbE3a8ee2l04G1//Mkc6D7g1LOWE21M4N944QHjAKK/gGtS4ZSB+5vUT6gXonwGsd62oX8prOBqysMyMccRMdPmZPuWae7a4DBqDMBOjMh8UIvpp4fW/ X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2026 15:10:24.5548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e20b60c-460a-4fff-2f7f-08de8f37a292 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C717.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB9964 On 30/03/2026 3:35 pm, Vlastimil Babka (SUSE) wrote: > On 3/27/26 13:57, Muhammad Usama Anjum wrote: >> From: Ryan Roberts >> >> Whenever vmalloc allocates high order pages (e.g. for a huge mapping) it >> must immediately split_page() to order-0 so that it remains compatible >> with users that want to access the underlying struct page. >> Commit a06157804399 ("mm/vmalloc: request large order pages from buddy >> allocator") recently made it much more likely for vmalloc to allocate >> high order pages which are subsequently split to order-0. >> >> Unfortunately this had the side effect of causing performance >> regressions for tight vmalloc/vfree loops (e.g. test_vmalloc.ko >> benchmarks). See Closes: tag. This happens because the high order pages >> must be gotten from the buddy but then because they are split to >> order-0, when they are freed they are freed to the order-0 pcp. >> Previously allocation was for order-0 pages so they were recycled from >> the pcp. >> >> It would be preferable if when vmalloc allocates an (e.g.) order-3 page >> that it also frees that order-3 page to the order-3 pcp, then the >> regression could be removed. >> >> So let's do exactly that; update stats separately first as coalescing is >> hard to do correctly without complexity. Use free_pages_bulk() which uses >> the new __free_contig_range() API to batch-free contiguous ranges of pfns. >> This not only removes the regression, but significantly improves >> performance of vfree beyond the baseline. >> >> A selection of test_vmalloc benchmarks running on arm64 server class >> system. mm-new is the baseline. Commit a06157804399 ("mm/vmalloc: request >> large order pages from buddy allocator") was added in v6.19-rc1 where we >> see regressions. Then with this change performance is much better. (>0 >> is faster, <0 is slower, (R)/(I) = statistically significant >> Regression/Improvement): >> >> +-----------------+----------------------------------------------------------+-------------------+--------------------+ >> | Benchmark | Result Class | mm-new | this series | >> +=================+==========================================================+===================+====================+ >> | micromm/vmalloc | fix_align_alloc_test: p:1, h:0, l:500000 (usec) | 1331843.33 | (I) 67.17% | >> | | fix_size_alloc_test: p:1, h:0, l:500000 (usec) | 415907.33 | -5.14% | >> | | fix_size_alloc_test: p:4, h:0, l:500000 (usec) | 755448.00 | (I) 53.55% | >> | | fix_size_alloc_test: p:16, h:0, l:500000 (usec) | 1591331.33 | (I) 57.26% | >> | | fix_size_alloc_test: p:16, h:1, l:500000 (usec) | 1594345.67 | (I) 68.46% | >> | | fix_size_alloc_test: p:64, h:0, l:100000 (usec) | 1071826.00 | (I) 79.27% | >> | | fix_size_alloc_test: p:64, h:1, l:100000 (usec) | 1018385.00 | (I) 84.17% | >> | | fix_size_alloc_test: p:256, h:0, l:100000 (usec) | 3970899.67 | (I) 77.01% | >> | | fix_size_alloc_test: p:256, h:1, l:100000 (usec) | 3821788.67 | (I) 89.44% | >> | | fix_size_alloc_test: p:512, h:0, l:100000 (usec) | 7795968.00 | (I) 82.67% | >> | | fix_size_alloc_test: p:512, h:1, l:100000 (usec) | 6530169.67 | (I) 118.09% | >> | | full_fit_alloc_test: p:1, h:0, l:500000 (usec) | 626808.33 | -0.98% | >> | | kvfree_rcu_1_arg_vmalloc_test: p:1, h:0, l:500000 (usec) | 532145.67 | -1.68% | >> | | kvfree_rcu_2_arg_vmalloc_test: p:1, h:0, l:500000 (usec) | 537032.67 | -0.96% | >> | | long_busy_list_alloc_test: p:1, h:0, l:500000 (usec) | 8805069.00 | (I) 74.58% | >> | | pcpu_alloc_test: p:1, h:0, l:500000 (usec) | 500824.67 | 4.35% | >> | | random_size_align_alloc_test: p:1, h:0, l:500000 (usec) | 1637554.67 | (I) 76.99% | >> | | random_size_alloc_test: p:1, h:0, l:500000 (usec) | 4556288.67 | (I) 72.23% | >> | | vm_map_ram_test: p:1, h:0, l:500000 (usec) | 107371.00 | -0.70% | >> +-----------------+----------------------------------------------------------+-------------------+--------------------+ >> >> Fixes: a06157804399 ("mm/vmalloc: request large order pages from buddy allocator") >> Closes: https://lore.kernel.org/all/66919a28-bc81-49c9-b68f-dd7c73395a0d@arm.com/ >> Acked-by: Zi Yan >> Signed-off-by: Ryan Roberts >> Co-developed-by: Muhammad Usama Anjum >> Signed-off-by: Muhammad Usama Anjum > > Acked-by: Vlastimil Babka (SUSE) Thank you. But as the implementation of free_pages_bulk() has changed to using num_pages_contiguous(), I cannot take this tag. Please review the next version again. > > -- --- Thanks, Usama