From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Akashdeep Kaur <a-kaur@ti.com>,
praneeth@ti.com, nm@ti.com, vigneshr@ti.com, rafael@kernel.org,
viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: vishalm@ti.com, sebin.francis@ti.com, k-willis@ti.com,
zhongqiu.han@oss.qualcomm.com
Subject: Re: [PATCH v4 1/1] cpufreq: ti: Add EPROBE_DEFER for K3 SoCs
Date: Mon, 1 Jun 2026 11:28:40 +0800 [thread overview]
Message-ID: <e033f55a-2cf6-431c-8c20-f08c98382136@oss.qualcomm.com> (raw)
In-Reply-To: <20260528090510.829513-2-a-kaur@ti.com>
On 5/28/2026 5:05 PM, Akashdeep Kaur wrote:
> On K3 SoCs, ti-cpufreq relies on k3-socinfo to register the SoC
> device before soc_device_match() can return valid revision
> information. If ti-cpufreq probes before k3-socinfo,
> soc_device_match() returns NULL, leading to incorrect CPU frequency
> scaling behavior.
> Defer probe when k3-socinfo hasn't registered the SoC device yet.
Hi Akashdeep,
Thanks for the update.
>
> Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
> ---
> drivers/cpufreq/ti-cpufreq.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index a01abc1622eb..8219751da175 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -99,6 +99,7 @@ struct ti_cpufreq_soc_data {
> unsigned long efuse_shift;
> unsigned long rev_offset;
> bool multi_regulator;
> + bool needs_k3_socinfo;
> /* Backward compatibility hack: Might have missing syscon */
> #define TI_QUIRK_SYSCON_MAY_BE_MISSING 0x1
> /* Backward compatibility hack: new syscon size is 1 register wide */
> @@ -347,6 +348,7 @@ static struct ti_cpufreq_soc_data am625_soc_data = {
> .efuse_mask = 0x07c0,
> .efuse_shift = 0x6,
> .multi_regulator = false,
> + .needs_k3_socinfo = true,
> .quirks = TI_QUIRK_SYSCON_IS_SINGLE_REG,
> };
>
> @@ -356,6 +358,7 @@ static struct ti_cpufreq_soc_data am62a7_soc_data = {
> .efuse_mask = 0x07c0,
> .efuse_shift = 0x6,
> .multi_regulator = false,
> + .needs_k3_socinfo = true,
> };
>
> static struct ti_cpufreq_soc_data am62l3_soc_data = {
> @@ -364,6 +367,7 @@ static struct ti_cpufreq_soc_data am62l3_soc_data = {
> .efuse_mask = 0x07c0,
> .efuse_shift = 0x6,
> .multi_regulator = false,
> + .needs_k3_socinfo = true,
> };
>
> static struct ti_cpufreq_soc_data am62p5_soc_data = {
> @@ -372,6 +376,7 @@ static struct ti_cpufreq_soc_data am62p5_soc_data = {
> .efuse_mask = 0x07c0,
> .efuse_shift = 0x6,
> .multi_regulator = false,
> + .needs_k3_socinfo = true,
It seems that `ti_cpufreq_soc_data` is a hardware description–only
structure.
After further consideration, may I know would it be reasonable to
consider using of_machine_get_match() instead, for example:
static const struct of_device_id ti_k3_cpufreq_of_match[] = {
{ .compatible = "ti,am625" },
{ .compatible = "ti,am62xx" },
......
{}
};
if (soc_device_match(k3_cpufreq_soc)) {
*revision_value = 0x1;
goto done;
} else if (of_machine_get_match(ti_k3_of_match)) {
return dev_err_probe(xxx);
}
Just a thought — you might want to consider this if it makes sense.
Sorry for not pointing this out earlier, I may have missed it before.
> };
>
> /**
> @@ -443,6 +448,12 @@ static int ti_cpufreq_get_rev(struct ti_cpufreq_data *opp_data,
> goto done;
> }
>
> + /* Defer if k3-socinfo hasn't registered the SoC device yet */
> + if (opp_data->soc_data->needs_k3_socinfo) {
> + dev_dbg(opp_data->cpu_dev,
> + "SoC info not ready yet, deferring probe\n");
> + return -EPROBE_DEFER;
It would be better to use dev_err_probe() here and return the original
error, instead of using dev_dbg() with -EPROBE_DEFER.
Also, the message "SoC info not ready yet" seems a bit too generic and
not very descriptive. Which SoC is this referring to?
> + }
> +
> ret = regmap_read(opp_data->syscon, opp_data->soc_data->rev_offset,
> &revision);
> if (opp_data->soc_data->quirks & TI_QUIRK_SYSCON_MAY_BE_MISSING && ret == -EIO) {
--
Thx and BRs,
Zhongqiu Han
next prev parent reply other threads:[~2026-06-01 3:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:05 [PATCH v4 0/1] cpufreq: ti: Fix probe ordering with k3-socinfo Akashdeep Kaur
2026-05-28 9:05 ` [PATCH v4 1/1] cpufreq: ti: Add EPROBE_DEFER for K3 SoCs Akashdeep Kaur
2026-06-01 3:28 ` Zhongqiu Han [this message]
2026-06-03 7:23 ` Akashdeep Kaur
2026-06-03 14:02 ` Zhongqiu Han
2026-06-08 5:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e033f55a-2cf6-431c-8c20-f08c98382136@oss.qualcomm.com \
--to=zhongqiu.han@oss.qualcomm.com \
--cc=a-kaur@ti.com \
--cc=k-willis@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=rafael@kernel.org \
--cc=sebin.francis@ti.com \
--cc=vigneshr@ti.com \
--cc=viresh.kumar@linaro.org \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®