From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794257412; b=nePKtAmT6/90QOPxnw3J0j4zaxJyVzzHgu3+V77AjT7nekiMs3kyMsMaLUDwdlxA8N3f G3EL0FmoR9d+4h5ivz3eb6CgglOykbbcw4XJnb78FFUoJBJbsXaEmgjmp+HDMR+SlebjS +z6wcmZpsUTG5Bb4sFCA8wh8xBeo6ACDlISqI4kveHT4nGn6EkPLC7XcOpYL1+tm74kkl NjG/v3aMIl8Zjr626uu5Hwk0Ov5GdcnIgaQ/fYuiW98O33socG/+ssGBUujwRL1vbnmWV LUSoJSnER+PSKVMUJTzVTYv+38JZ0kcRa0E1mOSe/p6FF8wcDZn61vdNrqBybMydx+w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794257412; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=+OMth3PG85AL4kECknkxpCnD4PaCA8VlkmtQ0uA4Vxo=; b=SjT6tQPH5zA7eDfgDXQ88FhIE4N54FRIefRU6W9RvfgOFE6Ytf6EEDFPLZ1EbPigZVat 5oWixS56boGkw5pqazqtru0c5Dl+h/pY5ru56GV/23W9tQd2G/wJHzWCS5w1V7HZzMA4V LM1NIV7otsMF7Tbg6b8lbOfArU4Axw2AJsfr98RXVm7JWwXUcnjnwykYnd8sjWM0PbfZJ on6PNdBt92f2Rhg2YoZXvjKs6BmORkABPkUSq0ak/X2G1y+beT8/z4jx3gRtwuTAq7KCK G25vCdgaxtTY9OPhplj3si4i/G9DysuGIxZzezi7s7VsiLYCWg1dfdrQUSGF1iHVSBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iDueje2g; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0183A606A330 for ; Mon, 9 Nov 2026 20:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iDueje2g Received: by smtp.kernel.org (Postfix) with ESMTPSA id D582A1F0089F; Mon, 9 Nov 2026 20:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794257411; bh=+OMth3PG85AL4kECknkxpCnD4PaCA8VlkmtQ0uA4Vxo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=iDueje2gQCdXWNWbQrEXkn7wfOtQOBvJF3tKjNmoFN8dXBstJSwWREDHMX31AFHrK p/DKtQ6xOt3M5j/yTG6JT/oQyWiVzcQ94QuqgaEdoMAg5gyKl5ROwTiG4LLOB3vppg TyEWwcISD4aDsGU70Xupw18WZwQZM+kpYZ9yDIeXl2oFwS170JQo2tM9vGvMZfeQbh wnU6Mceyqr3y5/cLUWyKuV0v2pn0q2GMkl3nYGpu2FT9PdLKWn2bybPHFliWXlRpJe ZE+4IJeguIrIz5A1bc+7HK9FOAiBJFWHnIl+blYZoDCCQeHlgUc9/OxDiyEXoGPQKI nrf8U6+N/0keg== Message-ID: Date: Mon, 9 Nov 2026 21:50:06 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove unused clear_flush_young_ptes_notify() To: Shivank Garg , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20261109-clear-flush-young-notify-v1-1-b37fbafa2686@amd.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261109-clear-flush-young-notify-v1-1-b37fbafa2686@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/9/26 19:41, Shivank Garg wrote: > clear_flush_young_ptes_notify()'s last user was removed in > commit f3c493d2f42b ("mm/rmap: handle device-exclusive entries in > folio_referenced_one()"), which open-codes clear_flush_young_ptes() > and mmu_notifier_clear_flush_young() in folio_referenced_one(). > > Remove both the CONFIG_MMU_NOTIFIER definition and the > !CONFIG_MMU_NOTIFIER alias. > > Signed-off-by: Shivank Garg > --- > Applies cleanly on mm/core.git/for-next. > --- > mm/internal.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index b129510b92e2..b1f3a1a59bc0 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1598,17 +1598,6 @@ static inline void maybe_rmap_unlock_action(struct vm_area_struct *vma, > } > > #ifdef CONFIG_MMU_NOTIFIER > -static inline bool clear_flush_young_ptes_notify(struct vm_area_struct *vma, > - unsigned long addr, pte_t *ptep, unsigned int nr) > -{ > - bool young; > - > - young = clear_flush_young_ptes(vma, addr, ptep, nr); > - young |= mmu_notifier_clear_flush_young(vma->vm_mm, addr, > - addr + nr * PAGE_SIZE); > - return young; > -} > - > static inline bool pmdp_clear_flush_young_notify(struct vm_area_struct *vma, > unsigned long addr, pmd_t *pmdp) > { > @@ -1641,7 +1630,6 @@ static inline bool pmdp_test_and_clear_young_notify(struct vm_area_struct *vma, > > #else /* CONFIG_MMU_NOTIFIER */ > > -#define clear_flush_young_ptes_notify clear_flush_young_ptes > #define pmdp_clear_flush_young_notify pmdp_clear_flush_young > #define test_and_clear_young_ptes_notify test_and_clear_young_ptes > #define pmdp_test_and_clear_young_notify pmdp_test_and_clear_young > > --- > base-commit: 2683df3b7eac1d91380194955ad0c9751454610c > change-id: 20261109-clear-flush-young-notify-dac8b5496ec4 > > Best regards, Reviewed-by: David Hildenbrand (Arm) I'll wait a bit and will then queue this. -- Cheers, David