mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com,
	ntb@lists.linux.dev, linux-kernel@vger.kernel.org,
	fuyuanli0722@gmail.com
Subject: Re: [PATCH v2] ntb: Add mutex to make link_event_callback executed linearly.
Date: Mon, 25 Aug 2025 10:18:53 -0600	[thread overview]
Message-ID: <e039337b-0bf7-4238-aa5e-21100a2646ac@deltatee.com> (raw)
In-Reply-To: <aKwpnFtdtBlDv69O@didi-ThinkCentre-M930t-N000>



On 2025-08-25 03:15, fuyuanli wrote:
> Since the CPU selected by schedule_work is uncertain, multiple link_event
> callbacks may be executed at same time. For example, after peer's link is
> up, it is down quickly before local link_work completed. If link_cleanup
> is added to the workqueue of another CPU, then link_work and link_cleanup
> may be executed at the same time. So add a mutex to prevent them from being
> executed concurrently.
> 
> Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>

Looks good to me, thanks

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

  parent reply	other threads:[~2025-08-25 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  9:15 fuyuanli
2025-08-25 15:06 ` Dave Jiang
2025-09-03  2:20   ` yuanli fu
2025-09-03 15:26     ` Dave Jiang
2025-08-25 16:18 ` Logan Gunthorpe [this message]
2025-09-30  6:50 ` yuanli fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e039337b-0bf7-4238-aa5e-21100a2646ac@deltatee.com \
    --to=logang@deltatee.com \
    --cc=allenbh@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=fuyuanli0722@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntb@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®