From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A4333CF022 for ; Wed, 25 Mar 2026 11:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438431; cv=none; b=HkKP5srBwGpp8KKADu7Q5bDAvpzLatHeHxQ9eCaSo/NCfx/bsk0MJgsW8TnWsa2gD9iAJV8YASILJdX6eHm6EULNJpRMM0eoX6qtCF5S3C7OaTQzu7/4JouEvMHEA7faPbeMdsZCQsoiNVXh7Kq7XV/cKLmdfoKAwZnLVPoLQJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438431; c=relaxed/simple; bh=zrTu/Fk6R5LsUpKkvhxFJueXyQGTKcxc82WecP7Bj1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fpcqo0gBPRV8grD5c7LHDoiFD88UUg3txnpEpwwvYw9YqCD4aT/abir+iiZjQfdkGZ1I/DXIpGAHigeu4jThzpkE8rkDLsXREvKLdW4+Xd/mtO6F7GYcIegfTFIVE1qfhlWTSRcI3G3ePkr/lXG+dUX1TKrGg84FH1RgOO0krns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oDLQjUn7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TRCLY1nd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oDLQjUn7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TRCLY1nd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PBGOMc3922592 for ; Wed, 25 Mar 2026 11:33:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Rj5/AzTuJ4vyMcaPjO0Gng38EceXd49d1VK/6ipC9lo=; b=oDLQjUn7PQCQaBbM l2/1sUxAIvkFNa0FmE7FkXoSDecF85GqndHd+u2p4AxReIWS1eKqI3hnDmspBVl1 cIS/sEPMfzwnFlI5xm6J1vAmMk2ooI7V6KmNlXZIrJmJ83UN+RNVAkJP13zEDqbV pRVqOFXsPQ6+zyrm35yLA4rVLRlJFIfu69VQjdFrrhgwlEf1nASMXC8mrtDNWLkw sOgK0XKIMm6l5EnpuNUss1dOLbC4SEWYO2K88zzUchOuQdiiGOe/t4zOTYp7HXPf zHhoPPFl0p4POv/6/GE6LsxaSBLGsxYRwM3SuAX3Tirrcle8ted4BlTL3eRUcaJv dMiXNQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d40ratwna-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:33:48 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5091782ab06so309227311cf.0 for ; Wed, 25 Mar 2026 04:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774438428; x=1775043228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rj5/AzTuJ4vyMcaPjO0Gng38EceXd49d1VK/6ipC9lo=; b=TRCLY1ndyQnGK5LPGl7Krlj62jn36qoWUAr0HFOUMqWlyz0dmfP4L4xtwVEmGCKEPh 8hkRURC2yGK/HS0r9KTgiUP4h0kOZsAzkPjwTJTIkx7wRmB0FYxgErpSuexhV4h+1Srr oa5SlLIjtU4MrBEr1OFDhtaUz5lguvIbkeR10mwitiqR+cBzcXel/O9QUsuv3Smv+nco sYIClWM71WVMAFAt08QxQnP7M+76jYNeqYqQd1ZaHKUT3JSPN9LO76w/hq818CpxSU6K sGVA5JCHPCaRlrMuv317mq6nqO1zbX+zbgIJZNMa7eJ1CuaY0K0vc2UNWcNZD4ZJSrkR PJpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774438428; x=1775043228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rj5/AzTuJ4vyMcaPjO0Gng38EceXd49d1VK/6ipC9lo=; b=XfH8IEU91Ocx97HNiORPMwxgAYyc+JC9YxU6iQ5FVjbchynQXApZ3zIw3ha9BMOHoq yyKrudCjO5SiWrFx8DnOSgcmBQ43U7KCjLqDG6gcVS22Q3tfDqBNJR7jWJlvsWmKMwCs 4KwdRuT4PjxzMXFqti0jIVwJHjTKUqk9n67o6sB6U3WFU4kp0tgYyj+Q//hBWs1VR3Oy isceGrFwxvcGAXg9ZiQovRBzg+UKlM5XU302YIFIv6qh3sI9aEX4IMNxP1hW07cc6dUT dA/czxFBfZoyPrhxZo51GXFlszjKloNt1Ra8/PctFM9zI44p29I9Ts5+9NYA+S+sNgbR KM/w== X-Forwarded-Encrypted: i=1; AJvYcCV966NhH76AOFzcLI0D+JEdJLUb5Ieqo8aY0muCcpgKWNm6VBUx+ByiyTRUVvO7FpP+UqVxoI2a2CmAjDY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq3PpiDAiIQQ4XrNzS0gKGMi3jwXWrBK8H55t8SbEQf6Hk0v+e cZ68ZDxQiQzEvT53AOwRB46Za5Bt/f8DZq0tLmBxeGaGQfJej0/Bli/Tb8U7IGFrJhwAeMDu1ZI AYw/+MeUjEH5grIS2goqW9qRQJwudIwTOw2v3ApJsm5giZKNoB86VL24fEquuAAUKcWA= X-Gm-Gg: ATEYQzwGDXpsOA7i00/D4Q7Uz1GAb4OIUgeFltv+1aBYGlJTp+mtz7mHcibZAjGthTE YPR6GNdxBkAFFGyrcLhbnc+DrrDSpuCDG9HgOz7SWZYOBZYjqPgF1gAVppZC8NlnyVfEi5ZCbRw EjCb1tSw2vGfv0J/0Fizdj6646ItDHm7vBqdfVaoQEnU/8RPt+Y7Rt60oZJc6/12C2HXjcVgE+X gmV03TfgtVMPtgeXwTBhpCrrzltzGn/iMroXDp7NjS4qqiB5gAkhFFjkr+/s7xjS4JI5kszbn8Z ZTN8Y9f2qFW/VcUO5eSMy+YmK5NTfgnZEA5VfI/Y4OcfXdnY+TjZPD4RAhZoDqYSBnfAHhy/FiV qmGiuBKNTKtZVGLqvz4CVSfcOAy3Ssdahn50F3Z+gkWRjuQJP X-Received: by 2002:a05:622a:5c95:b0:50b:483d:3669 with SMTP id d75a77b69052e-50b80e82d15mr40947731cf.62.1774438427587; Wed, 25 Mar 2026 04:33:47 -0700 (PDT) X-Received: by 2002:a05:622a:5c95:b0:50b:483d:3669 with SMTP id d75a77b69052e-50b80e82d15mr40947341cf.62.1774438427032; Wed, 25 Mar 2026 04:33:47 -0700 (PDT) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4871728a19dsm40109145e9.1.2026.03.25.04.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 04:33:46 -0700 (PDT) Message-ID: Date: Wed, 25 Mar 2026 11:33:45 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens To: Mark Brown , Srinivas Kandagatla Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Stable@vger.kernel.org References: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> <20260323223845.2126142-5-srinivas.kandagatla@oss.qualcomm.com> <61596b66-4fef-4bdc-93f2-a8639da79d32@sirena.org.uk> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <61596b66-4fef-4bdc-93f2-a8639da79d32@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Jvr8bc4C c=1 sm=1 tr=0 ts=69c3c81c cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=kvLm1XpQD2xK1ocldNYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: vV9BPoyhMyFCc2SxnwXWCmggujaet522 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA4MSBTYWx0ZWRfX/wkZvtAbg6sv Wd4BmM7LGI/3e1z4Yc1j5G4OQcY2QdZk25aeNdb71tXO+qY6NuexirjYh118HX5evl3iGxwwMsb CzafcxRS/KpK2Dfwo9WAL+41+609pl1JkNJvhUCQf2FhMZK0uHTxwlpYmNi+OqOSusep6A8DbFQ reTaMuJXsloCxMb/4uM0PR4mr0G+35SxVhCb6SzWAqtVaJKbJ/fiaP0Kf7ZOy3mVzmYIywh6BXQ bXPpOnh8zc96DYb2ZPcS16Gj3ef2gKizwspFiqViZQKQNFre41C4fvpTaSpsRfw+AawXHu9xxZg LD84LPyWFShxjXPIkK7gMHZ0Um237r6QNrj/jg2i1yvxrdO03RbZdKXB2e9XmSwA9eXTdsmNlsm NZdD7nfU00WYIKypOesjO+IBpiVq+fpTz71INg9SS8hSOS7+UOqpnDnPInAVTP6qU+dl4c/Nlfi AtawGrRKg9DzIrzk1tA== X-Proofpoint-GUID: vV9BPoyhMyFCc2SxnwXWCmggujaet522 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250081 On 3/24/26 6:25 PM, Mark Brown wrote: > On Mon, Mar 23, 2026 at 10:38:36PM +0000, Srinivas Kandagatla wrote: >> As prepare can be called mulitple times, this can result in multiple >> graph opens for playback path. > >> */ >> - if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { >> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph[dai->id] == NULL) { > > This is an array of APM_PORT_MAX elements but we have DAI IDs in the DT > bindings over that and now we're using the DAI ID to index into the The driver has dai->id indexing the array in most places, and that is how it has been for a while. This is one of the problem which last patch is trying to address doing a check on the range. At somepoint we need to move to dynamic allocation tbh. --srini > array (I didn't check for existing instances...). This might be > impossible due to system design though.