Re: [PATCH v2 3/3] Bluetooth: btusb: mediatek: add MediaTek ISO data transmission function

["Chris Lu (陸稚泓)" <Chris.Lu@mediatek.com>]

Hi Luiz,

Thanks for your reminding, I will fix the error and follow your
suggestion in last mail about moving some vendor-specific change from
btusb.c to btmtk.c to minimize the change in btusb.c.
I'll submit another version soon.

Thanks,
Chris.

On Wed, 2024-06-05 at 14:06 -0400, Luiz Augusto von Dentz wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Hi Chris,
> 
> On Wed, May 29, 2024 at 7:10 PM kernel test robot <lkp@intel.com>
> wrote:
> >
> > Hi Chris,
> >
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on bluetooth-next/master]
> > [also build test ERROR on next-20240529]
> > [cannot apply to bluetooth/master linus/master v6.10-rc1]
> > [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> > And when submitting patch, we suggest to use '--base' as documented
> in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url:    
> https://github.com/intel-lab-lkp/linux/commits/Chris-Lu/Bluetooth-net-add-hci_iso_hdr-function-for-iso-data/20240529-143216
> > base:   
> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
>  master
> > patch link:    
> https://lore.kernel.org/r/20240529062946.5655-4-chris.lu%40mediatek.com
> > patch subject: [PATCH v2 3/3] Bluetooth: btusb: mediatek: add
> MediaTek ISO data transmission function
> > config: i386-randconfig-014-20240530 (
> https://download.01.org/0day-ci/archive/20240530/202405300602.AUh9Yu96-lkp@intel.com/config
> )
> > compiler: clang version 18.1.5 (
> https://github.com/llvm/llvm-project
> 617a15a9eac96088ae5e9134248d8236e34b91b1)
> > reproduce (this is a W=1 build): (
> https://download.01.org/0day-ci/archive/20240530/202405300602.AUh9Yu96-lkp@intel.com/reproduce
> )
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a
> new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: 
> https://lore.kernel.org/oe-kbuild-all/202405300602.AUh9Yu96-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> ld.lld: error: undefined symbol: btmtk_isopkt_pad
> >    >>> referenced by btusb.c:2267 (drivers/bluetooth/btusb.c:2267)
> >    >>>               drivers/bluetooth/btusb.o:(btusb_send_frame)
> in archive vmlinux.a
> 
> Please have the above fixed and while at move the vendor specific
> handling of the new endpoint to btmtk.c since that is not standard it
> shall not be part of btusb.c
> 
>