mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: phasta@kernel.org,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
	"Boris Brezillon" <boris.brezillon@collabora.com>,
	"Danilo Krummrich" <dakr@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Juan Yescas <jyescas@google.com>,
	kernel-team@android.com
Subject: Re: [PATCH v2 1/2] drm/drm_crtc: ensure dma_fence_ops remain valid during device unbind
Date: Mon, 20 Jul 2026 13:04:43 +0100	[thread overview]
Message-ID: <e03eb40c07d8603592ca38e7538d6709891bf811.camel@linaro.org> (raw)
In-Reply-To: <b39f29efd4db9a2e10c6d1943a22b826cc5232f8.camel@mailbox.org>

Hi Philipp,

(sorry for the slow reply).

On Thu, 2026-07-09 at 16:40 +0200, Philipp Stanner wrote:
> On Thu, 2026-07-09 at 15:19 +0100, André Draszik wrote:
> > Hi Philipp,
> > 
> > On Thu, 2026-07-09 at 14:32 +0200, Philipp Stanner wrote:
> > > 
> > > On Wed, 2026-07-08 at 16:22 +0100, André Draszik wrote:
> > > 
> > 

[...]

> > > 
> The issue here seems to be that 
> a) the crtc is made invalid in drm_crtc_cleanup() (memset(0))
> b) the drm_dev can disappear after drm_crtc_cleanup()
> 
> Both issues stem from the fact that the fence callbacks can keep
> running into the driver.
> 
> It is true that the fence, being refcounted, can stay alive, but none
> of the callbacks be invoked anymore, and your grace period wait
> fullfill.
> 
> It is a strict dma_fence requirement that a fence issuer / producer
> signals all its fences before unload.

OK, I missed that. In that case, the patch should indeed be fine as-is.
I'll just do the (minor) updates as you had requested.

Thanks Philipp

  reply	other threads:[~2026-07-20 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 15:22 [PATCH v2 0/2] drm/drm_crtc: dma_fence_ops fixes André Draszik
2026-07-08 15:22 ` [PATCH v2 1/2] drm/drm_crtc: ensure dma_fence_ops remain valid during device unbind André Draszik
2026-07-09 12:32   ` Philipp Stanner
2026-07-09 14:19     ` André Draszik
2026-07-09 14:25       ` André Draszik
2026-07-09 14:40       ` Philipp Stanner
2026-07-20 12:04         ` André Draszik [this message]
2026-07-08 15:22 ` [PATCH v2 2/2] drm/drm_crtc: fix race with dma_fence_signal() in ::get_driver_name() André Draszik
2026-07-09 12:48   ` Philipp Stanner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e03eb40c07d8603592ca38e7538d6709891bf811.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=airlied@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyescas@google.com \
    --cc=kernel-team@android.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=phasta@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=tvrtko.ursulin@igalia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®