From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] regmap: maple: Don't sync read-only registers
Date: Tue, 13 Jun 2023 11:59:27 +0100 [thread overview]
Message-ID: <e04053b2-897c-46fa-bd1f-e455e01c6152@sirena.org.uk> (raw)
In-Reply-To: <87ilbrejlm.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Tue, Jun 13, 2023 at 12:34:45PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Tue, Jun 13, 2023 at 09:45:11AM +0200, Takashi Iwai wrote:
> > This should be in _needs_sync().
> I thought it's a different logic? regacahe_reg_needs_sync() checks
> only whether it's a default value, and other call paths already check
> regmap_writeable().
Yeah, but it feels like that's the reason we ran into this issue given
that you'd expect _needs_sync() to check this too.
> But I can put the check there instead if you still prefer, too.
It should avoid any similar issues in future.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-13 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:45 Takashi Iwai
2023-06-13 10:16 ` Mark Brown
2023-06-13 10:34 ` Takashi Iwai
2023-06-13 10:59 ` Mark Brown [this message]
2023-06-13 11:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04053b2-897c-46fa-bd1f-e455e01c6152@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®