From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A716C1474BF; Mon, 13 May 2024 08:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715589535; cv=none; b=H+c12jCz0fxJiqvAnxaU74yAOlHSVYfIG/8a1cs0CN4NCMbvovq22vhyBM5O02m6aL31gaZbmcUPZ/Ol+Ro4ldU1kpg44swBSDnKqv7UcMA+04x41oksGSQk7/AroLeDfAksch9EXrneUQ3CYemgFDGoEfs5GWOD1QZMRuZY8TM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715589535; c=relaxed/simple; bh=c1KwfKns8MkeB2edhXAms9n+qyde5juF1WywGcY26CY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DlZFbNT6C3Nqk/O7v9hzN2Vff4JNcuWdrGoUNnJRoN3BiWIiWdHqyc8hhoyAwV8e0wxWouFSyWsXmzA3zRuTQN852hCFNqnU4C1wQoUwHqQ25WHl2VGOmUurbuTOvkk2NxXgZpkh5h5ID+MxWUJSVAjoUgAr73tqJ6tlVsrbg9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=kaJ8ujuT; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="kaJ8ujuT" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 44D8cLV7060414; Mon, 13 May 2024 03:38:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1715589501; bh=8mdLAS9+nHpOtQ8+Tb9Jzo2ljMF9dW2lja3ATRQPdTc=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=kaJ8ujuThLIvlMO9QnsPHRNW2l3FYTeHRIa+gY8GgehAZP2+GoF64OrcevwP56BoY FDq0fc0VXLnlwJoIa0VdFuJHZQWLyxj90Y+QlRwA4Tj6YzHMWt0bSiLJFVZVqmT04+ 4FLdZ1iiBzLxgmuZL5FLnxjLefIIOj/PA+Zo8W58= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 44D8cL9e093535 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 May 2024 03:38:21 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 13 May 2024 03:38:20 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 13 May 2024 03:38:20 -0500 Received: from [172.24.23.101] (lt5cd112gspw.dhcp.ti.com [172.24.23.101]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 44D8bit0002646; Mon, 13 May 2024 03:37:46 -0500 Message-ID: Date: Mon, 13 May 2024 14:07:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter To: Laurent Pinchart CC: Tomi Valkeinen , Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , DRI Development List , Devicetree List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Praneeth Bajjuri , Udit Kumar , Francesco Dolcini , Alexander Sverdlin , Randolph Sapp , Devarsh Thakkar , Jayesh Choudhary , Jai Luthra References: <20240511193055.1686149-1-a-bhatia1@ti.com> <20240511193055.1686149-3-a-bhatia1@ti.com> <20240512193459.GF17158@pendragon.ideasonboard.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: <20240512193459.GF17158@pendragon.ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Hi Laurent, Thank you for reviewing the patches! On 13-May-24 01:04, Laurent Pinchart wrote: > Hi Aradhya, > > Thank you for the patch. > > On Sun, May 12, 2024 at 01:00:53AM +0530, Aradhya Bhatia wrote: >> Add devicetree binding schema for AM625 OLDI Transmitters. >> >> Signed-off-by: Aradhya Bhatia >> --- >> .../bindings/display/ti/ti,am625-oldi.yaml | 153 ++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 154 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml b/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml >> new file mode 100644 >> index 000000000000..0a96e600bc0b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/ti/ti,am625-oldi.yaml >> @@ -0,0 +1,153 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/ti/ti,am625-oldi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments AM625 OLDI Transmitter >> + >> +maintainers: >> + - Tomi Valkeinen >> + - Aradhya Bhatia >> + >> +description: | >> + The AM625 TI Keystone OpenLDI transmitter (OLDI TX) supports serialized RGB >> + pixel data transmission between host and flat panel display over LVDS (Low >> + Voltage Differential Sampling) interface. The OLDI TX consists of 7-to-1 data >> + serializers, and 4-data and 1-clock LVDS outputs. It supports the LVDS output >> + formats "jeida-18", "jeida-24" and "vesa-18", and can accept 24-bit RGB or >> + padded and un-padded 18-bit RGB bus formats as input. >> + >> +properties: >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: serial clock input for the OLDI transmitters >> + >> + clock-names: >> + const: s_clk >> + >> + ti,companion-oldi: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to companion OLDI transmitter. This property is mandatory for the >> + primarty OLDI TX if the OLDI TXes are expected to work either in dual-lvds >> + mode or in clone mode. This property should point to the secondary OLDI >> + TX. >> + >> + ti,secondary-oldi: >> + type: boolean >> + description: Boolean property to mark an OLDI TX as secondary node. >> + >> + ti,oldi-io-ctrl: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to syscon device node mapping OLDI IO_CTRL registers found in the >> + control MMR region. This property is needed for OLDI interface to work. >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Parallel RGB input port >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: LVDS output port >> + >> + required: >> + - port@0 >> + - port@1 >> + >> +allOf: >> + - if: >> + properties: >> + ti,secondary-oldi: true >> + then: >> + properties: >> + ti,companion-oldi: false >> + ti,oldi-io-ctrl: false >> + clocks: false >> + clock-names: false >> + >> + else: >> + required: >> + - ti,oldi-io-ctrl >> + - clocks >> + - clock-names >> + >> +required: >> + - reg >> + - ports >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + oldi_txes { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + oldi: oldi@0 { >> + reg = <0>; >> + clocks = <&k3_clks 186 0>; >> + clock-names = "s_clk"; >> + ti,oldi-io-ctrl = <&dss_oldi_io_ctrl>; > > What bus does this device live on ? Couldn't the I/O register space be > referenced by the reg property ?. > These registers are a part of the system-controller register space (ctrl_mmr0). The whole register set is owned by the main_conf[0] devicetree node, with sub-nodes pointing to specific regions. That's why I cannot reference these registers directly. The IO control node for OLDI will look like this though[1]. [0]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/ti/k3-am62-main.dtsi#n45 [1]: https://github.com/aradhya07/linux-ab/commit/7d7184fb36dc22c67cc2704fe708e885f300860c >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + oldi_in: endpoint { >> + remote-endpoint = <&dpi0_out>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + > [ ... ] -- Regards Aradhya