From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org
Subject: Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases
Date: Wed, 9 Aug 2017 12:05:03 +0100 [thread overview]
Message-ID: <e055ec23-38f2-fa41-4ae2-fd01b18a8a87@ideasonboard.com> (raw)
In-Reply-To: <a984305d-6ba2-5b1a-b68a-98a9bcd245df@redhat.com>
On 09/08/17 11:58, Javier Martinez Canillas wrote:
> Hi Kieran,
>
> On 08/09/2017 12:29 PM, Kieran Bingham wrote:
>> Hi Javier,
>>
>> Thankyou for the patch
>
> You are welcome.
>
>> On 09/08/17 10:37, Javier Martinez Canillas wrote:
>>> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
>>> device was registered via OF, and the driver is only exporting the OF ID
>>> table entries as module aliases.
>>>
>>> So if the driver is built as module, autoload won't work since udev/kmod
>>> won't be able to match the registered OF device with its driver module.
>>
>> Good catch, and perhaps I should have known better :D
>>
>> I've only worked on this driver as a built-in so far :-) #BadExcuses
>>
>
> A better excuse I think is that after all these years, one would had thought
> that the I2C OF modalias issue would had been finally fixed, but not yet :)
Quite! Let's try to bubble that back up the todo list.
Now - where did I put my free time. I'm sure I left it around here somewhere :-)
--
Kieran
next prev parent reply other threads:[~2017-08-09 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 9:37 Javier Martinez Canillas
2017-08-09 10:29 ` Kieran Bingham
2017-08-09 10:58 ` Javier Martinez Canillas
2017-08-09 11:05 ` Kieran Bingham [this message]
2017-08-09 11:16 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e055ec23-38f2-fa41-4ae2-fd01b18a8a87@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome