mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	Abdun Nihaal <nihaal@cse.iitm.ac.in>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	 brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,  stable@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: Fix memory leak in brcmf_sdio_read_control()
Date: Sun, 02 Aug 2026 18:41:32 +0200	[thread overview]
Message-ID: <e059b52701d3cad4480dfb506e61474924b9f29e.camel@sipsolutions.net> (raw)
In-Reply-To: <20260802083905.3819981-2-arend.vanspriel@broadcom.com>

On Sun, 2026-08-02 at 10:38 +0200, Arend van Spriel wrote:
> On Wed, 22 Jul 2026 16:37:12 +0530, Abdun Nihaal <nihaal@cse.iitm.ac.in> wrote:
> > The memory allocated for buf is not freed in some of the error paths in
> > brcmf_sdio_read_control(). Fix that by adding vfree() calls.
> > 
> > Fixes: dd43a01c5cdb ("brcmfmac: use dynamically allocated control frame buffer")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
> > ---
> > Compile tested only. Issue found using static analysis.
> > 
> >  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> To be applied to wireless tree.

I'm going to put this into wireless-next, at this point (-rc6) this just
doesn't cut it, the commit message makes it sound purely theoretical.

johannes

  reply	other threads:[~2026-08-02 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 11:07 Abdun Nihaal
2026-08-02  8:38 ` Arend van Spriel
2026-08-02 16:41   ` Johannes Berg [this message]
2026-08-02 16:44     ` Johannes Berg
2026-08-03  5:44       ` Arend van Spriel
2026-08-03  8:21         ` Arend van Spriel
2026-08-03  8:35           ` Johannes Berg
2026-08-03  8:54             ` Arend van Spriel
2026-08-03  8:57               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e059b52701d3cad4480dfb506e61474924b9f29e.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nihaal@cse.iitm.ac.in \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®