From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: st_spi_fsm: remove unused variable
Date: Thu, 19 Sep 2019 18:08:08 +0300 [thread overview]
Message-ID: <e062df64-1e13-f88d-5bef-cbc3a1a7fdf0@cogentembedded.com> (raw)
In-Reply-To: <20190919122937.29850-1-brgl@bgdev.pl>
Hello!
On 09/19/2019 03:29 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The region resource in struct stfsm is unused and can be removed.
OK, except it's not a variable (as the subject says), it's a structure field.
"region resource" also seems strange...
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index f4d1667daaf9..1888523d9745 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -255,7 +255,6 @@ struct stfsm_seq {
> struct stfsm {
> struct device *dev;
> void __iomem *base;
> - struct resource *region;
> struct mtd_info mtd;
> struct mutex lock;
> struct flash_info *info;
MBR, Sergei
prev parent reply other threads:[~2019-09-19 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 12:29 Bartosz Golaszewski
2019-09-19 15:08 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e062df64-1e13-f88d-5bef-cbc3a1a7fdf0@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®