From: "yukuai (C)" <yukuai3@huawei.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Matthew Ruffell <matthew.ruffell@canonical.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
nbd <nbd@other.debian.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PROBLEM] nbd requests become stuck when devices watched by inotify emit udev uevent changes
Date: Mon, 16 May 2022 20:53:21 +0800 [thread overview]
Message-ID: <e0718adf-fe2a-5f1d-a880-bac72cabfe42@huawei.com> (raw)
In-Reply-To: <YoJA8C2XtXY27qJ1@localhost.localdomain>
在 2022/05/16 20:17, Josef Bacik 写道:
>> Hi, Josef
>>
>> This seems to try to fix the same problem that I described here:
>>
>> nbd: fix io hung while disconnecting device
>> https://lists.debian.org/nbd/2022/04/msg00207.html
>>
>> There are still some io that are stuck, which means the devcie is
>> probably still opened. Thus nbd_config_put() can't reach here.
>> I'm afraid this patch can't fix the io hung.
>>
>> Matthew, can you try a test with this patch together with my patch below
>> to comfirm my thought?
>>
>> nbd: don't clear 'NBD_CMD_INFLIGHT' flag if request is not completed
>> https://lists.debian.org/nbd/2022/04/msg00212.html.
>>
>
> Re-submit this one, but fix it so we just test the bit to see if we need to skip
> it, and change it so we only CLEAR when we're sure we're going to complete the
> request. Thanks,
Ok, thanks for your advice. I'll send a new version.
BTW, do you have any suggestions on other patches of the patchset?
https://lore.kernel.org/all/20220426130746.885140-1-yukuai3@huawei.com/
Thanks,
Kuai
>
> Josef
> .
>
prev parent reply other threads:[~2022-05-16 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 5:42 Matthew Ruffell
2022-04-22 15:23 ` Josef Bacik
2022-04-25 21:47 ` Matthew Ruffell
2022-05-13 2:56 ` Matthew Ruffell
2022-05-13 3:20 ` yukuai (C)
2022-05-13 13:13 ` Josef Bacik
2022-05-14 3:39 ` yukuai (C)
2022-05-16 5:35 ` Matthew Ruffell
2022-05-16 12:17 ` Josef Bacik
2022-05-16 12:53 ` yukuai (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0718adf-fe2a-5f1d-a880-bac72cabfe42@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.ruffell@canonical.com \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®