From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA99C3E008B for ; Thu, 4 Jun 2026 16:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780588890; cv=none; b=CizD9ILa9VdiQ5Qwem4pctZCY6dk/nkTf34cgdUii4TXOWg4gM1616GWpgatSTbXfzgehCFMwn+P6qSMhPNHcXledj6swRJ18bJOo0u2skqzGC1Kc/okh+omgqQPp4r3ZDxb9WaMkDauRxphoUvgLKbfdmgzb/ehCQLt4SoAhuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780588890; c=relaxed/simple; bh=xC3/CEFaf3hg4/vKMnMcKeo7O3cqv8d7FnQwu9/kLm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AY3jyuXi+cGfa+kriKz5VyDGHnc8FkJB2WqFDfiwreW1bxody1p5LtsOhjYGJO1DmRFwBnOLF4/awzF6NHMvqUAp3pUsGxgdSuXiJnKbkzPbPbK2ijPoHs6PPRUG4yFVPpLhipDrMrBx911wNv49aoy1wRaV6a6iEtuDaCT3aIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XVNcAUVA; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XVNcAUVA" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5aa68cf8643so55118e87.0 for ; Thu, 04 Jun 2026 09:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780588887; x=1781193687; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=uGO+JoBq8PgFZVH5FUV2MufUBmEh2YHb4HRdQgvnePA=; b=XVNcAUVAlolC7ehYvK9k5XvR3cJK3NhucrtM+TSdlZy0J4h+qA2gXs/j7rLv1O5YWG VNDewuknM1LYGa+6O3sWoZ40axaVLpj/i4E/DoeYG9U5nEfUfiiSFc3XRBDNkvcMlB+2 XMl3m3sWamHufQxHirIlKPmcoUKiQ3mjA4m29wPvs6TyHIBrl59FU3zROaeNZwp36mZd 2rY8dM/GTlcVUorR26qt8LHEZCSXSBKLrPnrGO93nD/5H4JtaRbMutLGGe7hmmVptcmg ATVtyDmJqf9bHTQhcOOzxtaGTjIocF9wj2fNTUBpiDzlEfidLOIjOhABtir9chhKfTyF 60ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780588887; x=1781193687; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uGO+JoBq8PgFZVH5FUV2MufUBmEh2YHb4HRdQgvnePA=; b=RqcNoIV5b5we6sAJge2W/aGAqa99Yq67sTd0E0EtJmLDQrSsxfHNQsQpDl/l7bUS7I tigQiHwCxivKOBuxrbLtfF5sHxw5Fu2MVxl6xruY86LZam22p9j73cTmnj88nUmbFSVD z69WfO/OY4f7Auv8/zXvRzAdRz053o8nNV9MwRuHgIc4DfSxfMVNasjST4CXP8ioak3c tfS56zzxqDkPqle7dJyDNwl8fPTnyotm08I0aUWtv5/Uot53xOFBskFSThsG49nN1je8 wqsaWrxpY7p1Dj7XJh19f18Zs6QOgyYuvdxjif0haR0Ny0RpzqrZIHYnNyKEeEgzPyMA Lb8A== X-Forwarded-Encrypted: i=1; AFNElJ+RXBgBcATOl1e9v4xnByQ8/H8kDNN3ahevG/X6Xq4pLq+vz74MlBG4zPAFDpcDfh8hMPIsG5yvFLkYqME=@vger.kernel.org X-Gm-Message-State: AOJu0YyoiN/6mhaK3LGbdBKwZSTw0bUfGQDRdp93M3oGZpOUFmq9PfmI fgwqHvVQblY2iDToMBoYuol340DfHk+QEEFIm1r9iZu3eAgYR7x8LBm/0J5oKUK3pHtFvHmur3S vzbQL0h8= X-Gm-Gg: Acq92OFagNWvr5zNBeZkRfTv/tZRg+xYVn28jXMDPxjSRy3lzuyXvch5AXclxYXQhz7 cf61a+RuYyswFAowvOj1H7pUr52x0b/nu5Ty64rR3P7nGPUhOFx0t3STSnisg3UfBLE1tA4Qx+M NW1xKF3pCuR8QhXgPdBSBAvnaQAAU8EVaKmyuVdT3N9w416kTPuxFpdQ1a8IWDCveTRDc91i2gg ejehViCxCsnfWxy+6XBWyH3VqyW7Qfvujzc0OEkiRFeGyN9wGlaGcY9UFpTGh7j4IHGnd2dXOFV Wd4UN1GZB/Xf92FBTdPfutQ5+KQnmO5T4zsG7QbWJ/fEKp7vaFMw71g8UkqVuVNz6f09f2AFzHf JGG9XUKNvcsXBfxt5x1hBvfw8bYDYGWgDoQ2o1mFlY8YKnUxxyZxlXajkqZsPdTE4Q6oaPiv/Or AgreKf0+O9e1jel72vCxNGE5RRX9cphGmGHIwp7HxuMcOeoMQPe/mJoi0cgbjc3LVxMWJClc5Nh m2RkaPQMMG5sPxt X-Received: by 2002:a05:6512:108d:b0:5a8:bd9c:a2e1 with SMTP id 2adb3069b0e04-5aa81c20ae9mr382484e87.2.1780588885434; Thu, 04 Jun 2026 09:01:25 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b986c42sm1298972e87.58.2026.06.04.09.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 09:01:24 -0700 (PDT) Message-ID: Date: Thu, 4 Jun 2026 19:01:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: sm8550: add SDHC4 controller node To: William Bright , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ram Boukobza , Tendai Makumire References: <20260427-sm8550-sdhc4-support-v2-1-a4241f43ecd5@imd-tec.com> From: Vladimir Zapolskiy In-Reply-To: <20260427-sm8550-sdhc4-support-v2-1-a4241f43ecd5@imd-tec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/26 14:24, William Bright wrote: > Add the SDC4 SDHCI controller node for the SM8550 SoC. > > SMMU stream ID 0x80 was sourced from the UEFI bootloader IORT tables, > as SDCC stream IDs are not documented in the register reference manual. > Unlike SDC2, the data path is routed via aggre1_noc, matching > MASTER_SDCC_4 in drivers/interconnect/qcom/sm8550.c. > > The SDHCI capabilities register on this SoC advertises SDR104 > and SDR50 but these UHS-I modes are broken on SDHC4. How do you know that these modes are broken in hardware and not caused by something else? It was stated before, but it was proven to be invalid as the statement. > Mask them via sdhci-caps-mask, this keeps the bus in HS mode, > which initialises reliably. > > Tested on the IMDT QCS8550 SBC. This board is not currently > supported in-tree. > > Co-developed-by: Tendai Makumire > Signed-off-by: Tendai Makumire > Signed-off-by: William Bright > --- > Changes in v2: > - Drop qcom,dll-config and qcom,ddr-config; these properties are not > valid for this SDC instance (Konrad Dybcio) > - Reduce the OPP table to a single 75 MHz / low_svs entry matching the > SDCC4 operating point on this SoC (Konrad Dybcio) > - Forbid SDR104/SDR50 via sdhci-caps-mask, matching the previously > existing sdhc_2 workaround in the same file. > The SDHCI capabilities register on this SoC advertises SDR50/SDR104 > modes that are broken on sdhc_4; without masking them the MMC > core selects SDR50 and fails DLL tuning with > -ETIMEDOUT during SDIO card initialisation. Which one SDIO card do you test? > - Rework the commit message to reflect the above understanding and > drop the "root cause not yet determined" note > - Drop self Tested-by tag (Konrad Dybcio) > - Link to v1: https://patch.msgid.link/20260423-sm8550-sdhc4-support-v1-1-93fd81fea5d9@imd-tec.com > > To: Bjorn Andersson > To: Konrad Dybcio > To: Rob Herring > To: Krzysztof Kozlowski > To: Conor Dooley > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 40 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 912525e9bca6..07161a873b2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -3280,6 +3280,46 @@ opp-202000000 { > }; > }; > > + sdhc_4: mmc@8844000 { > + compatible = "qcom,sm8550-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0 0x08844000 0 0x1000>; > + > + interrupts = , > + ; > + interrupt-names = "hc_irq", "pwr_irq"; > + > + clocks = <&gcc GCC_SDCC4_AHB_CLK>, > + <&gcc GCC_SDCC4_APPS_CLK>, > + <&bi_tcxo_div2>; > + clock-names = "iface", "core", "xo"; > + iommus = <&apps_smmu 0x80 0>; > + power-domains = <&rpmhpd RPMHPD_CX>; > + operating-points-v2 = <&sdhc4_opp_table>; > + > + interconnects = <&aggre1_noc MASTER_SDCC_4 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_SDCC_4 QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "sdhc-ddr", "cpu-sdhc"; > + bus-width = <4>; > + max-sd-hs-hz = <37500000>; > + dma-coherent; > + > + /* Forbid SDR104/SDR50 broken hw! */ This is copied from somewhere else, while virtually it's unconfirmed, if this SD host controller is broken or not... > + sdhci-caps-mask = <0x3 0>; > + > + status = "disabled"; > + > + sdhc4_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + }; > + }; > + > iris: video-codec@aa00000 { > compatible = "qcom,sm8550-iris"; > -- Best wishes, Vladimir