mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Andy Whitcroft <apw@canonical.com>, cocci <cocci@systeme.lip6.fr>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: prefer = {} initializations to = {0}
Date: Thu, 05 Aug 2021 11:04:15 -0700	[thread overview]
Message-ID: <e07845c0348f389756b76e34b4728a95aa48038a.camel@perches.com> (raw)
In-Reply-To: <117021b44dc9ba570a0f48736d14a267a8701d0a.camel@perches.com>

On Thu, 2021-08-05 at 05:27 -0700, Joe Perches wrote:
> On Thu, 2021-08-05 at 13:43 +0300, Dan Carpenter wrote:
> > The "= {};" style empty struct initializer is preferred over = {0}.
> > It avoids the situation where the first struct member is a pointer and
> > that generates a Sparse warning about assigning using zero instead of
> > NULL.  Also it's just nicer to look at.

Perhaps a cocci script like the below could help too:

$ cat zero_init_struct.cocci
@@
identifier name;
identifier t;
@@

	struct name t = {
-	       0
	};

@@
identifier name;
identifier t;
identifier member;
@@

	struct name t = {
	       ...,
		.member = {
-		0
		},
		...,
	};



  reply	other threads:[~2021-08-05 18:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 10:43 Dan Carpenter
2021-08-05 12:27 ` Joe Perches
2021-08-05 18:04   ` Joe Perches [this message]
2021-08-05 18:17     ` Julia Lawall
2021-08-05 18:28       ` Joe Perches
2021-08-05 18:44         ` Julia Lawall
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 13:59   ` Christophe JAILLET
2021-08-14 14:05   ` Marion & Christophe JAILLET
2021-08-14 14:38   ` Leon Romanovsky
2021-08-14 14:57     ` Al Viro
2021-08-14 15:52       ` Leon Romanovsky
2021-08-14 16:45         ` Al Viro
2021-08-14 14:44   ` Russell King (Oracle)
2021-08-14 14:52   ` Al Viro
2021-08-14 20:20     ` Christophe JAILLET
2021-08-16  6:55     ` Dan Carpenter
2021-08-16  7:23       ` Russell King (Oracle)
2021-08-16 19:05         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e07845c0348f389756b76e34b4728a95aa48038a.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®