From: Maxim Levitsky <mlevitsk@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition
Date: Wed, 23 Feb 2022 14:15:45 +0200 [thread overview]
Message-ID: <e07aedc927a03bc921980430303864f34c34621e.camel@redhat.com> (raw)
In-Reply-To: <YgaebIQH+IgsfQjf@google.com>
On Fri, 2022-02-11 at 17:35 +0000, Sean Christopherson wrote:
> On Fri, Feb 11, 2022, Paolo Bonzini wrote:
> > On 2/11/22 18:11, Sean Christopherson wrote:
> > > > + /* Process the interrupt with a vmexit. */
> > >
> > > Double spaces at the end. But I would prefer we omit the comment entirely,
> > > there is no guarantee the vCPU is in the guest or even running.
> >
> > Sure, or perhaps "process the interrupt in inject_pending_event".
>
> s/in/via?
>
> > Regarding the two spaces, it used to a pretty strict rule in the US with
> > typewriters. It helps readability of monospaced fonts
> > (https://www.cultofpedagogy.com/two-spaces-after-period/), and code is
> > mostly monospaced... But well, the title of the article says it all.
>
> Preaching to the choir, I'm a firm believer that there should always be two spaces
> after a full stop, monospace or not. Unless it's the end of a comment. :-D
>
As someone who gotten into typewritter repair hobby lately, I sure understand what you mean.
But for some reason I still use one space after period even on a typewritter and
that doesn't bother me :-)
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2022-02-23 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 11:01 [PATCH 0/3] " Paolo Bonzini
2022-02-11 11:01 ` [PATCH 1/3] KVM: SVM: extract avic_ring_doorbell Paolo Bonzini
2022-02-11 16:44 ` Sean Christopherson
2022-02-11 11:01 ` [PATCH 2/3] KVM: SVM: set IRR in svm_deliver_interrupt Paolo Bonzini
2022-02-11 16:45 ` Sean Christopherson
2022-02-11 11:01 ` [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition Paolo Bonzini
2022-02-11 17:11 ` Sean Christopherson
2022-02-11 17:28 ` Paolo Bonzini
2022-02-11 17:35 ` Sean Christopherson
2022-02-23 12:15 ` Maxim Levitsky [this message]
2022-02-23 12:16 ` [PATCH 0/3] " Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e07aedc927a03bc921980430303864f34c34621e.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®