From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdI0H1x (ORCPT ); Wed, 27 Sep 2017 03:27:53 -0400 Received: from mout.web.de ([212.227.15.4]:57160 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdI0H1v (ORCPT ); Wed, 27 Sep 2017 03:27:51 -0400 Subject: [PATCH 3/3] clk/mmp: Adjust 12 checks for null pointers From: SF Markus Elfring To: linux-clk@vger.kernel.org, Chao Xie , Michael Turquette , Stephen Boyd Cc: LKML , kernel-janitors@vger.kernel.org References: <051d7ba6-e3cc-8354-8315-93fe039dd2ce@users.sourceforge.net> Message-ID: Date: Wed, 27 Sep 2017 09:27:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <051d7ba6-e3cc-8354-8315-93fe039dd2ce@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:6u69qQGKVlitHrtUNV2bY9IUxGocesxBJTh5CNWMv66REhScFtG 7g7UbhvLCG7ktUUON6a+x/KCjw/6ROStlz0Iy5eN77I0C6XwkR546gYwjS7pF92lyH2huby xwogmQvoIAJhBXFpqf1MfBqAwZBBmEMZea3UhaKjrBEiHbNImec3NTsYzeOyGjra9nUfPOH lgtODvY48XUHmTDF+BACg== X-UI-Out-Filterresults: notjunk:1;V01:K0:SbuyqHiMem4=:tWEifPB80W/VFUHELbDfp1 fozc1sPr/YdVurTAnt6Nd3zNil72wTyXs7oA93Mx9G5C6Z6HwkiE6zYFGInP89w4r+pYhlpoo GbDHPa9xx013H2B7Jw//Q134s59Lge9KbDSZUV1WB3IpBBXBqqbNRkxmrIhFOs8dWoS6yU0I/ TeyF28YLNhPFlVHXS84LFIcvJ7LAIHIYNWrkiYWXLYh3VNn5vLI30UfmL8ss87d/qk89i362m ARBimLfkCd+NIECBiYabWIFRNLmmgU3J0X550w0iUI9jf/B4AEwg3qm84q23OOostcjsZoQHT bKV/xE5aWsmQ+EW1fXHiiRvNhP2xdnA+hpIM/CecH5nQP/EehxfyodM0WZ+KGvUsKe5fFBKvb +zQT5f+D88LbGIg+RdqVsJa0xaQ9CjjY2YCQIG9lYQRGzIt82WBPyWnV2efgZZj0RAdWcUkk0 zvEF5HwMwpH6YbzTWRuWDdLwKLtIl8cVO+a2TiiTdGggWSnbAu8qrSWU4PQNHdKAJxH/tmLSh QjF/PhiplgmtDLMXHTbMH4eA+Y2i0UMjQOacoOEa5dPiIagieCKs3I79Cjqdc6ByAynFQ8NMN 9B7iOqA0QZDk3iEo2YkzVam2NMqfU1XboXnoWrooDO1k//ynycCL4llXVGpXuLzZbW9moiHMq rPCGJYoiw7ZHzJ+4wFnxq4biUKNuvnlfRKgFUF/Eb2HQqAP84kG5zOHHaNQECfc7EFVIxSKxP hD6G//NG+6Z/9Pp2syouwwRgjbOiAOfUsfjledFsKDYI9I8dfsFIvI4dIr9UA4X1v7BGB3IJB 5HANIaDtWK2LbHXsT35PaV2k9EHdLRAN7HcdYoIQ4NPSltCIH0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 27 Sep 2017 09:00:21 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/clk/mmp/clk-mix.c | 4 ++-- drivers/clk/mmp/clk-mmp2.c | 6 +++--- drivers/clk/mmp/clk-pxa168.c | 6 +++--- drivers/clk/mmp/clk-pxa910.c | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c index b2471fb369f1..90814b2613c0 100644 --- a/drivers/clk/mmp/clk-mix.c +++ b/drivers/clk/mmp/clk-mix.c @@ -229,7 +229,7 @@ static int mmp_clk_mix_determine_rate(struct clk_hw *hw, parent_rate = clk_hw_get_rate(parent); mix_rate = parent_rate / item->divisor; gap = abs(mix_rate - req->rate); - if (parent_best == NULL || gap < gap_best) { + if (!parent_best || gap < gap_best) { parent_best = parent; parent_rate_best = parent_rate; mix_rate_best = mix_rate; @@ -247,7 +247,7 @@ static int mmp_clk_mix_determine_rate(struct clk_hw *hw, div = _get_div(mix, j); mix_rate = parent_rate / div; gap = abs(mix_rate - req->rate); - if (parent_best == NULL || gap < gap_best) { + if (!parent_best || gap < gap_best) { parent_best = parent; parent_rate_best = parent_rate; mix_rate_best = mix_rate; diff --git a/drivers/clk/mmp/clk-mmp2.c b/drivers/clk/mmp/clk-mmp2.c index 038023483b98..7460031714da 100644 --- a/drivers/clk/mmp/clk-mmp2.c +++ b/drivers/clk/mmp/clk-mmp2.c @@ -83,19 +83,19 @@ void __init mmp2_clk_init(phys_addr_t mpmu_phys, phys_addr_t apmu_phys, void __iomem *apbc_base; mpmu_base = ioremap(mpmu_phys, SZ_4K); - if (mpmu_base == NULL) { + if (!mpmu_base) { pr_err("error to ioremap MPMU base\n"); return; } apmu_base = ioremap(apmu_phys, SZ_4K); - if (apmu_base == NULL) { + if (!apmu_base) { pr_err("error to ioremap APMU base\n"); return; } apbc_base = ioremap(apbc_phys, SZ_4K); - if (apbc_base == NULL) { + if (!apbc_base) { pr_err("error to ioremap APBC base\n"); return; } diff --git a/drivers/clk/mmp/clk-pxa168.c b/drivers/clk/mmp/clk-pxa168.c index a9ef9209532a..8e2551ab8462 100644 --- a/drivers/clk/mmp/clk-pxa168.c +++ b/drivers/clk/mmp/clk-pxa168.c @@ -75,19 +75,19 @@ void __init pxa168_clk_init(phys_addr_t mpmu_phys, phys_addr_t apmu_phys, void __iomem *apbc_base; mpmu_base = ioremap(mpmu_phys, SZ_4K); - if (mpmu_base == NULL) { + if (!mpmu_base) { pr_err("error to ioremap MPMU base\n"); return; } apmu_base = ioremap(apmu_phys, SZ_4K); - if (apmu_base == NULL) { + if (!apmu_base) { pr_err("error to ioremap APMU base\n"); return; } apbc_base = ioremap(apbc_phys, SZ_4K); - if (apbc_base == NULL) { + if (!apbc_base) { pr_err("error to ioremap APBC base\n"); return; } diff --git a/drivers/clk/mmp/clk-pxa910.c b/drivers/clk/mmp/clk-pxa910.c index a520cf7702a1..7a7965141918 100644 --- a/drivers/clk/mmp/clk-pxa910.c +++ b/drivers/clk/mmp/clk-pxa910.c @@ -74,25 +74,25 @@ void __init pxa910_clk_init(phys_addr_t mpmu_phys, phys_addr_t apmu_phys, void __iomem *apbc_base; mpmu_base = ioremap(mpmu_phys, SZ_4K); - if (mpmu_base == NULL) { + if (!mpmu_base) { pr_err("error to ioremap MPMU base\n"); return; } apmu_base = ioremap(apmu_phys, SZ_4K); - if (apmu_base == NULL) { + if (!apmu_base) { pr_err("error to ioremap APMU base\n"); return; } apbcp_base = ioremap(apbcp_phys, SZ_4K); - if (apbcp_base == NULL) { + if (!apbcp_base) { pr_err("error to ioremap APBC extension base\n"); return; } apbc_base = ioremap(apbc_phys, SZ_4K); - if (apbc_base == NULL) { + if (!apbc_base) { pr_err("error to ioremap APBC base\n"); return; } -- 2.14.1