From: Johannes Berg <johannes@sipsolutions.net>
To: Jiale Yao <yaojiale02@163.com>,
"John W. Linville" <linville@tuxdriver.com>,
Daniel Drake <dsd@gentoo.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: zd1211rw: unwind failed interface additions
Date: Wed, 21 Oct 2026 12:14:26 +0200 [thread overview]
Message-ID: <e0875c5e3a36835a3d41aa99d0f4de66b721f9d3.camel@sipsolutions.net> (raw)
In-Reply-To: <20261019013211.1489233-1-yaojiale02@163.com>
On Mon, 2026-10-19 at 09:32 +0800, Jiale Yao wrote:
> zd1211rw stores the vif and interface type before programming the MAC
> and receive configuration. If that setup fails, mac80211 does not call
> remove_interface and the stale type prevents another interface from
> being added.
>
> Clear the vif and type and restore the hardware MAC state before
> returning the setup error.
This is completely crazy. "I have an LLM and it found something that
doesn't make sense to it" is not a reason to send a patch.
Does this actually matter at all? This driver only supports a single
interface anyway - who cares about the hardware state when it's going to
be shut down right away?!
johannes
prev parent reply other threads:[~2026-10-21 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 1:32 Jiale Yao
2026-10-21 10:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0875c5e3a36835a3d41aa99d0f4de66b721f9d3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®