From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757337AbcH3Ta6 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 15:30:58 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:60359 "EHLO
        devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752656AbcH3Taz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 15:30:55 -0400
Subject: Re: [PATCH v11 2/4] tee: generic TEE subsystem
To: Jens Wiklander <jens.wiklander@linaro.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>
References: <1471870856-18684-1-git-send-email-jens.wiklander@linaro.org>
 <1471870856-18684-3-git-send-email-jens.wiklander@linaro.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Al Viro <viro@ZenIV.linux.org.uk>, <valentin.manea@huawei.com>,
        <jean-michel.delorme@st.com>, <emmanuel.michel@st.com>,
        <javier@javigon.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>, Will Deacon <will.deacon@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Nishanth Menon <nm@ti.com>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <e08f821b-bf7c-be65-59a5-281aa3343cf4@ti.com>
Date: Tue, 30 Aug 2016 14:29:45 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1471870856-18684-3-git-send-email-jens.wiklander@linaro.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/22/2016 08:00 AM, Jens Wiklander wrote:
> +/*
> + * Unprivileged devices in the in the lower half range and privileged

                                ^^ in the in the
[snip]

> +
> +	rc = alloc_chrdev_region(&tee_devt, 0, TEE_NUM_DEVICES, "tee");
> +	if (rc < 0) {

if (rc) ?

[snip]

> + * Memory allocated as global shared memory is automatically freed when the
> + * TEE file pointer is closed. The @flags field uses the bits defined by
> + * TEE_SHM_* above. TEE_SHM_MAPPED must currently always be set. If

             ^^^ not really above anymore, out of file now looks like

> + * TEE_SHM_DMA_BUF global shared memory will be allocated and associated
> + * with a dma-buf handle, else driver private memory.
> + *
> + * @returns a pointer to 'struct tee_shm'

Doesn't say anything, is this really needed?

[snip]

> +/**
> + * struct tee_shm_pool_mem_info - holds information needed to create a shared
> + * memory pool
> + * @vaddr:	Virtual address of start of pool
> + * @paddr:	Physical address of start of pool
> + * @size:	Size in bytes of the pool
> + */
> +struct tee_shm_pool_mem_info {
> +	unsigned long vaddr;
> +	unsigned long paddr;

phys_addr_t paddr; ?