From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC7F7111BF for ; Sat, 26 Jul 2025 02:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753497051; cv=none; b=qKTNsKlZBAZaDkHCAb3CjQon/037eF2+GkRlGFTgqJTlahmzJFCHHOBCiPwEE3IFAfNM76S2cMRcIG/Y2LtvRWcV0dYru0rZOErN7tL/XTUoEKoKmBb5HikdPPb6drfhgmXmMWDDiKLPn5i7ikSjei8crwyog+mjZT23NRX0CSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753497051; c=relaxed/simple; bh=PrB+/5kXEKvBjOpKUYDtWccK3RIutOjFaivwM+A4O0E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iDpOQf/VskHyFvZVfA3IMHOVRLjsMTo9VbyBgrKxotLkN7zTQMiuwk4V9iaMukUeDMdKMWBT0QTuBaPX7TkLLuLhIBJUj/EAHTygSNIj/Fc1wQ0afy7euFUFKSwEGQXs7IpfckJeKTB68JBQjZ4Sv8B2lEHWaW5PfjE8D0ytBeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=MN6oiadE; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="MN6oiadE" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-234c5b57557so23931965ad.3 for ; Fri, 25 Jul 2025 19:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1753497049; x=1754101849; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y3+KGsMghJpTUkFMQc31Znzw1BhSHIhxJP3A9H3lNJA=; b=MN6oiadEtROBEKnVkGH2oYiqnQsJWsqwwAj5pNXIgniJI5wiEHkqjTjPMky1UogXr9 soMl2e/ZFxbBiw/+SYP0+hTenCNd/PWEBNaefRKhMBO2Z3QAf7idZuN3Jq0LozYEJmcu sC3AEHSV6M00PCjYp6f7Ec6IUEGTh4IGQ6uo4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753497049; x=1754101849; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y3+KGsMghJpTUkFMQc31Znzw1BhSHIhxJP3A9H3lNJA=; b=efnN70aZ/Dh4Q4AifSyr927q6hy1LLfE0vKSEkiLbVNFViOFLN75fR4Y9pDaBKE1xS mhlA2o/YmXRPnnKQxK2cXwxC0/kZ5WedChiXHOdlvAUrsAWbLFXOEsCYXiv0iRyr8mfU RzijZ2PKcjZPza97N/bx9LNiVvcIbiXTRds2m8QMRnHb4h85GEptTlSNPMgX/A0Hu0+z ZmIK1R347BQhxlyYtCvPwJH8xISBq0AHx/m4E24BROf+X+RyloI1JHSU5jgRJ7qvCL5w cjiy9sVUxcQcXEku2A3+DL5AcgC3MXLWEJJ7DYdyqb6OUpiz/c5wrlF5qO9OjR7FBMzs ZVNQ== X-Forwarded-Encrypted: i=1; AJvYcCV8h0JLJ+HpFoBirTJ3zQaDoiFx8Ht/4VY0cPcVMXgBhvpqTkP9domsmu6RrsOr9YI5FdqS8VCHnRvy6nE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxpqd8/NoaUhKmhrI37IHodBljnX3AHrUpl44W8/FEae/nd4Ea rUI0mVffasUU5hj+S9fTMMt7l+8wF0wOuv7unC5aQXxcmTy7OV6f8MU98USjOvr6UA== X-Gm-Gg: ASbGncuSVr8ua+/7WincpgoTBN3v8M3WA5TY/PUcN54rJ/XQZL2UMatzr3gnQQEMKSj hWX//99Hd/J9kfC58FEcIHmpDOlOZywZ0zhzGH+V1JjNEEbrYPl2Cl8G1pTZXfh8Z77FKigHH7O U5OsoqAG8lyrY8PYUdnlS21FdLqOlWuICm9MbrU5KwTsI30LyxjEDZ5PAC9ez6jOqOaW+oe5mqF Y+TC7tNJlCBQQBHyCUnuTu5r5NbvpnuUoMJSPH+XheiyEW3nKbY8AlPwOoGi8b2SHMImsE0YlXG CfaPasPipIzAJiUbzNJuYzS4Qh+aB8dHhiAk4hkO77tRTE5hJQ3ASBF2yCEgIS6s0cNHxgh3roC YdsEceo+Y6a87fIA/ZhLVgS7fXt/gFkZOO+tvEIiinCijI8DSaywQVJ7OgdE3oeTtIgtnUgAamM 2Y X-Google-Smtp-Source: AGHT+IEUV7d23IGgMtmQ3cEgGJbMNQ82jTYnOVq/TKDZgn6psUNuW6A5cdFh9rjwTn/TWXARN1DgEw== X-Received: by 2002:a17:902:e94d:b0:23e:3164:2bf1 with SMTP id d9443c01a7336-23fb3148736mr63550725ad.53.1753497049156; Fri, 25 Jul 2025 19:30:49 -0700 (PDT) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fbe4fd676sm7014385ad.87.2025.07.25.19.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jul 2025 19:30:48 -0700 (PDT) Message-ID: Date: Fri, 25 Jul 2025 19:30:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: phy: realtek: Reset after clock enable To: Sebastian Reichel , "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Detlev Casanova , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, stable@vger.kernel.org References: <20250724-phy-realtek-clock-fix-v2-1-ae53e341afb7@kernel.org> Content-Language: en-US From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/2025 7:21 PM, Sebastian Reichel wrote: > Hi, > > On Thu, Jul 24, 2025 at 05:51:58PM +0100, Russell King (Oracle) wrote: >> On Thu, Jul 24, 2025 at 04:39:42PM +0200, Sebastian Reichel wrote: >>> On Radxa ROCK 4D boards we are seeing some issues with PHY detection and >>> stability (e.g. link loss or not capable of transceiving packages) after >>> new board revisions switched from a dedicated crystal to providing the >>> 25 MHz PHY input clock from the SoC instead. >>> >>> This board is using a RTL8211F PHY, which is connected to an always-on >>> regulator. Unfortunately the datasheet does not explicitly mention the >>> power-up sequence regarding the clock, but it seems to assume that the >>> clock is always-on (i.e. dedicated crystal). >>> >>> By doing an explicit reset after enabling the clock, the issue on the >>> boards could no longer be observed. >>> >>> Note, that the RK3576 SoC used by the ROCK 4D board does not yet >>> support system level PM, so the resume path has not been tested. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 7300c9b574cc ("net: phy: realtek: Add optional external PHY clock") >>> Signed-off-by: Sebastian Reichel >>> --- >>> Changes in v2: >>> - Switch to PHY_RST_AFTER_CLK_EN + phy_reset_after_clk_enable(); the >>> API is so far only used by the freescale/NXP MAC driver and does >>> not seem to be written for usage from within the PHY driver, but >>> I also don't see a good reason not to use it. >>> - Also reset after re-enabling the clock in rtl821x_resume() >>> - Link to v1: https://lore.kernel.org/r/20250704-phy-realtek-clock-fix-v1-1-63b33d204537@kernel.org >>> --- >>> drivers/net/phy/realtek/realtek_main.c | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c >>> index c3dcb62574303374666b46a454cd4e10de455d24..cf128af0ec0c778262d70d6dc4524d06cbfccf1f 100644 >>> --- a/drivers/net/phy/realtek/realtek_main.c >>> +++ b/drivers/net/phy/realtek/realtek_main.c >>> @@ -230,6 +230,7 @@ static int rtl821x_probe(struct phy_device *phydev) >>> if (IS_ERR(priv->clk)) >>> return dev_err_probe(dev, PTR_ERR(priv->clk), >>> "failed to get phy clock\n"); >>> + phy_reset_after_clk_enable(phydev); >> >> Should this depend on priv->clk existing? >> >>> >>> ret = phy_read_paged(phydev, RTL8211F_PHYCR_PAGE, RTL8211F_PHYCR1); >>> if (ret < 0) >>> @@ -627,8 +628,10 @@ static int rtl821x_resume(struct phy_device *phydev) >>> struct rtl821x_priv *priv = phydev->priv; >>> int ret; >>> >>> - if (!phydev->wol_enabled) >>> + if (!phydev->wol_enabled) { >>> clk_prepare_enable(priv->clk); >>> + phy_reset_after_clk_enable(phydev); >> >> Should this depend on priv->clk existing? >> >> I'm thinking about platforms such as Jetson Xavier NX, which I >> believe uses a crystal, and doesn't appear to suffer from any >> problems. > > Doing the extra reset should not hurt, but I can add it to speed up > PHY initialization on systems with an always-on clock source. I will > send a PATCHv3. Assuming the PHY DT node is tagged with "always-on" then one might reasonably expect it to be used for Wake-on-LAN and that it should be able to register itself as the wake-up source. If we pulse the reset we might lose the details of the wake-up event within the PHY. So yes, being able to deal with that and doing the reset conditionally might be preferable. -- Florian