From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 08C9D419FCC for ; Thu, 30 Jul 2026 11:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411726; cv=none; b=ompKpE4JWoiAQ09yh5X1oKTwqp+Ws7ezgIOQyOHLLQTkOnBPq+GPWttfMwZp8Jv3/SCZvWDJZPIUpqcv7x53ijhQBJ4A1e1DPL1SDenlkvdjQzY0rmkWICcgjOtN7McylLKOCRtbTD2K5IfZh+9y0H4114lNJVVjEKxVmRqOKo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411726; c=relaxed/simple; bh=GWKxVBmk/3OJM7zFLMXgOeSR5EPxu/L2awcWvhPKBNc=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=mM+gvmDrEYTv9TdVIFMkfcxyKMcGcJVF2dZhoHikaPdK5A9IH0cyN5D/rBFAvP7zD1xLJzVP6rzdxMOTtgqHlw862IOLM0UqgUSvdFB3YoLRs55+2AiptcLqfDJ+DY2CyvYFM0ihUh6vy+tO3h6uqF1acOu8FWCKPU3Gyn8V3ls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=H1Gbg5PE; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="H1Gbg5PE" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B9791684; Thu, 30 Jul 2026 04:41:57 -0700 (PDT) Received: from [10.2.198.93] (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9EC83F763; Thu, 30 Jul 2026 04:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785411721; bh=GWKxVBmk/3OJM7zFLMXgOeSR5EPxu/L2awcWvhPKBNc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=H1Gbg5PEEA8RfVYqh+JrU7GcC0XeT11ZBcXomHbtz9Xevp7Jp19CVznkQliO5hu4Z U3mTfHjiUdlQ940dq7P9VBP9dStAXd0tFYEZDGE4BS4qLaIvslODSeTET8TrsRMjlw eUfL/89J/usdRkF4ddRgTj7fnb5o4l2XdCSr5SBo= Message-ID: Date: Thu, 30 Jul 2026 12:41:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Pu Lehui Subject: Re: [PATCH] mm: use proper PTE accessor in move_ptes() To: Alexander Gordeev , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260720141633.501799-1-agordeev@linux.ibm.com> Content-Language: en-US From: Usama Anjum In-Reply-To: <20260720141633.501799-1-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/07/2026 3:16 pm, Alexander Gordeev wrote: > Follow the pattern established by commit c33c794828f2 > ("mm: ptep_get() conversion") and use the proper PTE > accessor instead of a direct pointer dereference. > > Fixes: b36b701bbcd9 ("mm: expose abnormal new_pte during move_ptes") > Signed-off-by: Alexander Gordeev > --- > mm/mremap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index 0dfe3de39ccc..e99b19a9850b 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -264,7 +264,7 @@ static int move_ptes(struct pagetable_move_control *pmc, > > for (; old_addr < old_end; old_ptep += nr_ptes, old_addr += nr_ptes * PAGE_SIZE, > new_ptep += nr_ptes, new_addr += nr_ptes * PAGE_SIZE) { > - VM_WARN_ON_ONCE(!pte_none(*new_ptep)); > + VM_WARN_ON_ONCE(!pte_none(ptep_get(new_ptep))); I'd the same patch in my RFC branch. Hence: Reviewed-by: Muhammad Usama Anjum > > nr_ptes = 1; > max_nr_ptes = (old_end - old_addr) >> PAGE_SHIFT;