From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E72C77B73 for ; Tue, 6 Jun 2023 07:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235940AbjFFHLh (ORCPT ); Tue, 6 Jun 2023 03:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235886AbjFFHLX (ORCPT ); Tue, 6 Jun 2023 03:11:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92DBFE53 for ; Tue, 6 Jun 2023 00:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686035433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=znzcZh/FoBR70IAi4uiesl3ajaljXIGrrB/hgdSvA54=; b=JiqCwCeV8e+DX6iBmnABfPAg+blYgisGEt/5fvrSVfwBsnJTzkd6pM3wAp54qhcwje8+m8 W90T8MyLZQTYieCpM52L7n23U6dBM5ZbGgTVZ4fgaMiZys5D0/xuXJvZlr3vf6lqLrBIIm 6RaHqvg7qDQ4qheW9VY6n8zesgWguW4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56--G6bUDrXPCqlrqEvT_AZ2A-1; Tue, 06 Jun 2023 03:10:32 -0400 X-MC-Unique: -G6bUDrXPCqlrqEvT_AZ2A-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f6089a9689so33877585e9.1 for ; Tue, 06 Jun 2023 00:10:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686035431; x=1688627431; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=znzcZh/FoBR70IAi4uiesl3ajaljXIGrrB/hgdSvA54=; b=jR9s6/fI+N6o0U1rwcbuwElzobATsj6Cptror3JCKZaykiWnb79JfC/gmdPW3OpRnw ZMgTjjEuqPX9vEWKq4WLVW2byRlXXTCZydc1TBTmGCMT3FjBEi74RqcIKjpI1nc3j1yW fjgbMfSUVpn3H1QINsAaRHVWEcPZ2DIAtBFQ3aTqvnMuP7vyfyGhKcWoNUcDuCtEKCDn 8EMKTsPk3EPlzAdb1osFT913OlHUyz+7SCWiN02/AviuIVc+gQv0uYe0nUjdy/gKrWNr laDa22mc5dSzUAYQyeOL5zOzAfys+WkxBBABnMgQKND4k8kt9i23SJk3Fq9l70TJ4aTH UqIg== X-Gm-Message-State: AC+VfDw8rVVZfkkopmmphu9pvrwPvPUo7wwXa3fAV82YSrDIuEFYY7EI kfMNnUljCBziHr1dwsuasTZsMleUCpFWizZVDlOeljzbHOWvMWytJ3LYNcRBkr1RBAwJd0xq+Hb ZUu3cx8bw1dHv+dDuFvGsFpxz X-Received: by 2002:a7b:c302:0:b0:3f7:2d79:9edf with SMTP id k2-20020a7bc302000000b003f72d799edfmr1228118wmj.7.1686035431312; Tue, 06 Jun 2023 00:10:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Ei1Gu9cG306mrOCZa5KgbLIesll7Akod2t7m1Y5/w4jJYTazc5TJRd+GgF71Pteor29xSSQ== X-Received: by 2002:a7b:c302:0:b0:3f7:2d79:9edf with SMTP id k2-20020a7bc302000000b003f72d799edfmr1228091wmj.7.1686035430963; Tue, 06 Jun 2023 00:10:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:d100:ce7e:d566:43f8:2b24? (p200300cbc709d100ce7ed56643f82b24.dip0.t-ipconnect.de. [2003:cb:c709:d100:ce7e:d566:43f8:2b24]) by smtp.gmail.com with ESMTPSA id r1-20020a5d52c1000000b0030ae69920c9sm11651633wrv.53.2023.06.06.00.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 00:10:26 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 09:10:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test for FOLL_LONGTERM To: John Hubbard , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Lorenzo Stoakes , Jens Axboe , Peter Xu , Jason Gunthorpe , Jan Kara References: <20230519102723.185721-1-david@redhat.com> <20230519102723.185721-3-david@redhat.com> Content-Language: en-US From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.06.23 08:23, John Hubbard wrote: > On 5/19/23 03:27, David Hildenbrand wrote: > ... >> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile >> index 23af4633f0f4..95acb099315e 100644 >> --- a/tools/testing/selftests/mm/Makefile >> +++ b/tools/testing/selftests/mm/Makefile >> @@ -34,6 +34,7 @@ LDLIBS = -lrt -lpthread >> >> TEST_GEN_PROGS = cow >> TEST_GEN_PROGS += compaction_test >> +TEST_GEN_PROGS += gup_longterm > > Hi David, > > Peter Xu just pointed out that we need a .gitignore entry for > gup_longterm [1]. That logically belongs in this patch, I think. Yes, although I don't care if it's in a follow-up patch (we're talking testcases after all). @Andrew can you include that hunk in that patch or do you want a resend? -- Cheers, David / dhildenb