From: "Arnd Bergmann" <arnd@arndb.de>
To: "chris.chenfeiyang" <chris.chenfeiyang@gmail.com>,
"Willy Tarreau" <w@1wt.eu>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: "Feiyang Chen" <chenfeiyang@loongson.cn>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available
Date: Wed, 08 Feb 2023 11:39:23 +0100 [thread overview]
Message-ID: <e09b458a-32bf-46aa-b509-a383e34d4888@app.fastmail.com> (raw)
In-Reply-To: <b9bbf73286238bb4657d855c9d50983aa17953e2.1675851111.git.chenfeiyang@loongson.cn>
On Wed, Feb 8, 2023, at 11:17, chris.chenfeiyang@gmail.com wrote:
> From: Feiyang Chen <chenfeiyang@loongson.cn>
>
> loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> openrisc have statx() and stat64() but not stat() or newstat().
> Add statx() and make stat() rely on statx() to make them happy.
> +#ifdef __NR_statx
> +static __attribute__((unused))
> +int sys_stat(const char *path, struct stat *buf)
> +{
The actual #ifdef check here does what I had suggested first, using
statx() for all architectures, rather than what you describe in the
changelog. I think you should keep the check from the first version,
testing for __NR_stat/__NR_newfstatat and keep the changelog text
here. Also please add something about the possibility of using statx()
everywhere in the future.
Arnd
next prev parent reply other threads:[~2023-02-08 10:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 10:17 [PATCH v2 0/5] Add LoongArch support to nolibc chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 1/5] tools/nolibc: Include linux/fcntl.h and remove duplicate code chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available chris.chenfeiyang
2023-02-08 10:39 ` Arnd Bergmann [this message]
2023-02-09 2:06 ` Feiyang Chen
2023-02-08 10:39 ` Willy Tarreau
2023-02-09 2:02 ` Feiyang Chen
2023-02-08 11:00 ` Huacai Chen
2023-02-09 2:25 ` Feiyang Chen
2023-02-08 22:39 ` David Laight
2023-02-09 2:14 ` Feiyang Chen
2023-02-08 10:17 ` [PATCH v2 3/5] tools/nolibc: Add support for LoongArch chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 4/5] selftests/nolibc: " chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 5/5] selftests/nolibc: Adjust indentation for Makefile chris.chenfeiyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e09b458a-32bf-46aa-b509-a383e34d4888@app.fastmail.com \
--to=arnd@arndb.de \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chris.chenfeiyang@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®