Re: [PATCH v5 1/3] KVM: x86: Refactor suppress EOI broadcast logic

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Mon, 2025-12-29 at 11:17 +0000, Khushit Shah wrote:
> Extract the suppress EOI broadcast (Directed EOI) logic into helper
> functions and move the check from kvm_ioapic_update_eoi_one() to
> kvm_ioapic_update_eoi() (required for a later patch). Prepare
> kvm_ioapic_send_eoi() to honor Suppress EOI Broadcast in split IRQCHIP
> mode.
> 
> Introduce two helper functions:
> - kvm_lapic_advertise_suppress_eoi_broadcast(): determines whether KVM
>   should advertise Suppress EOI Broadcast support to the guest
> - kvm_lapic_respect_suppress_eoi_broadcast(): determines whether KVM should
>   honor the guest's request to suppress EOI broadcasts
> 
> This refactoring prepares for I/O APIC version 0x20 support and userspace
> control of suppress EOI broadcast behavior.
> 
> Signed-off-by: Khushit Shah <khushit.shah@nutanix.com>

Looks good to me, thanks for pushing this through to completion!


Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>

Nit: Ideally I would would prefer to see an explicit 'no functional
change intended' and a reference to commit 0bcc3fb95b97a.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]