From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E3A9238166 for ; Mon, 1 Dec 2025 06:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764571757; cv=none; b=OBty7RaiFDWcAawrlciWlMqDRb3a5m6G6tXzgVGbGiGntWm4QqsZDT8cR2eRlHzsHVg8DQEXJYxmGfkj0bYtu98RUOMSOKW49iLCyik+hVV4vB7iosFsqQ/x43n1P7mplOF4MPJA0IXn+0t2gbyk8fzDfGHidTP5D/UKhklDjio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764571757; c=relaxed/simple; bh=E7OjqbqS+4mGY4npTVkgGtLx+Z0bKn4/PegCW8SEls0=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=be8vWhIOXzFw5Wt9InGEtLnipzTLvMXuxxp4W+sCUm0VZ9UuV1G17JSa8JYTHUJpW3ELenPl5YJzYPMRz1/9IwuMmuAGjmJCKtPWX7HuLUgMv1uoQYehHRL3gY2nJVjgS3tsuOAKO0AKBBBlZvHOJuMj9SuIWZ7whaBN1GL4fCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oR47m0iw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DnuTBIHe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oR47m0iw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DnuTBIHe" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AUMnQJk3195103 for ; Mon, 1 Dec 2025 06:49:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gemHNmwMJPMQ6RzPW/H1gwr513AnLQz12AEpe511/UA=; b=oR47m0iwZztUqCg3 ZgmZBRYLQGhZsQEIaiOZDyg1BY6nHFyXX0fXmM6trez5o34qzpJBPEkTeYSf0eaf 96uP7pgUu+RO1K2Ok8UbmBhv4H39MA9DcFIXob4bXFpPX/PgYcio12ypiBkU1EoU VwabeZ+GYHrQpyKsHOAjPQqAoDnILsni7FjRfDTynyf7pMrGp48c38KxxfSqxItf aRqAwW5CSOeZUdFnEBnhpDFiGZ264O5y42lWmdPqkO4xfCU2B66T8WaxL+C9En1h D22DDBL4Q6w39kD8hNZJjywl1nuKEZ9GVMiJNGIxKlENI2lhPbd672IYoGCQhpcS XQHjcQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqrdykrka-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 06:49:14 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2956a694b47so49383835ad.1 for ; Sun, 30 Nov 2025 22:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764571754; x=1765176554; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=gemHNmwMJPMQ6RzPW/H1gwr513AnLQz12AEpe511/UA=; b=DnuTBIHeZudZ3ahhskYrd7YAyaRLB/WzZI8KWs0TpmsW7mnsTw80O5n+vjGNty2tYq m9ObIg+J96wcVBdoKuW3eGdKJZxCkZnaW3CqJ5C6KoeW3Lwq/1jWjNc6Eqa4njGd2oLk H6pxCW3LPzRFu9xXC6YqCTnGCnqjRG+foikcaXWiyZdtYLKEn50TFgh11Z6CHEzmooDq dFe5hIo05xMx6WIpcnPWZMyBE30MNBy9dx5bYiPbaKVUYw1Hj1Nrfeq8F+6VubwmzR0b BQ6gKTxDBA6r+SkieMze2Bd3+LYvORqy34/Xij+EbgOVB1Q+IYhJeRbab2MRYv/fMhXx sFHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764571754; x=1765176554; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gemHNmwMJPMQ6RzPW/H1gwr513AnLQz12AEpe511/UA=; b=SkiK0eu2um+ZAINT3zDeo+I/OdpU2qdEZugRvS3PAAwl4i5Gz7F7ns9f+U9rY5NmHP zLRCuhnOGgw1hYYKJW14NF2m/h8roJZEXZuIvDrcI+5SFNfu9tB2RdXufPc9lw35Dxb6 +9yI8QcMbcqDbvJefnh1SBqJ1yP2xCIP/yEDW2K1PJRZwMRxPS19rHxVBQxZ3wugGUJV +ekBhGLYfB2RpOaXPua7WrebwfIVCc2BCWyIF/4mfKzWIv+DyCHRpUIT4Oz+92YJfw5h xhUZKJrVQC5vr8rquRhYKBomBpmxDz+zirGB5NMmYiGmbZ2YgZZ+glEeEhy7AjnsPRhF 50cA== X-Forwarded-Encrypted: i=1; AJvYcCU9Gm08uoS5bRvdOY7BEtygP58IfUFwcNCYZkg44V7lXG4fc7SgSGY+KWm1e1KfIXIFP2uSv6xUS3BcvMA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8hVU2e1jVT/ZgqSm6DMAuSP/x6lDLZc48DfazRvLNAS7dAQ+o gI0/bVK6OpNXGcJIchDvXxTnbFQczGgnByjBFqX5Vt/pxEipiBuk/+ga5+XP+H4jmeYIeeB3zKE c+6SuTsKktyAsH8aDEtdHYuvXu19r6QE+lFkT8BzYuiri8W5PkihRnEhApJg73DGWr4gDgEr47v o= X-Gm-Gg: ASbGncu6Wc88C8snI6EEBEuDUhVyO2U3bHxe7O6Ne3yoF0hsZEAgkB5g0ZrPZTU4s6u TfQonYsB8/evunn2Zm4P7q67Hd8T9epTAbntdB9+sriFLz+e1h78pPl9s6cf0MuesXn3wwUrG5a KUgvx+3i8Ni4guq+kV0IQ/aYd6ogXJOMUI5mHPGB9BSIzxnJ0K0KMDlBagRle6ytUjmw4l/BNT0 67z+mCVqx12gCGL5r5NklnICVj9tSbrkk/iOm1Kz8ga2hyROVbqQ9vgWTELliOoh+AVeHR1976V b5lSICy6DshWrk17nvNGMe4vS1Jhpe2KU5HXjcs9J3ow5wqO4+vp87dWTACDq4YZ3h3aW64++sK OENBcJ8zKAoPyBfUcoiMr+odMXQA0KnP9wHdPDw== X-Received: by 2002:a17:902:daca:b0:295:59ef:df96 with SMTP id d9443c01a7336-29baaf8aa2fmr238442015ad.13.1764571753606; Sun, 30 Nov 2025 22:49:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIipze7/wBgcpTJG7Vd1ABhMvxy6/K9lj4c34zLYEkFy9oY3AG+6j5+ogR9LQTyz7j/Ytkzw== X-Received: by 2002:a17:902:daca:b0:295:59ef:df96 with SMTP id d9443c01a7336-29baaf8aa2fmr238441685ad.13.1764571752937; Sun, 30 Nov 2025 22:49:12 -0800 (PST) Received: from [192.168.29.77] ([49.37.155.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce40acbbsm114608055ad.11.2025.11.30.22.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Nov 2025 22:49:12 -0800 (PST) Subject: Re: [PATCH v2] mmc: host: sdhci-msm: Add support for wrapped keys To: Eric Biggers Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, abel.vesa@linaro.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251127073048.2759159-1-neeraj.soni@oss.qualcomm.com> <20251128175559.GA2000@sol> From: Neeraj Soni Message-ID: Date: Mon, 1 Dec 2025 12:19:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20251128175559.GA2000@sol> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xvJ38pFXgm0u7PoUeX6Q9L1QvX1FikxH X-Proofpoint-ORIG-GUID: xvJ38pFXgm0u7PoUeX6Q9L1QvX1FikxH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDA1MyBTYWx0ZWRfXz5cK5Xxv5bjV /1IBhscKqMrFB2O20FIdzXayK9PxlIF/bX9Z2ivoi062Myyy5rUtDeN7OgOpizm6KlLFBDGae7x rgRHhie25l8Txq+klbuJBOOlz7Gn8WXpJuXKzI8HvauhKsaFWuMmteKA26gJf5e/zfvSOdVBAuP 6hWhDrReoabvni5EJR0AK4BauV+V+U+hQRD3CtWQlY7Ct1yV8ybj+tSbuBx1ulGBLyUySIPlUVN sPekiUcoBbJCxsJYCDKsxIwHutaixGRrYcKz8qnUw1ZQsWu2PWUXG0IDCjNbAVUzVCihGoBf6Ou smsmytBAWe4x7I+2izmvpkOnbJqHT/tOhjGaC+h0jZ5UFk3onhdyiP89aYNr+2NPqmxbnMMoFLv PBOQpdacsuz5u6P86HJN7N3EW4yhpA== X-Authority-Analysis: v=2.4 cv=ed0wvrEH c=1 sm=1 tr=0 ts=692d3a6a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=qKc52UxUbR90Cc+7RLwjqg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=90dgnz13A4KOmbfFnlkA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010053 Hi, On 11/28/2025 11:25 PM, Eric Biggers wrote: > On Thu, Nov 27, 2025 at 01:00:48PM +0530, Neeraj Soni wrote: >> Add the wrapped key support for sdhci-msm by implementing the needed >> methods in struct blk_crypto_ll_ops and setting the appropriate flag in >> blk_crypto_profile::key_types_supported. >> >> --- >> This is a reworked version of the patchset >> https://lore.kernel.org/all/20241101031539.13285-1-quic_spuppala@quicinc.com/ >> that was sent by Seshu Madhavi Puppala. >> >> My changes rebase it to use the custom crypto profile support. >> >> Signed-off-by: Neeraj Soni > > Your Signed-off-by should go above the scissors line (---). Thanks for pointing out. I will fix it in next patch. > >> Changes in v2: >> - Updated commit message for clarity. >> >> Changes in v1: >> - Added initial support for wrapped keys. >> --- >> drivers/mmc/host/sdhci-msm.c | 51 +++++++++++++++++++++++++++++++----- >> 1 file changed, 45 insertions(+), 6 deletions(-) > > Otherwise the patch looks okay to me. It lines up with the UFS > equivalent. Can you also provide details on how you tested it? Sure. I tested it on sc7280 (kodiak) eMMC device and will capture the test steps in next patch. > > - Eric > Regards Neeraj