From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B2C221DB6 for ; Wed, 22 Jul 2026 07:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784703843; cv=none; b=Fqes9StNyMe+DQ20mOC1055t5QN3iom2vz8rl1PdoRi/utOpv/MDbd/dIIZp0eUfnvnQhmvthFv6qF4QV0R0rkTNQJlR6D3DqulMOfGY3v1WoNXXjaDhdqNDFbN8iX48DNo7dzkjX3GSuNELj8IB5gX5EgHqatoVzqsedTGKJc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784703843; c=relaxed/simple; bh=k9qZW9UhONzZxPEWo8ci0GdlJAaM76cmpUULCTtHNas=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c8e0WjgJOJLPmjAr9lOEeZpH/7/2xOyYjjG+7LU/XeI8QkwwppdMaTtFA1NM6RK5Kxw7/6eXpVFc63AYUg5JZfmGkEJ24LIV1BEjnHWiXk99KrjeV0EaFHyeyHpxZV/IzqIssplOZ6tqFqqFzZvKVxU1FhN22gjM9fVmTvdkuJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nWRoQMTY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MCldnt/Y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nWRoQMTY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MCldnt/Y" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M53kvc3767770 for ; Wed, 22 Jul 2026 07:04:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1PGM/fNkKCMnOQV4wTPTHzuEafbmKBg3WAOkdVHmfKo=; b=nWRoQMTYs/cku+nz dDam3QxiUWU4k+P0jhM/7KbXQnFZSGTcvPkF2TcFrUeDhGaqQZzm2CBHmnUecn/L Ypx9bq7qu82z6ZUXIG8Fpd/Bcztd1DsPsxEorb01aRzuP9tD7toi+iWJWcKvXC/f WzYUgzpMhX+NIcY0yFR7CKtzz1BH1GrpjHiPkbHeDYA7vn0OGMP7gzC7rUMFpX6b FCCATujiyaDdzqXgB6LTPVJjF3Kd/mKpiEhDXnoPaBAOFfdII2fCkHOPbc6TSE+l LgGV0LwZ1sFNJQ1QSEhOrzVCCoBexkC1/B0SVVYyTGDtmJA7EIZ0bH2pktBr7D7R Bs8T6g== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjnu4rs2s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 07:04:00 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-848544a8496so9848191b3a.0 for ; Wed, 22 Jul 2026 00:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784703840; x=1785308640; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1PGM/fNkKCMnOQV4wTPTHzuEafbmKBg3WAOkdVHmfKo=; b=MCldnt/Y+vGkWUg6PKPvE+7Ow2o3nycAtt9xN7y/6kgwPCf923B3jyA0WMeDGBkR9K Nwu/TUp05t4rwnZntBGUQ/UxdbJ1fQSTp9rTKN+p4Kz9ABGObjTHJnskfQnoXD9KIYOI rCgKXNDguy1dXLwY+HxZGjnAhfA0DDRoW4CnQHNJsXuF1w3XGJ1EMsU/HYhYMJV8nSMZ XpzNUYej+jGM42Ft/S/DlWK3oAmHTXkanjdFOQxmIYn5txopb76S94OGyxHfHGWKVr6v 2D+frPZRRODDfnafH3dKiBwfCm8NQ9zA2omR9I7/JL83eHphPvE0xgOydwsVrCbWee1h wogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784703840; x=1785308640; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1PGM/fNkKCMnOQV4wTPTHzuEafbmKBg3WAOkdVHmfKo=; b=soMyMxlUx0d6/0oaA9IRnqZ6DFTxYqyRWq5b1OcudscuDiVQwuy5CYbuEiaYlJJCqb XUVkOmwCknn9CeY7w8V2BKKedGSR32rrEyIK/FLTpvwbhO88wyw72c6qpIPLNx85HoT1 asVQbEVcpfgTNjs3gDieKx34inNBx2gCd43UgwzqFivUjK0MRHrjXe4lJSkkoNYP7Xqc /G/bd+OZxaxBnnX/wboiwVwRoQCQGtIcbYlwF0LXBWXzw0ZPLYLbvGj4+zN/yGTW9VJ9 OLqJHPfddjhL9c+zcfbqCW8J3Qx+WAdsfNt8BYQBndQ5Hd4zuqY151ofRAQIu8PY6hOG J/2g== X-Forwarded-Encrypted: i=1; AHgh+RrDD2FS4CHAcn7gg3O1eXaV7sfeoGHfsvx4qrWlRaty13fPUj/cJ1ZSH/QPwIeI/1YTXU/sV3J08CaR8Zw=@vger.kernel.org X-Gm-Message-State: AOJu0YyAWVgfh2+8G7RK7hZuxiA8QyiDscxCRHTOzpaUwiYiNpjEwmKs 6Yw1TqhRq3fe+7E64WcAtfzcCCe3Tht3wa+WHQr4rgnX1OxYQbZMDnkFZWyBi08vrFqJyGxjpvx 6mkChD7swCh32eUpibic9GG54iYs4v9GfoeN3F9Zt9ZPCNJo9BdcN3KxZSkAtoJHJ3tc= X-Gm-Gg: AR+sD11ukS++PQcuklFU+OpOMyRH+0a/qnkyChtvLHMKgVoUY46pKbnvsttPbt1G272 70Jcvk8ZMQuLEDDqfUIlRXZ+BQN3F+4hYH9lnStCr/YqyDpN5fdL350D08200Hch51qavxQaDmr u3uJfzMmjY6Pxd8pDDxG9BQZwyNpuW1V+gSMH0cztG7DqPiQiO0xNvcZDqpwALqW2dMBhWwgUP3 en0Ist44DOcO2nDCvPMomT86TkvBXSkYYh6N3Q+HTKx6i+qZxqiYFl5AWjKDkRqzPCco239FdQs g4F+yXMGZSdiMidhvAxCsNEVN+2JZA0UMaIvWcYIofiC03c5ZzDJ4wDZiH2tJ7PqmucA4PKQF58 8p1FoF0AN4bLFnfINZMFHol7bW+a0X3lFG+c+mPVNi0hDicDYh2bTyzoUlgKSuUoHBi2q X-Received: by 2002:a05:6a00:288d:b0:848:2f74:1d60 with SMTP id d2e1a72fcca58-84c295777f6mr21391309b3a.70.1784703839950; Wed, 22 Jul 2026 00:03:59 -0700 (PDT) X-Received: by 2002:a05:6a00:288d:b0:848:2f74:1d60 with SMTP id d2e1a72fcca58-84c295777f6mr21391287b3a.70.1784703839445; Wed, 22 Jul 2026 00:03:59 -0700 (PDT) Received: from [10.217.219.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e172376ebsm873905b3a.12.2026.07.22.00.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 00:03:59 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 12:33:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-usb-shikra-dt-v4-v4-0-2e7a092d7f27@oss.qualcomm.com> <20260721-usb-shikra-dt-v4-v4-2-2e7a092d7f27@oss.qualcomm.com> <842b4369-3167-4247-a170-e62d5c78fce5@oss.qualcomm.com> <2xpkigm32q6eq7nh4bgsfgswwjquru4pa5oxeciyx3jpywjf2i@qnc3i5sumo2p> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <2xpkigm32q6eq7nh4bgsfgswwjquru4pa5oxeciyx3jpywjf2i@qnc3i5sumo2p> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: nSkRU0pyUONrlSU85W7UNNTbfujaiLzK X-Authority-Analysis: v=2.4 cv=KLhqylFo c=1 sm=1 tr=0 ts=6a606b60 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=4Bh_XYDmQjnsVvAPYLcA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA2NCBTYWx0ZWRfX8Ur4hhpzaxC0 Y+tsLLFquIug1AeRh800KQ0Yr2KGe931CCX/hiiOPcxNuaDp+aE7muXnxtsAJj6fzfKnpY3Dj3t hW3aFPFzuLPHot8Xp1584hIteencxGY6HWCcLVqIxUZ4is39K5hinqcrsc/44EKFKkrs263lYPD Iu+r57xVcowZRbIZvFBzmGM4El4Bf4X3pxETcZ1uUhzufrxOso6U40QnCF89mlWrDVlr2wqEq0D cVfg4hb7+B/uUgT/2IzhH/y1ANsZqotmn04v/WgrIcmHvFqGvVlGEgLjAzTvbJfoQ/IP2vTO0ai Mn591HuNbB7Yn3+bbyjEeNTKD3o9UgMOpimwGs6cEUPbDgq8K8iTp3pTW7/OrGQx/l5M8hqxgAi O15WUu5RZbTjvlv8Xgd4odDvbQJw2bC39u+woIY+8SPluFSU2yACH87ULqJvtcpFE4vWHohz3pc 28WrBondBAj7aFIgIDw== X-Proofpoint-ORIG-GUID: nSkRU0pyUONrlSU85W7UNNTbfujaiLzK X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA2NCBTYWx0ZWRfX6MYnp3aZkoyk VrqUOnJHtK1iFBnGvkQrMg+yVBExhCCzGz5OKkLQ9MAIMFvcfXdxLNVPAOCDEKtiEHocrAZfHo/ KE6sDAb33MeGcQiU/msdYwXNl+dRdbk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220064 On 7/22/2026 11:03 AM, Dmitry Baryshkov wrote: > On Wed, Jul 22, 2026 at 07:22:47AM +0530, Krishna Kurapati wrote: >> >> >> On 7/22/2026 3:07 AM, Dmitry Baryshkov wrote: >>> On Tue, Jul 21, 2026 at 03:23:46PM +0530, Krishna Kurapati wrote: >>>> Enable both USB controllers in device mode on Shikra CQS platform. >>>> >>>> Signed-off-by: Krishna Kurapati >>>> --- >>>> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 35 +++++++++++++++++++++++++++++ >>>> 1 file changed, 35 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >>>> index b3f19a64d7ae..006e24a62f5c 100644 >>>> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >>>> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts >>>> @@ -38,3 +38,38 @@ &sdhc_1 { >>>> status = "okay"; >>>> }; >>>> + >>>> +&usb_1 { >>>> + dr_mode = "peripheral"; >>> >>> Why is peripheral-only? >>> >> >> On First controller of CQS/CQM platforms, usb-role-swtich is controller by >> PM4125 and on second controller of CQS/CQM platforms, and both controllers >> of IQS, its controller by Cypress PD controller. I will push out the PM4125 >> changes in a different patch set since couple of issues are under debug. And >> the cypress pd controller changes are still under development. Hence enabled >> both controllers in device mode for now. > > That needs to be explained in the commit messages. > Since putting in commit message that there is a PD controller or the PM4125 will take care of OTG would be out of context, in cover letter can i mention that the above information, and state that future patches will enable OTG. Regards, Krishna,