From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] KVM: x86: move guest_pv_has out of user_access section
Date: Fri, 12 Nov 2021 08:11:07 +0000 [thread overview]
Message-ID: <e0a60cc65d6e3d7670b65479fd7ff662db6a5dfd.camel@infradead.org> (raw)
In-Reply-To: <20211112075422.3821671-1-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Fri, 2021-11-12 at 02:54 -0500, Paolo Bonzini wrote:
> When UBSAN is enabled, the code emitted for the call to guest_pv_has
> includes a call to __ubsan_handle_load_invalid_value. objtool
> complains that this call happens with UACCESS enabled; to avoid
> the warning, pull the calls to user_access_begin into both arms
> of the "if" statement, after the check for guest_pv_has.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks. I found a bunch of those objtool warnings during my original
experimentation and testing, but clearly missed that one. I'll turn on
CONFIG_UBSAN.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
prev parent reply other threads:[~2021-11-12 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 7:54 Paolo Bonzini
2021-11-12 8:11 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a60cc65d6e3d7670b65479fd7ff662db6a5dfd.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®