From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814
Date: Mon, 20 Oct 2025 20:11:13 +0200 [thread overview]
Message-ID: <e0a8830e-6267-4b2a-b1fa-f3cbe34bd3ba@engleder-embedded.com> (raw)
In-Reply-To: <20251020063945.dwqgn5yphdwnt4vk@DEN-DL-M31836.microchip.com>
On 20.10.25 08:39, Horatiu Vultur wrote:
> The 10/17/2025 23:15, Gerhard Engleder wrote:
...
>>>
>>> +/* Check if the PHY has 1588 support. There are multiple skus of the PHY and
>>> + * some of them support PTP while others don't support it. This function will
>>> + * return true is the sku supports it, otherwise will return false.
>>> + */
>>
>> Hasn't net also switched to the common kernel multiline comment style
>> starting with an empty line?
>
> I am not sure because I can see some previous commits where people used
> the same comment style:
> e82c64be9b45 ("net: stmmac: avoid PHY speed change when configuring MTU")
> 100dfa74cad9 ("net: dev_queue_xmit() llist adoption")
The special coding style for multi line comments for net and drivers/net
has been removed with
82b8000c28 ("net: drop special comment style")
But I checked a few mails on the list and also found the old style in
new patches.
Gerhard
next prev parent reply other threads:[~2025-10-20 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:47 Horatiu Vultur
2025-10-17 21:15 ` Gerhard Engleder
2025-10-20 6:39 ` Horatiu Vultur
2025-10-20 18:11 ` Gerhard Engleder [this message]
2025-10-21 6:51 ` Horatiu Vultur
2025-10-21 9:03 ` Russell King (Oracle)
2025-10-21 23:14 ` Jakub Kicinski
2025-10-22 4:12 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a8830e-6267-4b2a-b1fa-f3cbe34bd3ba@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®