From: John Garry <john.g.garry@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: axboe@kernel.dk, brauner@kernel.org, viro@zeniv.linux.org.uk,
jack@suse.cz, chandan.babu@oracle.com, dchinner@redhat.com,
hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hare@suse.de,
martin.petersen@oracle.com, catherine.hoang@oracle.com,
kbusch@kernel.org
Subject: Re: [PATCH v5 7/7] xfs: Support setting FMODE_CAN_ATOMIC_WRITE
Date: Fri, 23 Aug 2024 11:41:07 +0100 [thread overview]
Message-ID: <e0a93440-8f38-46e1-a77f-6a0125ab8cb5@oracle.com> (raw)
In-Reply-To: <20240822204407.GU865349@frogsfrogsfrogs>
On 22/08/2024 21:44, Darrick J. Wong wrote:
>> Do you mean that add a new member to xfs_inode to record this? If yes, it
>> sounds ok, but we need to maintain consistency (of that member) whenever
>> anything which can affect it changes, which is always a bit painful.
> I actually meant something more like:
>
> static bool
> xfs_file_open_can_atomicwrite(
> struct file *file,
> struct inode *inode)
> {
> struct xfs_inode *ip = XFS_I(inode);
> struct xfs_mount *mp = ip->i_mount;
> struct xfs_buftarg *target = xfs_inode_buftarg(ip);
>
> if (!(file->f_flags & O_DIRECT))
> return false;
> if (!xfs_inode_has_atomicwrites(ip))
> return false;
> if (mp->m_dalign && (mp->m_dalign % ip->i_extsize))
> return false;
> if (mp->m_swidth && (mp->m_swidth % ip->i_extsize))
> return false;
> if (mp->m_sb.sb_blocksize < target->bt_bdev_awu_min)
> return false;
> if (xfs_inode_alloc_unitsize(ip) > target->bt_bdev_awu_max)
> return false;
> return true;
> }
ok, but we should probably factor out some duplicated code with helpers,
like:
bool xfs_validate_atomicwrites_extsize(struct xfs_mount *mp, uint32_t
extsize)
{
if (!is_power_of_2(extsize))
return false;
/* Required to guarantee data block alignment */
if (mp->m_sb.sb_agblocks % extsize)
return false;
/* Requires stripe unit+width be a multiple of extsize */
if (mp->m_dalign && (mp->m_dalign % extsize))
return false;
if (mp->m_swidth && (mp->m_swidth % extsize))
return false;
return true;
}
bool xfs_inode_has_atomicwrites(struct xfs_inode *ip)
{
struct xfs_mount *mp = ip->i_mount;
struct xfs_buftarg *target = xfs_inode_buftarg(ip);
if (!(ip->i_diflags2 & XFS_DIFLAG2_ATOMICWRITES))
return false;
if (!xfs_validate_atomicwrites_extsize(mp, ip->i_extsize))
return false;
if (mp->m_sb.sb_blocksize < target->bt_bdev_awu_min)
return false;
if (xfs_inode_alloc_unitsize(ip) > target->bt_bdev_awu_max)
return false;
return true;
}
static bool xfs_file_open_can_atomicwrite(
struct inode *inode,
struct file *file)
{
struct xfs_inode *ip = XFS_I(inode);
if (!(file->f_flags & O_DIRECT))
return false;
return xfs_inode_has_atomicwrites(ip);
}
Those helpers can be re-used in xfs_inode_validate_atomicwrites() and
xfs_ioctl_setattr_atomicwrites().
John
next prev parent reply other threads:[~2024-08-23 10:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 9:47 [PATCH v5 0/7] block atomic writes for xfs John Garry
2024-08-17 9:47 ` [PATCH v5 1/7] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-08-20 17:28 ` Darrick J. Wong
2024-08-17 9:47 ` [PATCH v5 2/7] fs: Export generic_atomic_write_valid() John Garry
2024-08-20 17:28 ` Darrick J. Wong
2024-08-17 9:47 ` [PATCH v5 3/7] fs: iomap: Atomic write support John Garry
2024-08-21 16:58 ` Darrick J. Wong
2024-08-22 15:29 ` John Garry
2024-08-22 20:30 ` Darrick J. Wong
2024-08-30 15:48 ` John Garry
2024-08-30 23:56 ` Darrick J. Wong
2024-09-03 12:43 ` John Garry
2024-08-17 9:47 ` [PATCH v5 4/7] xfs: Support FS_XFLAG_ATOMICWRITES for forcealign John Garry
2024-08-21 17:07 ` Darrick J. Wong
2024-08-22 17:45 ` John Garry
2024-08-22 20:38 ` Darrick J. Wong
2024-08-23 8:39 ` John Garry
2024-08-23 16:03 ` Darrick J. Wong
2024-08-17 9:47 ` [PATCH v5 5/7] xfs: Support atomic write for statx John Garry
2024-08-21 17:09 ` Darrick J. Wong
2024-08-17 9:47 ` [PATCH v5 6/7] xfs: Validate atomic writes John Garry
2024-08-21 17:10 ` Darrick J. Wong
2024-08-17 9:48 ` [PATCH v5 7/7] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-08-21 17:11 ` Darrick J. Wong
2024-08-22 18:04 ` John Garry
2024-08-22 20:44 ` Darrick J. Wong
2024-08-23 10:41 ` John Garry [this message]
2024-08-23 15:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a93440-8f38-46e1-a77f-6a0125ab8cb5@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®