From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030456AbcIWMBZ (ORCPT ); Fri, 23 Sep 2016 08:01:25 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:58263 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966006AbcIWMBW (ORCPT ); Fri, 23 Sep 2016 08:01:22 -0400 Subject: Re: [PATCH] drm/tilcdc: fix wrong error handling To: Sean Paul , Daniel Schultz References: <1474627969-21859-1-git-send-email-d.schultz@phytec.de> CC: dri-devel , Tomi Valkeinen , Dave Airlie , Linux Kernel Mailing List From: Jyri Sarha Message-ID: Date: Fri, 23 Sep 2016 15:01:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/16 14:47, Sean Paul wrote: > On Fri, Sep 23, 2016 at 3:52 AM, Daniel Schultz wrote: >> When 'component_bind_all' fails it should not try to unbind components >> in the error handling. This will produce a null pointer kernel panic when >> no component exist. >> >> This patch changes the order of the error handling. Now, it will only >> unbind components if the are bound. Otherwise, the module will jump to >> an error label below. >> >> Signed-off-by: Daniel Schultz > > Reviewed-by: Sean Paul > Thanks, for both. Should I pick this one :)? BR, Jyri >> --- >> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> index d278093..d491610 100644 >> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> @@ -315,13 +315,13 @@ fail_irq_uninstall: >> fail_vblank_cleanup: >> drm_vblank_cleanup(dev); >> >> -fail_mode_config_cleanup: >> - drm_mode_config_cleanup(dev); >> - >> fail_component_cleanup: >> if (priv->is_componentized) >> component_unbind_all(dev->dev, dev); >> >> +fail_mode_config_cleanup: >> + drm_mode_config_cleanup(dev); >> + >> fail_external_cleanup: >> tilcdc_remove_external_encoders(dev); >> >> -- >> 1.9.1 >>