From: Petr Pavlu <petr.pavlu@suse.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] module: Simplify warning on positive returns from module_init()
Date: Fri, 17 Oct 2025 14:06:03 +0200 [thread overview]
Message-ID: <e0b031d6-2b2d-4788-ac9c-b76e6a4bfab0@suse.com> (raw)
In-Reply-To: <20251013-module-warn-ret-v1-2-ab65b41af01f@intel.com>
On 10/13/25 6:26 PM, Lucas De Marchi wrote:
> It should now be rare to trigger this warning - it doesn't need to be so
> verbose. Make it follow the usual style in the module loading code.
>
> For the same reason, drop the dump_stack().
>
> Suggested-by: Petr Pavlu <petr.pavlu@suse.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
--
Thanks,
Petr
next prev parent reply other threads:[~2025-10-17 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:26 [PATCH 0/2] module: Tweak return and warning Lucas De Marchi
2025-10-13 16:26 ` [PATCH 1/2] module: Override -EEXISTS module return Lucas De Marchi
2025-10-17 12:04 ` Petr Pavlu
2025-11-02 18:23 ` Aaron Tomlin
2025-11-10 15:17 ` Daniel Gomez
2025-11-10 15:31 ` Lucas De Marchi
2025-11-16 20:42 ` Daniel Gomez
2025-11-16 20:46 ` Daniel Gomez
2025-10-13 16:26 ` [PATCH 2/2] module: Simplify warning on positive returns from module_init() Lucas De Marchi
2025-10-17 12:06 ` Petr Pavlu [this message]
2025-11-02 18:23 ` Aaron Tomlin
2025-11-16 20:47 ` [PATCH 0/2] module: Tweak return and warning Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b031d6-2b2d-4788-ac9c-b76e6a4bfab0@suse.com \
--to=petr.pavlu@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®