From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4472730DD3C for ; Thu, 19 Feb 2026 21:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771535449; cv=none; b=GxOtaqiSA8cvXskCfrx4S6A/9XAcbBOaopg3ClUc3tMdkXRrBbxE+JB9EDknZVfFnL+/Ok9rPvbjF6iWMB68xiZRIFhmIBQqkqLdS/QyL1oGLPbfP2uEtwo8s/xnqqbT2I2ymDu5jPkcaFL7j0fTZ7DLQ5VHgzGxsOBfUU4Y8Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771535449; c=relaxed/simple; bh=JN6SNwJz/PklshsvOgeHq8ajH+qHNKzC5uQ86LGzgXc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=irRaKn+1IJU/0G7iXc2Nn0PwsMMWrszYgsd9S99xlRAoYZHwSK4L3uWy2tKidbvXzcoyXuKt3//QQuKVTj1RrP1X0d9/4iLeC01JonUIsk0fYhvUTWVBPyko41Ck7nxN7jKwUXmnSBbxj1WD8iMP2XZl/KOvXDypcFfVnXXvoDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=XZFY59iG; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="XZFY59iG" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-40f0e14b9f9so812910fac.1 for ; Thu, 19 Feb 2026 13:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771535446; x=1772140246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UrC+PLfTea68FI9Rr5zEv0pamcCsfXyApvn8rTrZCCo=; b=XZFY59iG+ON0v2A+mE7aPxY7ovQXFXZCFqAvxBBG7+znDIMC7LE84n2RNsgUlXmY6P tp6Q5b/iZDA9YJluflyDw919fSkX/x+aN9tQX8PDM4JN26ufv4WNR17sBNmLZMMHMJjH ceDYrln1/COWBy/vuFrK6p3xSjqWjjhLC2L+ILcynRG0Dq8FwbeeQtp2Er4mFJ14FFlu b2bQy0rIHQJzTyCq6RoqFE7W9WAWknQjLTYS/o/ov98roir3oapCYFDnhT4WLB/+uAQc nkC6cWWsUmWDDRNmOEOP+HxsR+aCf+GhQ2DYEuD1C/qtv6O/ID2FrjJU7AErBk7ZK43x mxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771535446; x=1772140246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UrC+PLfTea68FI9Rr5zEv0pamcCsfXyApvn8rTrZCCo=; b=WBFSLf4NoobXGcijZME++U+iuPKEXebQbJ38goEsuoWWcXhIkV2l0eE1xggVQFqgfr UqXwZEO1XNKxnIigyRGA2utYWRhn/3XeSQi3uyCMCaHmVxpj74btmTe4ihdrbQRTygtL d2ANT4J1yFEDmiWtfJS9bXF1IvofpkmdbhylT3+PH8/QntN9YmrbeNOdMy+d+HWs3FoO raAgYNkbkBhzeEZGFeXYJmYVx4yXAlzW1qDeLZyTFcXomDho8t4YWofKTO3zN6DvCvP3 uPChHVlHehHwsCtqF9k5X3kNGYYZsHZwYcFxByyNjRSL4GD8liyYpKrz9a2uoyO3v89T W3Qw== X-Forwarded-Encrypted: i=1; AJvYcCVTgQaihsVlXTiTmwMu+DZqh9Vo1vew0fC7hK8io5K814G98fSWplcV47yDtOt5hB3niey2rVOMlE9+Ehg=@vger.kernel.org X-Gm-Message-State: AOJu0YwkNlPVa5CghkWSIflWX00YfJc57srfsuu4tnsYrZkAWu2+mlKS a2ZRtHYAn2ibGjnlx12x6Zmn4izqzlzr3WwiDZsLi9qPIaMa/QzTqBNGcNOQLqYNaHw= X-Gm-Gg: AZuq6aKgRmyJyu1xJUGNihjLrmkpeKNFwa+MsoJeNG3x0ejQoSs4YxaBBmqg1Z3VshW F1QydxSd2LomFJ4rzv234nEWMEd4aU/PvAvBaXSOHktefgrzrw/zAMy66lF3CLHareHjb1ljIU5 VtZHExmz8c8wFyR8MF0jvJOx9heDOYivNw8qsuDklFLgiHXo5hamURjnCNNkrPx56hoXkSQxFPo kwZirJI0inpQA2GQ9wbhuYVBuqYAMKPvT2VFbSlESiWXMnqvV24fwo+wN+4OyXhLwPdABsVBRwi cAS6bldAAwDKO05ffxbnA7gntc42wnWX4WzXspx5edPC/HbefI+FWzsANxKe0N9fetm2/MQORcf xcuHkkKuOEbIaI4SFBsNKJPYxkhOPGC8JdnzSWHD61A+ksNQQ1NXoJ1kpY8JydaynrpGasrnD53 4qXWP8E3OOYwXzlZMjVoNlGwC8OSRYP4B1T4r7TCtmniv+Ssi3JT9Hp6xV8BvBARLwzKy6mg== X-Received: by 2002:a05:6870:4596:b0:40a:5a07:3598 with SMTP id 586e51a60fabf-4152913c255mr4207227fac.36.1771535446056; Thu, 19 Feb 2026 13:10:46 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:d4c1:bce:26a1:c903? ([2600:8803:e7e4:500:d4c1:bce:26a1:c903]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40ee06756easm22066534fac.13.2026.02.19.13.10.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 13:10:45 -0800 (PST) Message-ID: Date: Thu, 19 Feb 2026 15:10:43 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/18] clk: mediatek: Add MT8189 vlpckgen clock support To: "irving.ch.lin" , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Richard Cochran , Bartosz Golaszewski , Chen-Yu Tsai , Miles Chen Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Qiqi Wang , sirius.wang@mediatek.com, vince-wl.liu@mediatek.com, jh.hsu@mediatek.com References: <20260202062840.342707-1-irving-ch.lin@mediatek.com> <20260202062840.342707-6-irving-ch.lin@mediatek.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202062840.342707-6-irving-ch.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 12:28 AM, irving.ch.lin wrote: > From: Irving-CH Lin > > Add support for the MT8189 vlpckgen clock controller, which provides > muxes and dividers for clock selection in vlp domain for other IP blocks. > > Signed-off-by: Irving-CH Lin > --- ... > +static const struct mtk_gate vlp_ck_clks[] = { > + GATE_VLP_CK(CLK_VLP_CK_VADSYS_VLP_26M_EN, "vlp_vadsys_vlp_26m", "clk26m", 1), In mediatek,mt8189-clk.h, we have: #define CLK_VLP_CK_VADSYS_VLP_26M_EN 24 #define CLK_VLP_CK_SEJ_13M_EN 25 #define CLK_VLP_CK_SEJ_26M_EN 26 #define CLK_VLP_CK_FMIPI_CSI_UP26M_CK_EN 27 Are we missing the middle two clocks here? Or should the be omitted from the header file? > + GATE_VLP_CK_FLAGS(CLK_VLP_CK_FMIPI_CSI_UP26M_CK_EN, "VLP_fmipi_csi_up26m", > + "osc_d10", 11, CLK_IS_CRITICAL), > +}; > +