mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Qiao <zhangqiao22@huawei.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: <mingo@kernel.org>, <chrubis@suse.cz>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>, <corbet@lwn.net>
Subject: Re: [PATCH] sched/Documentation: Add RT_RUNTIME_SHARE documentation
Date: Fri, 19 Apr 2024 16:51:56 +0800	[thread overview]
Message-ID: <e0b48c67-abb6-18f1-86ba-a041ccb4e0b7@huawei.com> (raw)
In-Reply-To: <Zhihch_S1_-1JhwK@archie.me>



在 2024/4/12 10:50, Bagas Sanjaya 写道:
> On Wed, Jan 31, 2024 at 08:32:38PM +0800, Zhang Qiao wrote:
>> +2.4 RT_RUNTIME_SHARE sched feature
>> +----------------------------
> 
> htmldocs build reports new warning:
> 
> Documentation/scheduler/sched-rt-group.rst:151: WARNING: Title underline too short.
> 
> 2.4 RT_RUNTIME_SHARE sched feature
> ----------------------------
> 
> I have to extend the underline:
> 
> ---- >8 ----
> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
> index 4d8eceb71f5ed8..751113fcd35850 100644
> --- a/Documentation/scheduler/sched-rt-group.rst
> +++ b/Documentation/scheduler/sched-rt-group.rst
> @@ -148,7 +148,7 @@ For now, this can be simplified to just the following (but see Future plans):
>     \Sum_{i} runtime_{i} <= global_runtime
>  
>  2.4 RT_RUNTIME_SHARE sched feature
> -----------------------------
> +----------------------------------
>  
>  RT_RUNTIME_SHARE allows a cpu borrows rt-runtime from other cpus if it runs
>  out of its own rt-runtime.
> 
> Wording suggestions below.

Hi, Bagas,
Thanks for you suggestions, i will update in v2.


Zhang Qiao.

> 
>> +
>> +RT_RUNTIME_SHARE allows a cpu borrows rt-runtime from other cpus if it runs
> "... to borrow rt-runtime ..."
>> +out of its own rt-runtime.
>> +
>> +With this feature enabled, a rt-task probably hits 100% cpu usage and starves
> "... a rt-task may hit ... and can stall other per-cpu tasks ..."
>> +per-cpu tasks like kworkers, as a result, it may hang up the whole system.
> "..., which lead into system hang."
>> +Therefore, in order to avoid such exception, recommand to disable this feature
>> +by default unless you really know what you're up to.
> "Thus, it is advised to disable this feature by default to avoid aforementioned
> issue unless you know what you're doing."
> 
> Thanks.
> 

      reply	other threads:[~2024-04-19  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 12:32 Zhang Qiao
2024-02-28 22:44 ` Jonathan Corbet
2024-03-24  3:54   ` Zhang Qiao
2024-04-09  7:25 ` Zhang Qiao
2024-04-12  2:50 ` Bagas Sanjaya
2024-04-19  8:51   ` Zhang Qiao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0b48c67-abb6-18f1-86ba-a041ccb4e0b7@huawei.com \
    --to=zhangqiao22@huawei.com \
    --cc=bagasdotme@gmail.com \
    --cc=chrubis@suse.cz \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®