From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6399CEC8738 for ; Thu, 7 Sep 2023 16:12:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236295AbjIGQMZ (ORCPT ); Thu, 7 Sep 2023 12:12:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236492AbjIGQLw (ORCPT ); Thu, 7 Sep 2023 12:11:52 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B628518A; Thu, 7 Sep 2023 09:08:49 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 387EUMEN012475; Thu, 7 Sep 2023 09:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694097022; bh=iizL7oHkzdtUKafgy+23NXIf5F01F0/spqcKBDyXeVQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=ByyPNf+GgYBrJIgydC7bWdsAj4rOO6PTcSDl88YbvbE3oTr4so4jvcAfYbrISRyrX Bb+SnLGUlkGuerf3azo87d6eemLLqf+/yeLrO2akFC1qv2tb2HPUfqzFkXiwrXmK5U ltt8ZIpAhFo7PeTcuqfXuC511zp1ZGyEXA1hFpek= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 387EUM7L016064 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Sep 2023 09:30:22 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 7 Sep 2023 09:30:21 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 7 Sep 2023 09:30:21 -0500 Received: from [10.249.131.134] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 387EUHim010301; Thu, 7 Sep 2023 09:30:18 -0500 Message-ID: Date: Thu, 7 Sep 2023 20:00:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Content-Language: en-US To: "Kumar, Udit" , , , , , , CC: , , References: <20230907115210.28082-1-j-keerthy@ti.com> <20230907115210.28082-5-j-keerthy@ti.com> <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com> From: "J, KEERTHY" In-Reply-To: <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23305EC8726 for ; Thu, 7 Sep 2023 17:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244358AbjIGRfW (ORCPT ); Thu, 7 Sep 2023 13:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231401AbjIGRfT (ORCPT ); Thu, 7 Sep 2023 13:35:19 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85541990; Thu, 7 Sep 2023 10:34:51 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 387EUMEN012475; Thu, 7 Sep 2023 09:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694097022; bh=iizL7oHkzdtUKafgy+23NXIf5F01F0/spqcKBDyXeVQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=ByyPNf+GgYBrJIgydC7bWdsAj4rOO6PTcSDl88YbvbE3oTr4so4jvcAfYbrISRyrX Bb+SnLGUlkGuerf3azo87d6eemLLqf+/yeLrO2akFC1qv2tb2HPUfqzFkXiwrXmK5U ltt8ZIpAhFo7PeTcuqfXuC511zp1ZGyEXA1hFpek= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 387EUM7L016064 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Sep 2023 09:30:22 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 7 Sep 2023 09:30:21 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 7 Sep 2023 09:30:21 -0500 Received: from [10.249.131.134] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 387EUHim010301; Thu, 7 Sep 2023 09:30:18 -0500 Message-ID: Date: Thu, 7 Sep 2023 20:00:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Content-Language: en-US To: "Kumar, Udit" , , , , , , CC: , , References: <20230907115210.28082-1-j-keerthy@ti.com> <20230907115210.28082-5-j-keerthy@ti.com> <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com> From: "J, KEERTHY" In-Reply-To: <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20230907143016.0dy1-u1NoGwUpkwFB5rT4z3EtK5ZRgQqFgCMdFV3PKw@z> On 9/7/2023 7:44 PM, Kumar, Udit wrote: > Thanks Keerthy, > > On 9/7/2023 5:22 PM, Keerthy wrote: >> There are totally 19 instances of watchdog module. One each for the >> 8 A72 cores, one each for the 4 C7x cores, 1 for the GPU, 1 each >> for the 6 R5F cores in the main domain. Keeping only the A72 instances >> enabled and disabling the rest by default. >> >> Signed-off-by: Keerthy >> --- >>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 182 +++++++++++++++++++++ >>   1 file changed, 182 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index 7f7eab348520..66ab947a1081 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -1574,4 +1574,186 @@ >>           reg = <0x00 0x700000 0x00 0x1000>; >>           ti,esm-pins = <688>, <689>; >>       }; >> + >> +    watchdog0: watchdog@2200000 { >> +        compatible = "ti,j7-rti-wdt"; >> +        reg = <0x00 0x2200000 0x00 0x100>; >> +        clocks = <&k3_clks 348 1>; >> +        power-domains = <&k3_pds 348 TI_SCI_PD_EXCLUSIVE>; >> +        assigned-clocks = <&k3_clks 348 0>; >> +        assigned-clock-parents = <&k3_clks 348 4>; >> +    }; > > In ESM, patch I see only output of 2 watchdog in cascaded for reset. > > if you want to keep enable other wdt, then IMO they should be able to > reset the core/SOC > > on timeout I can add the other ESM events to the ESM node to enable that. I will wait if there are more comments. If this is the only one comment i will post a v3 of the esm patch. - Keerthy > > >> + >> +    [..]};