From: Joe Perches <joe@perches.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
benjamin.tissoires@redhat.com, jikos@kernel.org,
open list <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] MAINTAINERS: Fix parsing usbhid from scripts/get_maintainer.pl
Date: Thu, 16 Jun 2022 19:40:34 -0700 [thread overview]
Message-ID: <e0b7573a146da0aee33b3b21c66805bedad598f3.camel@perches.com> (raw)
In-Reply-To: <20220616183322.14861-1-mario.limonciello@amd.com>
On Thu, 2022-06-16 at 13:33 -0500, Mario Limonciello wrote:
> Recently trying to send a patch, I found that `./scripts/get_maintainer.pl`
> didn't want to parse the usbhid section because of too long of a line
> leading to a missing parenthesis. To fix this, change () to [] so it can
> parse even the long line.
[]
> (to-cmd) Adding to: linux-usb@vger.kernel.org (open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...) from: 'scripts/get_maintainer.pl'
> (to-cmd) Adding to: linux-input@vger.kernel.org (open list:HID CORE LAYER) from: 'scripts/get_maintainer.pl'
> (to-cmd) Adding to: linux-kernel@vger.kernel.org (open list) from: 'scripts/get_maintainer.pl'
> Unmatched () '(open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...)' '' at /usr/lib/git-core/git-send-email line 546.
> error: unable to extract a valid address from: linux-usb@vger.kernel.org (open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...)
And it wasn't get_maintainer, it was git send-email that found that
the specific get_maintainer output was not a 'valid' email address
with a balanced parenthesis comment.
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -20537,7 +20537,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> F: drivers/usb/gadget/
> F: include/linux/usb/gadget*
>
> -USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REMOTE CONTROLS, ...)
> +USB HID/HIDBP DRIVERS [USB KEYBOARDS, MICE, REMOTE CONTROLS, ...]
> M: Jiri Kosina <jikos@kernel.org>
> M: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> L: linux-usb@vger.kernel.org
prev parent reply other threads:[~2022-06-17 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 18:33 Mario Limonciello
2022-06-17 2:37 ` Joe Perches
2022-06-17 2:40 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b7573a146da0aee33b3b21c66805bedad598f3.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®