RE: [PATCH v2 2/2] usb: typec: ucsi: itepd: Add DisplayPort alternate mode support

[<amber.kao@ite.com.tw>]

On Fri, Sep 18, 2026 at XX:XX, Heikki Krogerus wrote:
> >  config UCSI_ITEPD
> > -	tristate "UCSI Interface Driver for ITE IT8851/IT8853"
> > +	tristate "UCSI Interface Driver for ITE IT885x and IT527x series"
> >  	depends on I2C
> > +	depends on DRM || !DRM
> > +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
>
> Please split this part into separate patch.

Hi Heikki,

Understood, thanks for the suggestion.

I will move the Kconfig prompt, help text and MODULE_DESCRIPTION
updates out of the DisplayPort patch, so that the IT885x/IT527x
support and the DisplayPort alternate mode support are separate
patches.

Would it be fine to send both patches at the same time, or would you
prefer that I send the DisplayPort alternate mode support after the
IT885x/IT527x support has been accepted?

Thanks,
Amber

-----Original Message-----
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> 
Sent: Tuesday, September 22, 2026 7:03 PM
To: ITE_PD <ite_pd@ite.com.tw>
Cc: Amber Kao (高鈺盈) <amber.kao@ite.com.tw>; Jeson Yang (楊志賢) <jeson.yang@ite.com.tw>; Yaode Fang (方耀德) <Yaode.Fang@ite.com.tw>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] usb: typec: ucsi: itepd: Add DisplayPort alternate mode support

On Fri, Sep 18, 2026 at 06:03:44PM +0800, Amber Kao wrote:
> Add support for DisplayPort alternate mode. The driver retrieves the 
> current alternate mode from the PPM, configures the Type-C mux and 
> retimer accordingly, and reports HPD state and HPD IRQ events through 
> the DRM auxiliary HPD bridge.
> 
> Signed-off-by: Amber Kao <ite_pd@ite.com.tw>
> ---
>  drivers/usb/typec/ucsi/Kconfig      |   8 +-
>  drivers/usb/typec/ucsi/ucsi_itepd.c | 404 
> +++++++++++++++++++++++++++++++++++-
>  2 files changed, 400 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/Kconfig 
> b/drivers/usb/typec/ucsi/Kconfig index 0f10dac9b34b..c5eaf4967e4e 
> 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -105,11 +105,15 @@ config UCSI_HUAWEI_GAOKUN
>  	  called ucsi_huawei_gaokun.
>  
>  config UCSI_ITEPD
> -	tristate "UCSI Interface Driver for ITE IT8851/IT8853"
> +	tristate "UCSI Interface Driver for ITE IT885x and IT527x series"
>  	depends on I2C
> +	depends on DRM || !DRM
> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
>  	help
>  	  This driver enables UCSI support on platforms that expose an
> -	  ITE IT8851/IT8853 Type-C Power Delivery controller over an I2C interface.
> +	  ITE IT885x or IT527x series Type-C Power Delivery controller
> +	  over an I2C interface. It also supports DisplayPort alternate
> +	  mode, including HPD notification through the DRM bridge.

Please split this part into separate patch.

Thanks,

--
heikki