From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B467CEE4996 for ; Mon, 21 Aug 2023 13:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235541AbjHUNvy (ORCPT ); Mon, 21 Aug 2023 09:51:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235480AbjHUNvx (ORCPT ); Mon, 21 Aug 2023 09:51:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2FB4E1 for ; Mon, 21 Aug 2023 06:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692625861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10Fo2ozRX3AHiAUCjC/DOAP9UJ/a8nPM6586lexVlDI=; b=MWcEtgatxXN5fne0hfiC9ACNZz3beor74ULsvZfTFXwkYdddIOdwntUAICmMRO+WXXbPFW ErCFueOla6wEZXsKvKQXR0Hp3Mg2+YNLESbyATR++aS8Ec1wU88HDzhpOJDjTDhXj8IaGl CFT6mp7SjfenpVWXARhpG+4BKF4QBEU= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-xYYKhu0sP9a1xM1em_3PWg-1; Mon, 21 Aug 2023 09:51:00 -0400 X-MC-Unique: xYYKhu0sP9a1xM1em_3PWg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-99cc5d18f78so219810966b.3 for ; Mon, 21 Aug 2023 06:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692625859; x=1693230659; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=10Fo2ozRX3AHiAUCjC/DOAP9UJ/a8nPM6586lexVlDI=; b=SQAed2hJZEBJn7RCUOWbWqjUY4xaEHlfzLAcnxroGNmDIAYpCijBFSbPCuTRibhFJW o860P4lNpgrXWWlyLHSrOuFQITAJTb/VTzs60okJYppgCO1ZW1FvkV0Z0fTcKQYUrR0w lpEDBhgkEnIYd8aawEGLZsdriyS5Cf+x9HtF/ayLNFE+noeIO+ji92GUI59/uzv48MUa y4EzHr7RFrbxf1jO1xDwmwHBFcBlf23L3E5i4YnvWCYQ3S30O3O3jljvYTwDusZBsMU4 F1Vp3aL6XdvWhIG82+XLt/IJQTOgBV39zfChNl+eD/pB8ZVEb1F0sKmqAYvfw45GHBY8 xpVw== X-Gm-Message-State: AOJu0YwkJ7U8OWZjEGs7LPb6Mj3k4Bbm+kLpWstsGrzb1gILSpU5k3WC Z0z/xZu4dciVbEpucDvc4dAvxCsVqfny3FzM7rZ+Y0htt5rjwaEMwTYERVukNkCRpeu1GcMGjEM b8MBcWDWEgzd7uDSaTRkd/WDV X-Received: by 2002:a17:906:5a53:b0:993:d7cf:f58 with SMTP id my19-20020a1709065a5300b00993d7cf0f58mr5721803ejc.2.1692625859188; Mon, 21 Aug 2023 06:50:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGaV3h7zCYtJ8lRvqiCvScPFq7FOXZJnHAjgqSpV3bAx8lal3SR33cEkHxv1vyOGEX0xO4Tkg== X-Received: by 2002:a17:906:5a53:b0:993:d7cf:f58 with SMTP id my19-20020a1709065a5300b00993d7cf0f58mr5721781ejc.2.1692625858805; Mon, 21 Aug 2023 06:50:58 -0700 (PDT) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id q16-20020a170906b29000b0099ddc81903asm6568858ejz.221.2023.08.21.06.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 06:50:58 -0700 (PDT) Message-ID: Date: Mon, 21 Aug 2023 15:50:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] mlxbf-bootctl: Support sysfs entries for MFG fields Content-Language: en-US To: David Thompson , ilpo.jarvinen@linux.intel.com, markgross@kernel.org, vadimp@nvidia.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, shravankr@nvidia.com References: <20230818213417.17942-1-davthompson@nvidia.com> From: Hans de Goede In-Reply-To: <20230818213417.17942-1-davthompson@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 8/18/23 23:34, David Thompson wrote: > This patch extends the mlxbf-bootctl driver's sysfs entries > to support read and write access for the manufacturing (MFG) > fields in the board-level EEPROM. The MFG fields are set > once during the board manufacturing phase, and then the MFG > fields are write-protected. > > Signed-off-by: David Thompson > Reviewed-by: Shravan Kumar Ramani > --- > v1->v2 > - use ETH_ALEN instead of custom #define (MLNX_MFG_OOB_MAC_LEN) > - changes to xxx_show() methods: > a) removed unnecessary memcpy() calls, instead use data from xxx_data[] > b) increment size of xxx_data[] by 1 to ensure null termination > - changed "byte[]" variable to unsigned int in oob_mac_store() > - use sysfs_format_mac() in oob_mac_show() Thank you for the new version. Please add documentation for the newly added sysfs attributes to: Documentation/ABI/testing/sysfs-platform-mellanox-bootctl this will make it easier for me to review the new userspace API for this. Regards, Hans > --- > drivers/platform/mellanox/mlxbf-bootctl.c | 438 ++++++++++++++++++++++ > drivers/platform/mellanox/mlxbf-bootctl.h | 8 + > 2 files changed, 446 insertions(+) > > diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c > index 0bf29eee1e70..4ee7bb431b7c 100644 > --- a/drivers/platform/mellanox/mlxbf-bootctl.c > +++ b/drivers/platform/mellanox/mlxbf-bootctl.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -81,6 +82,49 @@ static const char * const mlxbf_rsh_log_level[] = { > > static DEFINE_MUTEX(icm_ops_lock); > static DEFINE_MUTEX(os_up_lock); > +static DEFINE_MUTEX(mfg_ops_lock); > + > +/* > + * Objects are stored within the MFG partition per type. > + * Type 0 is not supported. > + */ > +enum { > + MLNX_MFG_TYPE_OOB_MAC = 1, > + MLNX_MFG_TYPE_OPN_0, > + MLNX_MFG_TYPE_OPN_1, > + MLNX_MFG_TYPE_OPN_2, > + MLNX_MFG_TYPE_SKU_0, > + MLNX_MFG_TYPE_SKU_1, > + MLNX_MFG_TYPE_SKU_2, > + MLNX_MFG_TYPE_MODL_0, > + MLNX_MFG_TYPE_MODL_1, > + MLNX_MFG_TYPE_MODL_2, > + MLNX_MFG_TYPE_SN_0, > + MLNX_MFG_TYPE_SN_1, > + MLNX_MFG_TYPE_SN_2, > + MLNX_MFG_TYPE_UUID_0, > + MLNX_MFG_TYPE_UUID_1, > + MLNX_MFG_TYPE_UUID_2, > + MLNX_MFG_TYPE_UUID_3, > + MLNX_MFG_TYPE_UUID_4, > + MLNX_MFG_TYPE_REV, > +}; > + > +#define MLNX_MFG_OPN_VAL_LEN 24 > +#define MLNX_MFG_SKU_VAL_LEN 24 > +#define MLNX_MFG_MODL_VAL_LEN 24 > +#define MLNX_MFG_SN_VAL_LEN 24 > +#define MLNX_MFG_UUID_VAL_LEN 40 > +#define MLNX_MFG_REV_VAL_LEN 8 > +#define MLNX_MFG_VAL_QWORD_CNT(type) \ > + (MLNX_MFG_##type##_VAL_LEN / sizeof(u64)) > + > +/* > + * The MAC address consists of 6 bytes (2 digits each) separated by ':'. > + * The expected format is: "XX:XX:XX:XX:XX:XX" > + */ > +#define MLNX_MFG_OOB_MAC_FORMAT_LEN \ > + ((ETH_ALEN * 2) + (ETH_ALEN - 1)) > > /* ARM SMC call which is atomic and no need for lock. */ > static int mlxbf_bootctl_smc(unsigned int smc_op, int smc_arg) > @@ -454,6 +498,384 @@ static ssize_t os_up_store(struct device *dev, > return count; > } > > +static ssize_t oob_mac_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct arm_smccc_res res; > + u8 *mac_byte_ptr; > + > + mutex_lock(&mfg_ops_lock); > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, MLNX_MFG_TYPE_OOB_MAC, 0, 0, 0, > + 0, 0, 0, &res); > + mutex_unlock(&mfg_ops_lock); > + if (res.a0) > + return -EPERM; > + > + mac_byte_ptr = (u8 *)&res.a1; > + > + return sysfs_format_mac(buf, mac_byte_ptr, ETH_ALEN); > +} > + > +static ssize_t oob_mac_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + unsigned int byte[MLNX_MFG_OOB_MAC_FORMAT_LEN] = { 0 }; > + struct arm_smccc_res res; > + int byte_idx, len; > + u64 mac_addr = 0; > + u8 *mac_byte_ptr; > + > + if ((count - 1) != MLNX_MFG_OOB_MAC_FORMAT_LEN) > + return -EINVAL; > + > + len = sscanf(buf, "%02x:%02x:%02x:%02x:%02x:%02x", > + &byte[0], &byte[1], &byte[2], > + &byte[3], &byte[4], &byte[5]); > + if (len != ETH_ALEN) > + return -EINVAL; > + > + mac_byte_ptr = (u8 *)&mac_addr; > + > + for (byte_idx = 0; byte_idx < ETH_ALEN; byte_idx++) > + mac_byte_ptr[byte_idx] = (u8)byte[byte_idx]; > + > + mutex_lock(&mfg_ops_lock); > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, MLNX_MFG_TYPE_OOB_MAC, > + ETH_ALEN, mac_addr, 0, 0, 0, 0, &res); > + mutex_unlock(&mfg_ops_lock); > + > + return res.a0 ? -EPERM : count; > +} > + > +static ssize_t opn_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 opn_data[MLNX_MFG_VAL_QWORD_CNT(OPN) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(OPN); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_OPN_0 + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + opn_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)opn_data); > +} > + > +static ssize_t opn_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 opn[MLNX_MFG_VAL_QWORD_CNT(OPN)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_OPN_VAL_LEN) > + return -EINVAL; > + > + memcpy(opn, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(OPN); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_OPN_0 + word, > + sizeof(u64), opn[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t sku_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 sku_data[MLNX_MFG_VAL_QWORD_CNT(SKU) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(SKU); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_SKU_0 + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + sku_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)sku_data); > +} > + > +static ssize_t sku_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 sku[MLNX_MFG_VAL_QWORD_CNT(SKU)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_SKU_VAL_LEN) > + return -EINVAL; > + > + memcpy(sku, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(SKU); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_SKU_0 + word, > + sizeof(u64), sku[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t modl_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 modl_data[MLNX_MFG_VAL_QWORD_CNT(MODL) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(MODL); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_MODL_0 + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + modl_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)modl_data); > +} > + > +static ssize_t modl_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 modl[MLNX_MFG_VAL_QWORD_CNT(MODL)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_MODL_VAL_LEN) > + return -EINVAL; > + > + memcpy(modl, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(MODL); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_MODL_0 + word, > + sizeof(u64), modl[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t sn_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 sn_data[MLNX_MFG_VAL_QWORD_CNT(SN) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(SN); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_SN_0 + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + sn_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)sn_data); > +} > + > +static ssize_t sn_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 sn[MLNX_MFG_VAL_QWORD_CNT(SN)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_SN_VAL_LEN) > + return -EINVAL; > + > + memcpy(sn, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(SN); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_SN_0 + word, > + sizeof(u64), sn[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t uuid_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 uuid_data[MLNX_MFG_VAL_QWORD_CNT(UUID) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(UUID); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_UUID_0 + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + uuid_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)uuid_data); > +} > + > +static ssize_t uuid_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 uuid[MLNX_MFG_VAL_QWORD_CNT(UUID)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_UUID_VAL_LEN) > + return -EINVAL; > + > + memcpy(uuid, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(UUID); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_UUID_0 + word, > + sizeof(u64), uuid[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t rev_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + u64 rev_data[MLNX_MFG_VAL_QWORD_CNT(REV) + 1] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(REV); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_GET_MFG_INFO, > + MLNX_MFG_TYPE_REV + word, > + 0, 0, 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + rev_data[word] = res.a1; > + } > + mutex_unlock(&mfg_ops_lock); > + > + return snprintf(buf, PAGE_SIZE, "%s", (char *)rev_data); > +} > + > +static ssize_t rev_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u64 rev[MLNX_MFG_VAL_QWORD_CNT(REV)] = { 0 }; > + struct arm_smccc_res res; > + int word; > + > + if (count > MLNX_MFG_REV_VAL_LEN) > + return -EINVAL; > + > + memcpy(rev, buf, count); > + > + mutex_lock(&mfg_ops_lock); > + for (word = 0; word < MLNX_MFG_VAL_QWORD_CNT(REV); word++) { > + arm_smccc_smc(MLXBF_BOOTCTL_SET_MFG_INFO, > + MLNX_MFG_TYPE_REV + word, > + sizeof(u64), rev[word], 0, 0, 0, 0, &res); > + if (res.a0) { > + mutex_unlock(&mfg_ops_lock); > + return -EPERM; > + } > + } > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > +static ssize_t mfg_lock_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct arm_smccc_res res; > + unsigned long val; > + int err; > + > + err = kstrtoul(buf, 10, &val); > + if (err) > + return err; > + > + if (val != 1) > + return -EINVAL; > + > + mutex_lock(&mfg_ops_lock); > + arm_smccc_smc(MLXBF_BOOTCTL_LOCK_MFG_INFO, 0, 0, 0, 0, 0, 0, 0, &res); > + mutex_unlock(&mfg_ops_lock); > + > + return count; > +} > + > static DEVICE_ATTR_RW(post_reset_wdog); > static DEVICE_ATTR_RW(reset_action); > static DEVICE_ATTR_RW(second_reset_action); > @@ -463,6 +885,14 @@ static DEVICE_ATTR_WO(fw_reset); > static DEVICE_ATTR_WO(rsh_log); > static DEVICE_ATTR_RW(large_icm); > static DEVICE_ATTR_WO(os_up); > +static DEVICE_ATTR_RW(oob_mac); > +static DEVICE_ATTR_RW(opn); > +static DEVICE_ATTR_RW(sku); > +static DEVICE_ATTR_RW(modl); > +static DEVICE_ATTR_RW(sn); > +static DEVICE_ATTR_RW(uuid); > +static DEVICE_ATTR_RW(rev); > +static DEVICE_ATTR_WO(mfg_lock); > > static struct attribute *mlxbf_bootctl_attrs[] = { > &dev_attr_post_reset_wdog.attr, > @@ -474,6 +904,14 @@ static struct attribute *mlxbf_bootctl_attrs[] = { > &dev_attr_rsh_log.attr, > &dev_attr_large_icm.attr, > &dev_attr_os_up.attr, > + &dev_attr_oob_mac.attr, > + &dev_attr_opn.attr, > + &dev_attr_sku.attr, > + &dev_attr_modl.attr, > + &dev_attr_sn.attr, > + &dev_attr_uuid.attr, > + &dev_attr_rev.attr, > + &dev_attr_mfg_lock.attr, > NULL > }; > > diff --git a/drivers/platform/mellanox/mlxbf-bootctl.h b/drivers/platform/mellanox/mlxbf-bootctl.h > index 613963d448f2..1299750a8661 100644 > --- a/drivers/platform/mellanox/mlxbf-bootctl.h > +++ b/drivers/platform/mellanox/mlxbf-bootctl.h > @@ -81,6 +81,14 @@ > */ > #define MLXBF_BOOTCTL_FW_RESET 0x8200000D > > +/* > + * SMC function IDs to set, get and lock the manufacturing information > + * stored within the eeprom. > + */ > +#define MLXBF_BOOTCTL_SET_MFG_INFO 0x8200000E > +#define MLXBF_BOOTCTL_GET_MFG_INFO 0x8200000F > +#define MLXBF_BOOTCTL_LOCK_MFG_INFO 0x82000011 > + > /* > * SMC function IDs to set and get the large ICM carveout size > * stored in the eeprom.