From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEFDA305970 for ; Fri, 5 Dec 2025 10:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764928892; cv=none; b=cF882Qm4t+ckHG3WRm9TWgwf2dWwca5X9PVj7L2x2XPDgGT8dnn82dNbvsMMIWtnDLFpJgFpJGTSgN17fcNCGKPWvLLHOJXHvKNAvwYS/sWGUHltytbrqxZ6c9MUbDqpXZP7gwXdFJJd2TV90OnNnVzFH7NLVUu89/S1W07PWGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764928892; c=relaxed/simple; bh=1UfligJQHsBEf/oWTPoxlgLQvvDW/tlYGi3/ZN3SZds=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KqsBQZVBzhK7FJkf1VdhJZ7y8b1E7QUvHBFG8pNU8QYW3jLympzkdQBY+VEvWdkMj50+zKqI+tDQvG7gQxj3nHnLB0fZoy9cLcCWePNv5OkZ5kuHGo2cupjPJRxE0mNBUq6o53ghjoTybeb25L5CJchRxVuBxiR6smTgzoSt+nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lWH1PLfQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HAOznVks; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lWH1PLfQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HAOznVks" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B553mlu3522346 for ; Fri, 5 Dec 2025 10:01:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oeP/m2fJagJh7n1ezuCSp5/oRqR7bYSQxaqZUom0L6E=; b=lWH1PLfQW/wBOKj/ KmfW/o8v++WoKd+IZB9jTgv5J+PYwc5XoNY2upqQHZWHIFsg7fZcyD6AaUbVarNf vn+r2OLxJ0tICRLQ/VAfJIMLDysHiDiP+PD8nLAp+xWz6co+fyRkBSs8n25WZ1rB WW9aQUNgenvB6pFZR9GUSTc32kMQ8UCGuiw7TFh8Avyq208mnrEpAp/GeI7YZWrL ImFFLub9/Tt1lSzZEd4iyF84Es1CGjyo/23eMLT6ZUhMvnfxNMyiK3/u1QaeuPWz QptHjo5241rwkZpGUt8p5b8VDCU6SeueDoNhViOnyaTy3SOvEmXfioo144yXkimr oUE+2A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aurwvgsg4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 10:01:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee23b6b6fdso3573101cf.0 for ; Fri, 05 Dec 2025 02:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764928881; x=1765533681; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oeP/m2fJagJh7n1ezuCSp5/oRqR7bYSQxaqZUom0L6E=; b=HAOznVkss/O6/Gjml7Osiev4gOL2QCOeyVWBuU0ub5uqsELvbe1Dlju/xnquj0MvhM HIs9l66sucESxLYQjsnzznMDOBVC7abMfIWD6uvfbdEQzs94zNW94w/hRq/cjyG7pLvp Xx8ovzrthcYShzw+npKT0J8IAG9wgC5UD8QKWl9emnYlxO4PYloSgLiWSM23Xm614TrO T0W2ZjxvsURq4Doic8ZzNhy1AXCb9S9DzjJbZZUSp2zc3MUe3U8Eqt1xvJi05dL8l5lD 5N8DeBMywJEAbwtXUTIUIerrWmOgDpSvrQ2kvlsIkoo1sfJSCq9j4QyrUwjRkmKr3OAY MBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764928881; x=1765533681; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oeP/m2fJagJh7n1ezuCSp5/oRqR7bYSQxaqZUom0L6E=; b=X1K7m++bn4kbJvXOZLHc9i1OddztUx58L5+t+uNVgFfI7n/EfQP2/KBg70yONT/iuY 828ObsaQ1rDRSaUN+FeRHeMrXqukVYgixSvbXxJ68t5RUwNBB67Z0l8YMgKP3BoaWk3W U1lV0Ti9D5cStLhCFyicN+OCBvkIbGsc/1JPc32wDdNRCFDMdcLS/4ZxVXCG+mpR/lX2 Mbg5gEz8F2eTlkCfyC3uwC0QNDCwEQiwK2ls51MkF8XjiFuzxN7biEAbXmPq3zDgZHrn NgpKPmM5iFFwBO/1DYsReR1mxIjxbr1lg0bGD6jYsSXH71vQVRWXOd4QOSddKHUQEqxD EC0w== X-Forwarded-Encrypted: i=1; AJvYcCXhGYWK39l3zgyCVuU3d6n1OLbmtKjjpa+bSsvFFOsC4j/tPm2ytTEtcDEIbtHJ2nqpMve0wADRABe41LY=@vger.kernel.org X-Gm-Message-State: AOJu0YwlV09VV3yQU9EocqtNgLkNJoMPGYUC7EKlS4GYTN2cbGOJ5C6T lOTCIx7pBmX7NuFSqnZnN/YmV928VUuCSAF2RtH2bDbrwxF9RosQSM3iPFmEVS/vC/tGzyTY6UR ekykXbkPF97Jsedz4Y7f3FgudtGNyiHzM6scOHNQS4krEdK/Ov+gzG4S3pb9mtoPKGT8= X-Gm-Gg: ASbGncsC2F8XJrjPt2thOxm6LaeoRFaG7WuHVQ/EgcqOcK0Yl/D+3gfqm9Chn0N9/B9 8Xbam/a1G+UgKA/PDIECp8EoP2KUqt5aSRGrNejjAkajdskwdf4mzDDdfgndSI05WSjdzhh/oSv 96yMlcvn47is1BZo1ZYxm554heu8oP+L00J7UwU0M1plrdmegrXr0aOBaUvWOG7HWR0OdiMG7cu SENfKQyuH/f2T0dADlF0nugXm3MMvaG3qsgwI/yqmxSwF2tbnzyO1+I2rRZKVyfl3+4Iomy1kmQ IgZcJJyXEURuo9xjw0JKprYa9KTsg53W26U70qhPU23wjAx5krgazu8nVivDYGeNgSZu2YVwmAh XdAWvh9qfmuliMG4enEEVCd67Fc5IX+aLOjrJ+13vVXqK9uztemYPtsmTonJ+aXLfVg== X-Received: by 2002:ac8:5702:0:b0:4ee:4214:3226 with SMTP id d75a77b69052e-4f01b21e81dmr87142451cf.6.1764928881112; Fri, 05 Dec 2025 02:01:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKshyoRtp9ZzsajxtgrEuEZW1LKNnO0PjqbOpSQZBzXPV/Xv7fWXBN10MdVp54WsP1yl7acg== X-Received: by 2002:ac8:5702:0:b0:4ee:4214:3226 with SMTP id d75a77b69052e-4f01b21e81dmr87142021cf.6.1764928880561; Fri, 05 Dec 2025 02:01:20 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b2edf5a7sm3383939a12.13.2025.12.05.02.01.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 02:01:19 -0800 (PST) Message-ID: Date: Fri, 5 Dec 2025 11:01:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH WIP v2 7/8] media: qcom: camss: csiphy-3ph: C-PHY needs own lane configuration To: david@ixit.cz, Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251204-qcom-cphy-v2-0-6b35ef8b071e@ixit.cz> <20251204-qcom-cphy-v2-7-6b35ef8b071e@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251204-qcom-cphy-v2-7-6b35ef8b071e@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA3MyBTYWx0ZWRfX8XaNArvY9ZPU Bjce8NVhjVc/+W4cCOWWYPRf1CEl/KosRXcLruyomPNKo+a0cNxW/XGpjhBwCv+rQfMHHkG9m+L IkJ3gnSne4oekDgJZYgoSgd+A42vK+caRb8QBo2RF8ap5uk1PaUjYfiWzwP3yO+Ul/sQEdZHqhR GSR/q5W7LrOU0LMECZnEmgsBxu3Lsaa8c0GkwhwZsELGF8oNCyBOw8fHfdBfioaQsgbSalkGAEF kLokf4Gmosh2VjBxS5RXg86oRSsh00e05B/SS+/bdkTp12kX9CHd182W9fmX+PmzawBrPeEsPyb usnvAUHg5blfztQXNaPJzLxN9NT3hvDj6Y7aPWkwlm6fA4nBstoquQypMCyNtU3j1A3Dm9zdoeS HFbzJ/t4S2NA698HQhjs/Rls0dUljg== X-Authority-Analysis: v=2.4 cv=Yd2wJgRf c=1 sm=1 tr=0 ts=6932ad71 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=5e6XgBO0iodNXUd1Y8AA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: 8wQ_Jon4W4oIVyKKKxIIUyCrFSc59XR8 X-Proofpoint-ORIG-GUID: 8wQ_Jon4W4oIVyKKKxIIUyCrFSc59XR8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050073 On 12/4/25 5:32 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Make sure we have proper lane registers definition in-place for each > generation, otherwise C-PHY won't work. > > Signed-off-by: David Heidelberg > --- > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 48 ++++++++++++++++------ > 1 file changed, 36 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index 6d6dd54c5ac9c..c957f7dbfb243 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -1222,8 +1222,12 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy, > } > break; > case CAMSS_2290: > - regs->lane_regs = &lane_regs_qcm2290[0]; > - regs->lane_array_size = ARRAY_SIZE(lane_regs_qcm2290); > + if (c->phy_cfg == V4L2_MBUS_CSI2_CPHY) { > + dev_err(dev, "Missing lane_regs definition for %d\n", c->phy_cfg); > + } else { /* V4L2_MBUS_CSI2_DPHY */ If you're checking for C-PHY specifically then just say it in writing instead of printing a magic integer Konrad