mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zenghui Yu <zenghui.yu@linux.dev>
To: SJ Park <sj@kernel.org>
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/damon/api: remove unused NR_DAMOS_* enumerators
Date: Sun, 20 Sep 2026 20:34:48 +0800	[thread overview]
Message-ID: <e0c63f91-4d33-469e-a584-f97fdf8c3cc5@linux.dev> (raw)
In-Reply-To: <20260920100029.46849-1-sj@kernel.org>

On 9/20/26 6:00 PM, SJ Park wrote:
> On Sun, 20 Sep 2026 09:20:28 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:
> 
> > From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> >
> > NR_DAMOS_ACTIONS, NR_DAMOS_QUOTA_GOAL_METRICS, and NR_DAMOS_WMARK_METRICS
> 
> More than 72 columns.

I learnt from submitting-patches.rst that

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

But I'm also fine with the 72 columns rule for damon patches (or for mm
patches?).

> > are not referenced by any code.  Remove them.
> >
> > They can be reintroduced if a real user comes up.
> >
> > Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> 
> Other than the above too trivial thing,
> 
> Reviewed-by: SJ Park <sj@kernel.org>

Thanks!

Zenghui

  reply	other threads:[~2026-09-20 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  1:20 Zenghui Yu
2026-09-20 10:00 ` SJ Park
2026-09-20 12:34   ` Zenghui Yu [this message]
2026-09-20 13:12     ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0c63f91-4d33-469e-a584-f97fdf8c3cc5@linux.dev \
    --to=zenghui.yu@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®