From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A0032AACD for ; Mon, 26 Jan 2026 14:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769439165; cv=none; b=alDqm0okVkYUlyH7hvmciUpN3BrGyGwZp3Zn3Y1aYUjD5voArG1KdYQVnDbc8LW2osFe/dBbaMmiWXYGYJnpR+hlqMkiLMl1O73aeQyUVhNMIuHlwWEMTf0RLT/2EvhMk6dCnmHyrypDsp7JycTFkYhWdVnTrL/LqZVGBf3vGeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769439165; c=relaxed/simple; bh=W8vUeDRpH3pYz+VDSE0A9FZJpBC70kSW/o6OJ+RHNnM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d1p1wdIbnMxEp9fLPmcc1DYB07OifKR2W7axPLE3f5XKpY/JbD8cbxrna4xc4Frulemy9zv83crFxSNPR9vlXPsw4NmixLuyOFX1BnMN359RzrBcErpq6cHrLT2osbYE17mfopWIn3lLVYWL3bH08Ls3zN5xb7J9R5Xs8uDGwxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4McaRLX; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4McaRLX" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-352ccc61658so2028939a91.0 for ; Mon, 26 Jan 2026 06:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769439163; x=1770043963; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DP+ZmH2UM1I6ZfNxAh7TKW7S2/6RCg1qO9r0nylhgIU=; b=Y4McaRLXF/7iqfXw2ZBNSU21YjmWRl+W2hYanxAP8cAlULzKJiqD4FBlLusSkNkOI9 oHWyEVr3ZQScvgqyea/EbUBzPMFJaSFlsX6Yt4xAhJhhq8Nth6hIs0d/59fqfcys7awh W9qLrUKWwhBi4g2ALmlFwOnbgvbJRZqYNKQ8fb9rW54VfhOlydzVX3AdnPP61wpDPNh+ aEsPnIWpfo4PKOXCwJ2vn7qCEXLs8LfVQOKN6MsPJSNuEa1iBRNMUCGYfs8iTbRgQlTj uDmYWgEQR/n1ZtLaDVrm2ssW+7SkLn2sNlHvSRlbRKZIZWoRCBrqtYDFL558FDeuqDB/ ptSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769439163; x=1770043963; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DP+ZmH2UM1I6ZfNxAh7TKW7S2/6RCg1qO9r0nylhgIU=; b=d8FYM2e6LdLdY0t5BHtpT3kLFAVYJ0we02av+bfjH0Ia8KdX7Q+0z+D5GH+46o8/Eq c776IyrIpzZFPioZAQwzowVFkXMawAyu6bA7Jysh2fRZmz85fnZ8+PIO75PaKcjPt9tV J4wsCnYuaGXBnW4oY6bLqep+rccOacQ3q07oY+YPEaS3k+R3/w2PDiaUwirvESrt8qcX zk43O1L9JGwz6Fy+yLmUbYhOz4UtaXgpnN90BkVIXxMlNU2wq/t1vbVBRqV/4E1YYWNU GUCxcNVugSoJ2qqBFOGxRSkijzgIa3F3eM+NJ8+eARWxHIl8FDVqZkwg7d18m47rYszE DMew== X-Forwarded-Encrypted: i=1; AJvYcCVqgoqAN2YvVit5G+j1FtgcqIaNIadcjvBGvWhbvsh82ThgKLUuz274ackvDYg5kJwPlyv6QP+jURkjG64=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr7Kl0bjlfIOtPhD29ISfaBjhSSnFCr/3hOX91xrIfAATTOckq W3CukChVDhxN8tGurIxfFKvStFJAMxDZbXXNtZds37sQfWCbE6M4HiXk X-Gm-Gg: AZuq6aKJ974RSZXSFOP9VTGGhyvXlAa8ivgc4lbd0w9yGxhfIKuxHs/X1CG6moRr4Mq Q0froZH2vfarSoIaGVHv0fgo3Jrx4jf6wEGe+4CC3Yeq3LtCrKRJVUsy3ob6IW7AthcjhypenVW oEY4U/vcbsHNQSSzJtRQdVAfTG9aPrGIuOhpkl79pIFbHMbWo69R9ppI5FCcwjRmcKifzA/rUe/ rF2ReIIeFwRxIq65GjdBUFQ25y6ir/vWbhFIhITYr0clbc71Da11B31HUTHE/KhM+bbQQF3sDpD wcfulone4p+ZshHEOa5wm4eiNQmYi2+AvGtecwUldxZg5BGIH4J24VgNZMdXVB9thHkSLilWGEq Z/mCKszjGRTFaFkrKq9bMt9WsO3QWteq0uV8oQpyCLFKVuR36C2ERvcynDYVSv5g53HS2lqMvuF E17bRTwlYMq47Dt+p7llfTQokcV/h6wH+er5YuKx6aSVCRasIv9nZ6wsv6GeGz+s7trCVF X-Received: by 2002:a17:90b:5645:b0:34c:c866:81ec with SMTP id 98e67ed59e1d1-353c41a6e98mr4162627a91.36.1769439163011; Mon, 26 Jan 2026 06:52:43 -0800 (PST) Received: from ?IPV6:2401:4900:8f4d:8999:841:138a:e0ca:d28b? ([2401:4900:8f4d:8999:841:138a:e0ca:d28b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-353354a6926sm11894276a91.12.2026.01.26.06.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 06:52:42 -0800 (PST) Message-ID: Date: Mon, 26 Jan 2026 20:22:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: nvmem: nxp,lpc1850-otp: convert to DT schema To: Vladimir Zapolskiy , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-lpc1850-otp-v1-1-8bd957dd9c98@gmail.com> <0ff7932a-c210-4d7a-9405-a77db0f349e7@mleia.com> Content-Language: en-US From: Akhila YS In-Reply-To: <0ff7932a-c210-4d7a-9405-a77db0f349e7@mleia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26-01-2026 18:58, Vladimir Zapolskiy wrote: > Hello Akhila. > > On 1/23/26 17:19, Akhila YS wrote: >> Convert NXP LPC18xx OTP memory controller binding to YAML format. >> >> Signed-off-by: Akhila YS >> --- >>   .../devicetree/bindings/nvmem/lpc1850-otp.txt      | 20 --------- >>   .../devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml | 51 >> ++++++++++++++++++++++ >>   2 files changed, 51 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt >> b/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt >> deleted file mode 100644 >> index 853b6a754644..000000000000 >> --- a/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt >> +++ /dev/null >> @@ -1,20 +0,0 @@ >> -* NXP LPC18xx OTP memory >> - >> -Internal OTP (One Time Programmable) memory for NXP LPC18xx/43xx >> devices. >> - >> -Required properties: >> -  - compatible: Should be "nxp,lpc1850-otp" >> -  - reg: Must contain an entry with the physical base address and >> length >> -    for each entry in reg-names. >> -  - address-cells: must be set to 1. >> -  - size-cells: must be set to 1. >> - >> -See nvmem.txt for more information. >> - >> -Example: >> -  otp: otp@40045000 { >> -    compatible = "nxp,lpc1850-otp"; >> -    reg = <0x40045000 0x1000>; >> -    #address-cells = <1>; >> -    #size-cells = <1>; >> -  }; >> diff --git >> a/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml >> b/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml >> new file mode 100644 >> index 000000000000..d37e928e7a35 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/nvmem/nxp,lpc1850-otp.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP LPC18xx / LPC43xx One-Time Programmable (OTP) memory >> + >> +maintainers: >> +  - Srinivas Kandagatla > > You may add me as a maintainer, the change is not catched by the > "lpc18xx" > file name pattern from a record in the MAINTAINERS file, but essentially > it's an NXP LPC18xx/LPC43xx related change.  > Sure, I will add you as a maintainer. >> + >> +description: >> +  The internal OTP memory in NXP LPC18xx and LPC43xx microcontrollers >> +  provides a dedicated non-volatile storage area designed for >> permanent, >> +  one-time configuration and data storage.The OTP controller manages >> write > > Please remove all info after the first sentence. > >> +  protection, programming sequencing, and error detection mechanisms to >> +  guarantee reliable and safe permanent programming under software >> control. > > What is the source of the information above? I don't quite understand > what > is "error detection mechanisms" here etc. OTP controller functions are > defined in SoC ROM, and it is unrelated to the described OTP memory > region.  Ok. > >> + >> +allOf: >> +  - $ref: nvmem.yaml# >> + >> +properties: >> +  compatible: >> +    const: nxp,lpc1850-otp >> + >> +  reg: >> +    maxItems: 1 >> + >> +  "#address-cells": >> +    const: 1 >> + >> +  "#size-cells": >> +    const: 1 > > This comes from nvmem.yaml  Yes, I will remove above two properties. > >> + >> +required: >> +  - compatible >> +  - reg >> +  - "#address-cells" >> +  - "#size-cells" > > Please drop #address-cells/#size-cells from the list of the required > properties. > > So far there is no user of this device tree node, and "nvmem-layout" > mechanism may be preferred in future.  Ok. > >> + >> +unevaluatedProperties: false >> + >> +examples: >> +  - | >> +    otp@40045000 { >> +        compatible = "nxp,lpc1850-otp"; >> +        reg = <0x40045000 0x1000>; >> +        #address-cells = <1>; >> +        #size-cells = <1>; >> +    }; >> +... >> > -- Best Regards, Akhila.