From: Milos Tijanic <mtijanic@nvidia.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mohamedahmedegypt2001@gmail.com"
<mohamedahmedegypt2001@gmail.com>
Cc: "tzimmermann@suse.de" <tzimmermann@suse.de>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"lyude@redhat.com" <lyude@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"mary@mary.zone" <mary@mary.zone>,
"airlied@gmail.com" <airlied@gmail.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [PATCH 0/6] drm/nouveau: GSP telemetry via RUSD, and fdinfo telemetry exposure
Date: Tue, 21 Jul 2026 10:39:48 +0000 [thread overview]
Message-ID: <e0cc44dcc3efac7f354ce9a6eba1a9a87a1b096f.camel@nvidia.com> (raw)
In-Reply-To: <20260714211429.238355-1-mohamedahmedegypt2001@gmail.com>
On Wed, 2026-07-15 at 01:14 +0400, Mohamed Ahmed wrote:
> A section that has
> not been polled yet, or that the board does not support, reads
> -ENODATA.
Per hwmon/sysfs-interface.rst: "All entries (except name) are optional,
and should only be created in a given driver if the chip has the
feature."
It feels really weird to have a bunch of things there that just give an
error code when reading. Does anything else use this pattern?
> - The sysfs interface exposed here should be stable and valid for
> nova as well.
Agreed. Please allow a bit of time for us to review the uAPI for Nova
and future GSP versions.
> RUSD is stable and only grows more fields with newer GSP firmware
> (e.g., fan telemetry gets added in r580), so it is possible to keep
> the same interface as we use newer firmware
Don't assume this. Work is underway to significantly rework the RUSD
layout to make it extensibe in ABI-compatible ways, but there will be
a single large ABI break compared to 570. This will happen when we add
RUSD support to Nova, so it's some months out still.
> - amdgpu offers a single binary blob with all the telemetry
> embedded in
> addition to the sysfs sensor files. This series currently only
> exposes
> sensor files, but it is possible to add a similar binary for a
> v2.
> This mainly offers a more efficient way to read the telemetry as
> clients would read only a few files instead of reading all of
> them.
IIUC the reason amdgpu does that is so you can take a self-consistent
atomic snapshot of all the telemetry readings. That's just not how RUSD
works, so we don't need/want it.
We don't want to expose binary RUSD to userspace while it is unstable.
Once it does become stable, the way this was meant to be exposed is to
allow userspace to RO mmap the buffer and read the telemetry directly,
with no syscall overhead. But I'm kind of loathe to do that even with
the new format as it will require some parsing and that's easy to get
wrong on the userspace side and still work in a given version, then
break with an update.
We can revisit this when ABI-stable RUSD comes, and then maybe have a
reference librusd that does the parsing.
next prev parent reply other threads:[~2026-07-21 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 21:14 Mohamed Ahmed
2026-07-14 21:14 ` [PATCH 1/6] drm/nouveau/gsp: vendor the RUSD header Mohamed Ahmed
2026-07-14 21:14 ` [PATCH 2/6] drm/nouveau/gsp: add RUSD telemetry support Mohamed Ahmed
2026-07-21 18:23 ` lyude
2026-07-14 21:14 ` [PATCH 3/6] drm/nouveau: add GSP hwmon support Mohamed Ahmed
2026-07-21 18:36 ` lyude
2026-07-21 19:36 ` Mohamed Ahmed
2026-07-21 20:36 ` lyude
2026-07-14 21:14 ` [PATCH 4/6] drm/nouveau: expose RUSD telemetry via sysfs Mohamed Ahmed
2026-07-14 21:14 ` [PATCH 5/6] drm/nouveau: expose global VRAM size and usage " Mohamed Ahmed
2026-07-14 21:14 ` [PATCH 6/6] drm/nouveau: expose per-client GPU usage via fdinfo Mohamed Ahmed
2026-07-20 22:16 ` [PATCH 0/6] drm/nouveau: GSP telemetry via RUSD, and fdinfo telemetry exposure lyude
2026-07-21 10:39 ` Milos Tijanic [this message]
2026-07-21 15:11 ` Mohamed Ahmed
2026-07-21 20:40 ` lyude
2026-07-21 20:46 ` Mohamed Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0cc44dcc3efac7f354ce9a6eba1a9a87a1b096f.camel@nvidia.com \
--to=mtijanic@nvidia.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mary@mary.zone \
--cc=mohamedahmedegypt2001@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®