Re: [PATCH wireless-next] wifi: mac80211_hwsim: advertise puncturing feature support

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2025-10-17 at 09:32 +0530, Aditya Kumar Singh wrote:
> If userspace provides a puncturing bitmap via the NL80211_ATTR_PUNCT_BITMAP
> attribute, the kernel with mac80211_hwsim driver currently rejects the
> command with the error: "driver doesn't support puncturing", because the
> driver does not advertise support for this feature.
> 
> At present, the following hwsim test cases utilize puncturing, but the
> bitmap is not sent to the kernel. Instead, the puncturing information is
> conveyed only through the beacon data:
>  * eht_5ghz_80mhz_puncturing_override_1
>  * eht_5ghz_80mhz_puncturing_override_2
>  * eht_5ghz_80mhz_puncturing_override_3
> 
> A future change in hostapd will begin configuring the puncturing bitmap
> explicitly, which will cause these test cases to fail unless the driver
> advertises support.
> 
> To address this, update mac80211_hwsim driver to advertise puncturing
> feature support.

This might be a good time to introduce better checks vs. what we have
now in hwsim_chans_compat(), which just uses the control channel rather
than any actual bandwidth/puncturing/etc.

It'd also make the tests actually test more. What do you think?

johannes